aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Wu <peter@lekensteyn.nl>2016-01-25 19:19:19 +0100
committerPeter Wu <peter@lekensteyn.nl>2016-01-25 21:05:30 +0000
commit0f5bed39fe90659615b192d9a88d7d206d349fff (patch)
tree4d70ecf42efac148d45b798c67755a4bd19b6803
parent623e5365e51723d880b5f4c010b2e745ad8da34d (diff)
ssl: fix RSA key matching with Client certs
Avoid a RSA private key lookup for client certificates, the RSA private key is only valid for the server certificate. The lookup based on the client cert resulted in overwriting the server match. Bug: 12042 Change-Id: I60aa79f8f2b941bfde032e20ab11446ae4e6c81b Reviewed-on: https://code.wireshark.org/review/13530 Petri-Dish: Peter Wu <peter@lekensteyn.nl> Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org> Reviewed-by: Peter Wu <peter@lekensteyn.nl>
-rw-r--r--epan/dissectors/packet-ssl-utils.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/epan/dissectors/packet-ssl-utils.c b/epan/dissectors/packet-ssl-utils.c
index a72e350fbe..3c40f53f72 100644
--- a/epan/dissectors/packet-ssl-utils.c
+++ b/epan/dissectors/packet-ssl-utils.c
@@ -5978,7 +5978,7 @@ ssl_dissect_hnd_cert(ssl_common_dissect_t *hf, tvbuff_t *tvb, proto_tree *tree,
}
#if defined(HAVE_LIBGNUTLS) && defined(HAVE_LIBGCRYPT)
- if (ssl)
+ if (is_from_server && ssl)
ssl_find_private_key_by_pubkey(ssl, key_hash, &subjectPublicKeyInfo);
#endif
}