aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHolger Hans Peter Freyther <zecke@selfish.org>2013-04-01 09:51:02 +0200
committerHolger Hans Peter Freyther <zecke@selfish.org>2013-04-01 10:48:44 +0200
commita0257331f3c602e61c7584b8295e5aa2f58c910c (patch)
tree650da40bc126f21c9e437d9b64790d908b7fa482
parent5af90bdfd8590b096f9d74637f9771a108fd7ec7 (diff)
misc: Fix warnings reported by the code critics of Pharo
-rw-r--r--core/MessageStructure.st2
-rw-r--r--osmo/OsmoAppConnection.st4
-rw-r--r--osmo/OsmoCtrlConnection.st2
3 files changed, 6 insertions, 2 deletions
diff --git a/core/MessageStructure.st b/core/MessageStructure.st
index 65a9980..e62a927 100644
--- a/core/MessageStructure.st
+++ b/core/MessageStructure.st
@@ -353,7 +353,7 @@ Object subclass: MSGField [
aLength < self octalLength ifTrue: [
^ self error:
('The data is too short. <1p> < <2p>'
- expandMacrosWith aLength with: self octalLength).
+ expandMacrosWith: aLength with: self octalLength).
].
self maxLength ifNotNil: [
aLength > self maxLength ifTrue: [
diff --git a/osmo/OsmoAppConnection.st b/osmo/OsmoAppConnection.st
index 92993a8..cf789a4 100644
--- a/osmo/OsmoAppConnection.st
+++ b/osmo/OsmoAppConnection.st
@@ -91,6 +91,10 @@ TODO: re-use the IPADispatcher across connections.'>
muxer nextPut: aData with: IPAConstants protocolOsmoCTRL
]
+ nextPut: aData with: aConstant [
+ muxer nextPut: aData with: aConstant
+ ]
+
token: aToken [
token := aToken.
]
diff --git a/osmo/OsmoCtrlConnection.st b/osmo/OsmoCtrlConnection.st
index cd74053..29fbaf9 100644
--- a/osmo/OsmoCtrlConnection.st
+++ b/osmo/OsmoCtrlConnection.st
@@ -31,7 +31,7 @@ OsmoAppConnection subclass: OsmoCtrlConnection [
]
initializeDispatcher [
- super dispatcher.
+ super initializeDispatcher.
dispatcher
addHandler: IPAConstants protocolOsmoCTRL
on: self with: #handleCTRL:.