diff options
| author | Harald Welte <laforge@gnumonks.org> | 2018-07-04 04:39:40 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2018-07-04 04:42:22 +0200 |
| commit | 05cc7f653137d7ddee7572eb946c8ee7f881cbff (patch) | |
| tree | e160549a94b5cdd22789d33d415945d25418b342 /firmware/libcommon/include | |
| parent | 46893451deebdeeea3f6dd11c77278eb60f35d5c (diff) | |
ringbuffer: Don't print/TRAC from ringbuffer
In commit eac1bec4285a48b466e9fd09b0513b3c49d393b3 we start to use the
ringbuffer inside the console printing code. As a result, we must not
use TRACE_*() or printf() from within ringbuffer.c code to avoid
infinite recursion.
Instead, let rbuf_write() return a negative return value in case the
ring buffer overflows. This way, the callers (outside the
console/stdout code) can print an error message themselves.
Change-Id: Ib009f013be119dbad22fa2b7d60ec8dee59baee5
Diffstat (limited to 'firmware/libcommon/include')
| -rw-r--r-- | firmware/libcommon/include/ringbuffer.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/firmware/libcommon/include/ringbuffer.h b/firmware/libcommon/include/ringbuffer.h index 1d29760..efc557c 100644 --- a/firmware/libcommon/include/ringbuffer.h +++ b/firmware/libcommon/include/ringbuffer.h @@ -16,7 +16,7 @@ typedef struct ringbuf { void rbuf_reset(volatile ringbuf * rb); uint8_t rbuf_read(volatile ringbuf * rb); uint8_t rbuf_peek(volatile ringbuf * rb); -void rbuf_write(volatile ringbuf * rb, uint8_t item); +int rbuf_write(volatile ringbuf * rb, uint8_t item); bool rbuf_is_empty(volatile ringbuf * rb); bool rbuf_is_full(volatile ringbuf * rb); |