From c8cbfc2c9800929a46ffa71e3bd0f34aa9b42f33 Mon Sep 17 00:00:00 2001 From: Jacob Erlbeck Date: Tue, 1 Sep 2015 11:38:40 +0200 Subject: bts: Start a DL TBF if needed after establishment of an UL TBF Currently an existing DL TBF can get lost in the process of establishing an UL TBF via RACH. This can lead to stalled connections until the network sends more LLC frames. This commit adds a check for a non-empty LLC queue after the UL TBF has been established to rcv_control_ack (GPRS_RLCMAC_UL_ASS_WAIT_ACK path) to eventually establish a new DL TBF on the UL TBF's PACCH. Sponsored-by: On-Waves ehf --- tests/tbf/TbfTest.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'tests/tbf/TbfTest.cpp') diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index 2af7e3a..92679bc 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -895,9 +895,8 @@ static void test_tbf_dl_flow_and_rach_two_phase() ms = the_bts.ms_by_tlli(tlli1); OSMO_ASSERT(ms2 == ms); - /* DL TBF should be the same */ - /* OSMO_ASSERT(ms->dl_tbf()); */ - /* OSMO_ASSERT(ms->dl_tbf() == dl_tbf); */ + /* A DL TBF should still exist */ + OSMO_ASSERT(ms->dl_tbf()); /* No queued packets should be lost */ OSMO_ASSERT(ms->llc_queue()->size() == 2); -- cgit v1.2.3