From d7ec83e6b57f48cf07f663e232e4aa2b32bc33c7 Mon Sep 17 00:00:00 2001 From: Avi Kivity Date: Wed, 8 Feb 2012 17:07:26 +0200 Subject: memory: don't pass ->readable attribute to cpu_register_physical_memory_log It can be derived from the MemoryRegion itself (which is why it is not used there). Signed-off-by: Avi Kivity Reviewed-by: Richard Henderson --- exec-obsolete.h | 2 +- exec.c | 2 +- memory.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exec-obsolete.h b/exec-obsolete.h index 94c23d095..23ffbaaf4 100644 --- a/exec-obsolete.h +++ b/exec-obsolete.h @@ -37,7 +37,7 @@ void cpu_unregister_io_memory(int table_address); struct MemoryRegionSection; void cpu_register_physical_memory_log(struct MemoryRegionSection *section, - bool readable, bool readonly); + bool readonly); void qemu_register_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size); void qemu_unregister_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size); diff --git a/exec.c b/exec.c index b81677ade..d3020ab57 100644 --- a/exec.c +++ b/exec.c @@ -2529,7 +2529,7 @@ static subpage_t *subpage_init (target_phys_addr_t base, ram_addr_t *phys, before calculating this offset. This should not be a problem unless the low bits of start_addr and region_offset differ. */ void cpu_register_physical_memory_log(MemoryRegionSection *section, - bool readable, bool readonly) + bool readonly) { target_phys_addr_t start_addr = section->offset_within_address_space; ram_addr_t size = section->size; diff --git a/memory.c b/memory.c index ccc3efbab..85959ee54 100644 --- a/memory.c +++ b/memory.c @@ -346,7 +346,7 @@ static void as_memory_range_add(AddressSpace *as, FlatRange *fr) .readonly = fr->readonly, }; - cpu_register_physical_memory_log(§ion, fr->readable, fr->readonly); + cpu_register_physical_memory_log(§ion, fr->readonly); } static void as_memory_range_del(AddressSpace *as, FlatRange *fr) @@ -359,7 +359,7 @@ static void as_memory_range_del(AddressSpace *as, FlatRange *fr) .readonly = fr->readonly, }; - cpu_register_physical_memory_log(§ion, true, false); + cpu_register_physical_memory_log(§ion, false); } static void as_memory_log_start(AddressSpace *as, FlatRange *fr) -- cgit v1.2.3