diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2009-12-02 12:24:42 +0100 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2009-12-03 11:45:50 -0600 |
| commit | 40ff6d7e8dceca227e7f8a3e8e0d58b2c66d19b4 (patch) | |
| tree | 98d560a0de229f27a66f637cfcadbb1672e68cc3 /migration-unix.c | |
| parent | 12c09b8ce22d74f78ff50f95676cbe4f501752ae (diff) | |
Don't leak file descriptors
We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
descriptors that don't need to be passed to children to stop this misbehaviour.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'migration-unix.c')
| -rw-r--r-- | migration-unix.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/migration-unix.c b/migration-unix.c index 7dd787cd9..783228b3b 100644 --- a/migration-unix.c +++ b/migration-unix.c @@ -104,7 +104,7 @@ MigrationState *unix_start_outgoing_migration(Monitor *mon, s->state = MIG_STATE_ACTIVE; s->mon = NULL; s->bandwidth_limit = bandwidth_limit; - s->fd = socket(PF_UNIX, SOCK_STREAM, 0); + s->fd = qemu_socket(PF_UNIX, SOCK_STREAM, 0); if (s->fd < 0) { dprintf("Unable to open socket"); goto err_after_alloc; @@ -150,7 +150,7 @@ static void unix_accept_incoming_migration(void *opaque) int c, ret; do { - c = accept(s, (struct sockaddr *)&addr, &addrlen); + c = qemu_accept(s, (struct sockaddr *)&addr, &addrlen); } while (c == -1 && socket_error() == EINTR); dprintf("accepted migration\n"); @@ -191,7 +191,7 @@ int unix_start_incoming_migration(const char *path) dprintf("Attempting to start an incoming migration\n"); - sock = socket(PF_UNIX, SOCK_STREAM, 0); + sock = qemu_socket(PF_UNIX, SOCK_STREAM, 0); if (sock < 0) { fprintf(stderr, "Could not open unix socket: %s\n", strerror(errno)); return -EINVAL; |