aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAvi Kivity <avi@redhat.com>2012-02-08 17:07:26 +0200
committerAvi Kivity <avi@redhat.com>2012-02-29 13:44:42 +0200
commitd7ec83e6b57f48cf07f663e232e4aa2b32bc33c7 (patch)
treea6d308d1a6d8c095b84c7184080aa1e7059a0780
parent7a8499e88bffff66d90300d4f2018c938543b1cf (diff)
memory: don't pass ->readable attribute to cpu_register_physical_memory_log
It can be derived from the MemoryRegion itself (which is why it is not used there). Signed-off-by: Avi Kivity <avi@redhat.com> Reviewed-by: Richard Henderson <rth@twiddle.net>
-rw-r--r--exec-obsolete.h2
-rw-r--r--exec.c2
-rw-r--r--memory.c4
3 files changed, 4 insertions, 4 deletions
diff --git a/exec-obsolete.h b/exec-obsolete.h
index 94c23d095..23ffbaaf4 100644
--- a/exec-obsolete.h
+++ b/exec-obsolete.h
@@ -37,7 +37,7 @@ void cpu_unregister_io_memory(int table_address);
struct MemoryRegionSection;
void cpu_register_physical_memory_log(struct MemoryRegionSection *section,
- bool readable, bool readonly);
+ bool readonly);
void qemu_register_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size);
void qemu_unregister_coalesced_mmio(target_phys_addr_t addr, ram_addr_t size);
diff --git a/exec.c b/exec.c
index b81677ade..d3020ab57 100644
--- a/exec.c
+++ b/exec.c
@@ -2529,7 +2529,7 @@ static subpage_t *subpage_init (target_phys_addr_t base, ram_addr_t *phys,
before calculating this offset. This should not be a problem unless
the low bits of start_addr and region_offset differ. */
void cpu_register_physical_memory_log(MemoryRegionSection *section,
- bool readable, bool readonly)
+ bool readonly)
{
target_phys_addr_t start_addr = section->offset_within_address_space;
ram_addr_t size = section->size;
diff --git a/memory.c b/memory.c
index ccc3efbab..85959ee54 100644
--- a/memory.c
+++ b/memory.c
@@ -346,7 +346,7 @@ static void as_memory_range_add(AddressSpace *as, FlatRange *fr)
.readonly = fr->readonly,
};
- cpu_register_physical_memory_log(&section, fr->readable, fr->readonly);
+ cpu_register_physical_memory_log(&section, fr->readonly);
}
static void as_memory_range_del(AddressSpace *as, FlatRange *fr)
@@ -359,7 +359,7 @@ static void as_memory_range_del(AddressSpace *as, FlatRange *fr)
.readonly = fr->readonly,
};
- cpu_register_physical_memory_log(&section, true, false);
+ cpu_register_physical_memory_log(&section, false);
}
static void as_memory_log_start(AddressSpace *as, FlatRange *fr)