From cdf349bc645d36645dab13e3f975b4deafbee579 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Fri, 7 Dec 2018 09:34:00 +0700 Subject: trx_toolkit: introduce logging configuration arguments Before this change, it was impossible to configure logging parameters from command line, such as log level and format. This change introduces the following optional arguments: --log-level - logging level for stderr (by default, DEBUG); --log-format - logging message format for stderr; --log-file-name - enable logging to a given file; --log-file-level - logging level for file (by default, DEBUG); --log-file-format - logging message format for file; which are defined in a new class called ApplicationBase, so all existing applications should inherit them now. Change-Id: Ic3b0440cd73946ad444bd7e48feb7a92d45f6488 --- src/target/trx_toolkit/fake_trx.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src/target/trx_toolkit/fake_trx.py') diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 1c991cee..a45ce203 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -31,6 +31,7 @@ import argparse import select import sys +from app_common import ApplicationBase from ctrl_if_bts import CTRLInterfaceBTS from ctrl_if_bb import CTRLInterfaceBB from burst_fwd import BurstForwarder @@ -39,7 +40,7 @@ from fake_pm import FakePM from udp_link import UDPLink from clck_gen import CLCKGen -class Application: +class Application(ApplicationBase): def __init__(self): print_copyright(CR_HOLDERS) self.argv = self.parse_argv() @@ -48,8 +49,7 @@ class Application: signal.signal(signal.SIGINT, self.sig_handler) # Configure logging - log.basicConfig(level = log.DEBUG, - format = "[%(levelname)s] %(filename)s:%(lineno)d %(message)s") + self.app_init_logging(self.argv) def run(self): # Init TRX CTRL interface for BTS @@ -131,6 +131,9 @@ class Application: parser = argparse.ArgumentParser(prog = "fake_trx", description = "Virtual Um-interface (fake transceiver)") + # Register common logging options + self.app_reg_logging_options(parser) + trx_group = parser.add_argument_group("TRX interface") trx_group.add_argument("-b", "--trx-bind-addr", dest = "trx_bind_addr", type = str, default = "0.0.0.0", -- cgit v1.2.3