summaryrefslogtreecommitdiffstats
path: root/src/target/trx_toolkit/ctrl_if.py
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2018-12-07 05:00:26 +0700
committerVadim Yanitskiy <axilirator@gmail.com>2018-12-07 05:36:20 +0700
commit6bab6acee634fcd05a175428e1077ab00188829a (patch)
treec2cc2f8231efd29991f71b027323dbd5c10f7906 /src/target/trx_toolkit/ctrl_if.py
parent72c8296bfe22eab749f9f29fe91f30d2588ded9c (diff)
trx_toolkit: use generic logging module instead of print()
There are multiple advantages of using Python's logging module: - advanced message formatting (file name, line number, etc.), - multiple logging targets (e.g. stderr, file, socket), - logging levels (e.g. DEBUG, INFO, ERROR), - the pythonic way ;) so, let's replace multiple print() calls by logging calls, add use the following logging message format by default: [%(levelname)s] %(filename)s:%(lineno)d %(message)s Examples: [INFO] ctrl_if_bts.py:57 Starting transceiver... [DEBUG] clck_gen.py:87 IND CLOCK 26826 [DEBUG] ctrl_if_bts.py:71 Recv POWEROFF cmd [INFO] ctrl_if_bts.py:73 Stopping transceiver... [INFO] fake_trx.py:127 Shutting down... Please note that there is no way to filter messages by logging level yet. This is to be introduced soon, together with argparse. Change-Id: I7fcafabafe8323b58990997a47afdd48b6d1f357
Diffstat (limited to 'src/target/trx_toolkit/ctrl_if.py')
-rw-r--r--src/target/trx_toolkit/ctrl_if.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/target/trx_toolkit/ctrl_if.py b/src/target/trx_toolkit/ctrl_if.py
index 1e569a60..b533746b 100644
--- a/src/target/trx_toolkit/ctrl_if.py
+++ b/src/target/trx_toolkit/ctrl_if.py
@@ -22,12 +22,14 @@
# with this program; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+import logging as log
+
from udp_link import UDPLink
class CTRLInterface(UDPLink):
def handle_rx(self, data, remote):
if not self.verify_req(data):
- print("[!] Wrong data on CTRL interface")
+ log.error("Wrong data on CTRL interface")
return
# Attempt to parse a command