From 8a4d0e09b1fff7af60455f25ba3e0d2589692c40 Mon Sep 17 00:00:00 2001 From: Philipp Maier Date: Thu, 21 Sep 2023 15:36:00 +0200 Subject: GPRS_Components: confirm only when requested We currently send a confirmation back when the SAPI was PCH. This is no longer correct. We now have to check if the receiving end has actually requested a confirmation. Related: OS#5927 Change-Id: I339dfd0c057d957d2ace24fd6821e54c25fe8eb2 --- pcu/GPRS_Components.ttcn | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index aaec6d31..849a251d 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -1070,8 +1070,10 @@ runs on MS_BTS_IFACE_CT { t_imm_ass)) -> value data_msg { rr_imm_ass := data_msg.rr_msg; log("Rx Immediate Assignment: ", rr_imm_ass); - /* Send DATA.cnf back to the IUT (only needed for PCH) */ - f_pcuif_tx_data_cnf(data_msg); + /* Send DATA.cnf back to the IUT */ + if (ispresent(data_msg.confirm) and data_msg.confirm) { + f_pcuif_tx_data_cnf(data_msg); + } setverdict(pass); } } @@ -1187,8 +1189,10 @@ runs on MS_BTS_IFACE_CT return GsmRrMessage { f_shutdown(__BFILE__, __LINE__); } - /* Send DATA.cnf back to the IUT (only needed for PCH) */ - f_pcuif_tx_data_cnf(data_msg); + /* Send DATA.cnf back to the IUT */ + if (ispresent(data_msg.confirm) and data_msg.confirm) { + f_pcuif_tx_data_cnf(data_msg); + } return rr_pag_req1; } -- cgit v1.2.3