aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2022-04-07bsc: add TC_emerg_call_and_lcs_loc_reqNeels Hofmeyr2-0/+104
An emergency call often comes with a Location Request. Make sure osmo-bsc handles it well. Related: SYS#5916 Change-Id: I95037374c45943cb14401bc48f16a39c2fcbe1f5
2022-04-07bsc: as_Media_mgw: fail on DLCXNeels Hofmeyr2-5/+16
as_Media_mgw() is used to establish a voice stream. If a DLCX happens as part of that, that should be flagged as a problem. In fact the Mode Modify test with current osmo-bsc does exhibit a DLCX right upon the Assignment Complete message, which is a bug fixed in I5ab10ee7fd9c5d7608e8a06893881d990943feed. This patch now correctly flags this as a failure. In the two tests TC_ho_in_fail_no_detect, TC_ho_in_fail_no_detect2 the expected failure causes expected DLCX, so exempt those. Related: SYS#5916 Change-Id: I0633f60f09d58802f6be0238ef41a632d93a4327
2022-04-06Diameter_Templates.ttcn: Avoid sending AuthAppId Relay in CEAPau Espin Pedrol1-2/+0
We don't really act as rely agents in the emulation, so let's not announce it. Furthermore, this aids libfreediameter selecting proper routes, since it seems to only underscore peers not matching the AppId if they are not rely agents (see dont_send_if_no_common_app() in freeDiameter.git) Change-Id: I0a9daf094f4c27c0b4de5581ddd56feced8e5732
2022-04-05BTS_Tests: add altstep as_dl_sacch_lapdm_abVadim Yanitskiy1-0/+21
Change-Id: I3ba17683892e8aa1694bb6dd32d8b37660020026
2022-04-05pcu: Introduce test TC_dl_llc_sapi_priorityPau Espin Pedrol1-0/+99
Related: OS#5508 Related: SYS#5908 Change-Id: I26308a59718a6470853c964583a39986006e59c0
2022-04-05RLCMAC_EncDec: Fix bug decoding LI[0]=0Pau Espin Pedrol1-0/+9
Change-Id: I86c1b48c922f50013257c8dce405cbad1d77d868
2022-04-02fix sgsn and hnbgw test issue introduced in ↵Eric Wild2-0/+3
49888a65dcf1f8d94411aa0724530b8c188c3237 ranops was not isvalue because bssap_reset_retries was not set and not explicitly omitted either, so the ran adapter decided not to create a ran emulation... Change-Id: Ib2d3f1fbcfbd53af1e627bd2cf36c3153fa7d012
2022-04-02fix bsc test issue introduced in 49888a65dcf1f8d94411aa0724530b8c188c3237Eric Wild1-0/+1
ranops was not isvalue because bssap_reset_retries was not set and not explicitly omitted either, so the ran adapter decided not to create a ran emulation... Change-Id: Ibbef035929ec861fec1e8554460e22650b386f83
2022-03-31ran emulation: allow multiple reset attemptsEric Wild5-11/+25
bsc-nat introduces a delay that will lead to failed tests, since the reset attempt happens too early and times out, and the tests do not retry. Change-Id: I9f6db2a24e984eef31e76f9d42a80eb6a1bb6928
2022-03-30BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_numVadim Yanitskiy1-0/+56
Change-Id: I169c482ea5de040df63db4c605ac9cae19f8d28f Related: SYS#5905
2022-03-28bsc: Add tests for CBSP MESSAGE STATUS QUERY procedureHarald Welte2-0/+149
Change-Id: I124a69c515d634bc054ed35e430af6b3c11ad46e Related: SYS#5909
2022-03-28CBSP_Types: Fix typo num_bcats_compl -> num_bcast_complHarald Welte1-5/+5
Change-Id: Ic51b3071ea9233a053cb1ee837b910d9250010d2
2022-03-23library/BSSMAP_Templates: add missing LCS {Priority,QoS} IEsVadim Yanitskiy1-3/+32
According to 3GPP TS 48.008, section 3.2.1.71, the LCS QoS IE shall be present if location of the target MS is requested and is optional otherwise. Since [1], osmo-bsc started to check presence of this IE, so let's add it to ts_BSSMAP_Perform_Location_Request. Taking a chance, let's also add LCS Priority IE. Change-Id: If2bd6e636d3ee695abab9ed40417dc53ec68fd12 Related: [1] osmo-bsc.git Ifeb359b0468845da0b4fed9e2e4b79256067fa81 Related: SYS#5891
2022-03-23library/BSSMAP_Templates: add missing LCS Client Type IEVadim Yanitskiy1-4/+14
According to 3GPP TS 48.008, section 3.2.1.71, the LCS Client Type IE shall be present if the location type indicates a request for a location estimate and is optional otherwise. Since [1], osmo-bsc started to check presence of this IE, so let's make sure that it's present in ts_BSSMAP_Perform_Location_Request by default. Change-Id: I5c8d6962e957d587dc4b65d08bf56bd4ef2f0d6e Related: [1] osmo-bsc.git Id3262e67c3dc25cb93fbd52a40689c5529ca2d41 Related: SYS#5891
2022-03-23library/BSSAP_LE_Types: fix wrong IEI in record BSSMAP_LE_IE_LcsClientTypeVadim Yanitskiy1-1/+1
Change-Id: Ifae1efa1717a5dbc7ecd4b5ba83e3866ff803390 Related: SYS#5891
2022-03-22BSC_Tests: avoid code duplication in f_expect_chan_rel()Vadim Yanitskiy1-20/+1
Using a guard statement makes no sense given that we match the cellSelectionIndicatorValue conditionally within the alt branch itself. Removing that guard statement eliminates the need to have an additional alt branch with identical body. Change-Id: I373376637a083637ce01f3ac59fe5fd2836ac6cd
2022-03-22BSC_Tests: add '(present)' restriction to 'expect_rr_cause'Vadim Yanitskiy1-25/+22
RR Cause is a mandatory IE, so it cannot be omitted. Therefore it makes no sense to check if istemplatekind(expect_rr_cause, "omit"). Change-Id: I564d00a4715b86d248bce449d2b9193ac5e99008
2022-03-22bsc: fix some inadequate template restriction warningsVadim Yanitskiy2-8/+8
Change-Id: Icfc69aff2c923f4e12dbd6cc42c792d5712a7b27
2022-03-22gen_links.sh.inc: Fix globbing writing '*.ttcn' to */.gitignorePau Espin Pedrol1-0/+2
This was the case under ggsn_tests, which in turn prevents search text tools like "ag" to find stuff in .ttcn files (because it skips code in .gitignore). Change-Id: Iaef3cfd5ae29db352046664ab4949b037ca80307
2022-03-16library/BSSLAP_Types: fix receive template used in ts_BSSLAP_ResetVadim Yanitskiy1-1/+1
Change-Id: I6ed967c18346263b05b624b0bb5698f23ee842f7
2022-03-16bsc: add new testcase TC_srvcc_eutran_to_geran_a5_3Vadim Yanitskiy2-0/+36
According to 3GPP TS 44.018, section 9.1.15, the RR Handover Command message may optionally contain the Cipher Mode Setting IE (10.5.2.9). Section 9.1.15.10 states that this IE may be omitted in case of the intra-RAT GERAN-to-GERAN handover, however in case of the inter-RAT handover (e.g. EUTRAN-to-GERAN), this IE *shall* always be included. In f_ho_into_this_bsc(), check presence and correctness of the Cipher Mode Setting IE. Add TC_srvcc_eutran_to_geran_a5_3, which is similar to TC_srvcc_eutran_to_geran, but enables ciphering on the target channel. This patch makes all SRVCC relates test cases fail, until [1] is merged. Change-Id: Ic3dfc4e31a7ed078cdfdaced9986ee9551c5aa7c Related: [1] osmo-bsc.git I1d270e82d0a9b12897fc94dae4e8999aa132a22f Related: SYS#5838
2022-03-16bsc: add f_cipher_mode_bssmap_to_rr()Vadim Yanitskiy1-0/+20
Change-Id: I6cc8cbed96f2838af1b0e41c5dfa6760c45d9ad1 Related: SYS#5838
2022-03-16bsc: use select() statement in f_cipher_mode_bssmap_to_rsl()Vadim Yanitskiy1-32/+11
Change-Id: I6e1c6762d2dd1efac2bd7ead3caf25e25dd3e7ad Related: SYS#5838
2022-03-14BTS_Tests: fix some compilation warnings (template restrictions)Vadim Yanitskiy1-9/+7
Change-Id: I53286a7b4b78a3e816d94d880ae290771cdd7ee8
2022-03-14lib/DIAMETER: Allow sending CEA with AuthAppIdPau Espin Pedrol5-6/+47
The new message is to be used by Gy interface emulation, which according to RFC4006 uses AppId 4 "Credit Control Application". The application is apparently not 3GPP vendor specific. Change-Id: I0e33673d65140aad34d2efcae3c7f49154ceb99f
2022-03-14BTS_Tests: add new test case TC_ho_physical_infoVadim Yanitskiy2-0/+98
The test case scenario can be summarized as follows: 1. Activate a logical channel for async handover. 1.a. Tune the MS side to that channel. 1.b. Make sure that no Downlink DCCH is received. 2. Send a handover Access Burst to the BTS. 2.a. Expect RR Physical Information to be received Ny1 times. 2.b. Expect no other data to be received on Downlink DCCH. Currently the new test case fails for several reasons: * osmo-bts-trx starts transmitting on DCCH before the handover Access Burst is received, this is wong; * trxcon immediately starts sending dummy frames on Uplink DCCH, causing osmo-bts to stop sendig RR Physical Info. Change-Id: I9469027ce88fb2750f1eceef2d8a56d4b8ee4d03 Related: SYS#5838
2022-03-14BTS_Tests: add a hierarchy of L1CTL/LAPDm/DCCH altstepsVadim Yanitskiy1-0/+56
In TTCN-3 it's possible to call one altstep from another. This allows us to build complex hierarchies of simple altsteps, where one is built on top of the others. I call this altstep-oriented programming. This change adds the following hierarchy: * as_l1ctl_dl_msg() - triggers on receipt of a L1CTL DATA.ind matching the given RSL chan_nr/link_id and data templates; * as_dl_lapdm_dummy() - triggers on receipt of dummy LAPDm func=UI frames with empty payload (repeats by default); * as_dl_dcch_lapdm_ab() - triggers on receipt of a Downlink DCCH containing a L2 payload that matches the given LAPDm frame; * as_dl_dcch_pdu() - triggers on receipt of a LAPDm AB frame with a L3 payload matching the given template. All of these altsteps (except as_dl_lapdm_dummy()) expect an 'out' parameter, which will hold the matched (and possibly decoded) data. Example: var PDU_ML3_NW_MS pdu; alt { [] as_dl_lapdm_dummy(); /* Ignore empty LAPDm func=UI frames */ [] as_dl_dcch_pdu(pdu, tr_CM_SERV_ACC) { setverdict(pass); } [] as_dl_dcch_pdu(pdu, tr_CM_SERV_REJ) { setverdict(fail); } [] as_dl_dcch_pdu(pdu, ?) { setverdict(inconc, "Unexpected PDU"); } } Change-Id: Ia4d502488cbb6bccc4d2656206ae6649bfa71007 Related: SYS#5838
2022-03-14bts/expected-results.xml: expect TC_sacch_chan_act_ho_async to passVadim Yanitskiy1-6/+1
Change-Id: I9ceb0a71549d293ff0f270c414f667a0bae4df62
2022-03-14BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[]Vadim Yanitskiy1-6/+6
Currently we execute both test cases on *all* available dedicated channels from g_AllChannels[]. Given that SACCH is slow, and in some cases we intentionally wait for a timeout of 3.0 seconds to expire, the overall execution time is quite long. We have a risk of the test execution being aborted due to the guard timeout. I agree that using g_AllChannels[] makes sense for TC_ho_rach, which tests handover RACH detection. There we want to be sure that detection works on all slots of all DCCH types (especially when running a setup with real MS/BTS hardware). But for both TC_sacch_chan_act_ho_{sync,async} it's enough to run on different channel types (see g_AllChanTypes[]), because what we actually want to test is the Downlink SACCH operation. Change-Id: Ic1937edd72ff842cb619e153d0f6a624ceb95281 Related: SYS#5838, OS#4008, OS#4009
2022-03-14BTS_Tests: fix expectations in TC_sacch_chan_act_ho_{sync,async}Vadim Yanitskiy1-6/+13
According to 3GPP TS 48.058: * 4.1.3 async handover: "If the MS Power IE is present the BTS *may* start transmission also on the SACCH". * 4.1.4 sync handover: "If only the MS Power IE is present the BTS *may* start transmission also on the SACCH". "May" does not mean "shall", so osmo-bts does not. Change-Id: I5e97944e56b7860f2d912cd8d3c978a0f1e08645 Related: SYS#5838, OS#4008, OS#4009
2022-03-13library/L1CTL_Types: fix t_RslChanNr_RACH used in send templatesVadim Yanitskiy1-2/+2
Change-Id: Id7570df09bea04c60475d91519c6aac63bf6f749
2022-03-13BTS_Tests: remove completed TODO pointsVadim Yanitskiy1-2/+0
* TC_ho_rach - handover RACH detection, * TC_rsl_rf_resource_ind - RF RESource INDication. Change-Id: I12b6331b445650437cc66130765369bbcd01ba5f
2022-03-13library/L3_Templates: add templates for RR Physical InformationVadim Yanitskiy1-0/+31
Change-Id: Icc0f9d0987e77a714e9eaffaedd851a982063582 Related: SYS#5838
2022-03-13library/LAPDm_Types: add 'padding' field to the LapdmFrameAB recordVadim Yanitskiy2-18/+36
TTCN-3 offers a very convinient way of matching an octetstring against a record template (decoding target) on the fly, so that there is no need to attempt decoding it manually beforehand. This can be done by using the 'decmatch' keyword (see B.1.2.9). Unfortunately, decmatch fails if an octetstring is longer than the encoded variant of the decoding target (e.g. has padding). Let's work this around by adding a 'padding' field, so during decoding all remaining octets will be stored in it. Change-Id: I0151adf7790127617f7cb57c9a9ec6c28721e95a Related: SYS#5838
2022-03-11BTS_Tests: cosmetic: use setverdict() in f_sacch_{present,missing}()Vadim Yanitskiy1-2/+4
This eliminates the need for using log2str() and improves readability. Change-Id: Iaf9b03fb81ec4fa2ca4f0a0b2f0b50491c6a9d80 Related: SYS#5838, OS#4008, OS#4009
2022-03-11BTS_Tests: remove misleading comments in f_sacch_{present,missing}()Vadim Yanitskiy1-2/+0
Change-Id: Ib6264da51d17d8d5d932109afad79d6a9916911b Related: SYS#5838, OS#4008, OS#4009
2022-03-10sgsn: add TC_iu_attach_encr with UEA > 0Neels Hofmeyr2-8/+57
Test new osmo-sgsn Iu attach with UEA (encryption) enabled Related: SYS#5516 Depends: I27e8e0078c45426bf227bb44aac82a4875d18d0f (osmo-sgsn) Change-Id: I1a7c3b156830058c43f15f55883ea301d2d01d5f
2022-03-10BSC_Tests: also match band indicator in SI6 Rest OctetsVadim Yanitskiy1-1/+8
Due to a bug in the current osmo-bsc master, osmo-bsc inverts the band indicator bit in SI6 Rest Octets. This change extends testing coverage to demonstrate the problem (see TC_si_default). Change-Id: I93e1fcfaea973ec2461e30f656d5f5f0d829909b Related: osmo-bsc.git Iaa8377919a144e7f3799b76249f579c8f3874145
2022-03-10library/GSM_RestOctets: add partial definition of SI 6 Rest OctetsVadim Yanitskiy2-1/+55
Change-Id: I5aeed4986820a71f761f21b57c87782d3000293f
2022-03-09ggsn: Rename diameter generic ports to GxPau Espin Pedrol1-19/+19
We'll start emulating other Diameter-based interfaces soon (Gy), so let's rename existing stuff which is Gx specific. The DIAMETER_Emulation only supports handling 1 application-id per component, and that's fine anyway since the OCS is in general expected to run in a different conn/node from PCRF. Change-Id: I1eb03d907b46c4bb24491f390ef468e831190e08
2022-03-09ggsn_tests: Wait for retrans queues to drain after each testPau Espin Pedrol1-3/+50
Otherwise a new test may reuse the same GTP seqnum, and if it's still in the gtp retransmit resp queue of the GGSN, it may be identified as a duplicate retransmittion of a previous message (previous test) and send back the previous response instead of processing the request. Related: OS#5485 Change-Id: I1b04691987b883f63c95c0322a477db4a43df2b1
2022-03-07bsc: add missing codec list in AoIP Handover RequestNeels Hofmeyr2-3/+9
So far, osmo-bsc ignored the Codec List (MSC Preferred) in inter-BSC incoming HO Request messages. Starting with osmo-bsc I117cc29d6d11db77d160de654f43f5993db6ee21, a missing codec list on AoIP causes incoming inter-BSC HO to fail, as it should (3GPP TS 48.008 indicates that a codec list shall be included on AoIP). To avoid test fallout when merging above osmo-bsc patch, add a codec list to HO Request on AoIP. Related: OS#5839 Change-Id: If06de9c9b43d79f749447a4e2a340176eef75c79
2022-03-03bsc: inter-BSC incoming HO in with empty SCCP CRNeels Hofmeyr3-10/+29
Test inter-BSC incoming HO where the Handover Request message is not included in the initial SCCP N-Connect, but follows in a separate DT1. Related: SYS#5864 Depends: I535c791fa01e99a2226392eb05f676ba6c3cc16e (osmo-bsc) Change-Id: I6732153cdd0d529bfaf0925387e765f3403a756b
2022-03-03bsc: add TC_ho_into_this_bsc_a5_mismatchNeels Hofmeyr2-11/+58
Since I just fixed the encryption behavior, I also want to know whether the case of no A5 intersection is handled properly. The tiny test comes with a lot of changes to allow a handover failure code path. The 'expect_ho_fail' flag goes via function arguments to g_pars and the general ho test code uses it to branch for exp-failure. Related: SYS#5839 Change-Id: I44b464a0bedbff09c467c4bccd7c985480fb883a
2022-03-03bsc: inter-BSC HO in: expect codecs in HO Request ACKNeels Hofmeyr1-0/+26
Expect IEs Speech Codec (Chosen) and Codec List (BSS Supported), they are missing in current osmo-bsc. Related: SYS#5839 Depends: I3c0576505a3ceb3cd5cc31dc69c5bc4a86a4ea08 (osmo-bsc) Change-Id: Ib2b4e27be241e2a92c0c3bffdf906bf22c09352b
2022-02-28ggsn: Introduce test TC_addr_pool_exhaustionPau Espin Pedrol1-0/+103
Related: OS#5469 Related: https://github.com/open5gs/open5gs/pull/1397 Change-Id: Iee24384b35f9277475b02cb59bf04cd6c9f23b1c
2022-02-28ggsn: Introduce test TC_lots_of_concurrent_pdp_ctxPau Espin Pedrol1-0/+115
Change-Id: Iab19963f8e869af8fe0c385abd0fd7bbd9221790
2022-02-25simtrace: Add support for slot_mux_nr to CardEmu_BD_ConfigHarald Welte2-3/+6
This catches up with a recent change in simtrace2.git (Change-Id I4cdb250d2e1dbc5b8b0169f8b7c21e288b492e1d) adding a new optional field to CardEmu_BD_Config Change-Id: Id29584764a2f27b9de5fa9ff67fd0ae3e912f02e
2022-02-25ccid: Lots of CCID helpers have been moved to titan.TestPorts.USBHarald Welte2-140/+1
Change-Id: Ie110ad1511b01fe84e1ad181b0e053e25f80f522
2022-02-25move SIMTRACE_{Types,Templates,Emulation}.ttcn to libraryHarald Welte4-0/+1
this will allow us to us SIMTRACE as part of a test suite testing e.g. CCID readers. Change-Id: I4349019e2deac114f4c040f1441b70663a521ec2