diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2022-11-29 14:50:39 +0100 |
|---|---|---|
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | 2022-12-02 14:53:31 +0100 |
| commit | 45b98aa0ee0cd0b4d7dfcff6a6a7c26e54a25b33 (patch) | |
| tree | 81566a33d9a404e9b62e6ddaa547fed1d9b1fd36 /pcu | |
| parent | e3e2bf6e78ebb4ef1965259c38f3baa340e4763d (diff) | |
pcu: TC_dl_flow_more_blocks: Fix race condition waiting for first DL data after X2002
Since recently osmo-pcu arms the X2002 in a more fitting place (later,
when paging.cnf is received from osmo-bts over PCUIF).
Since we use same X2002 value in TTCN3 to wait for the timer to trigger,
in the past it was always fine (the X2002 at osmo-pcu always already had
triggered before the one in ttcn3 after receiving the ImmAss).
However, now the timer is roughly set at the same time in both places (ttcn3 and
osmo-pcu) and hence there may be race conditions where we request a
DL data block before the X2002 triggered at osmo-pcu, in which case we
receive a DL dummy block because the TBF is not yet in the FLOW state
Change-Id: I67483bc423567d1fc98eb912ece1cf5cda746119
Diffstat (limited to 'pcu')
| -rw-r--r-- | pcu/PCU_Tests.ttcn | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 38c50be6..936f101a 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -2773,9 +2773,11 @@ testcase TC_dl_flow_more_blocks() runs on RAW_PCU_Test_CT { /* Wait timer X2002 and DL block is available after CCCH IMM ASS */ f_sleep(X2002); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); /* Expect the first (GPRS DL) block with bsn=0 and rrbp_valid=1 */ - f_rx_rlcmac_dl_block_exp_data(dl_block, fn, data, 0); + f_rlcmac_dl_block_exp_data(dl_block, data, 0); f_acknackdesc_ack_block(ms.dl_tbf.acknack_desc, dl_block); /* TDMA frame number on which we are supposed to send the ACK */ |