aboutsummaryrefslogtreecommitdiffstats
path: root/fr/FR_Tests.ttcn
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2022-04-12 22:52:47 +0200
committerHarald Welte <laforge@osmocom.org>2022-04-12 22:52:47 +0200
commit67881aef23a3567aa5cb70364b388041011efbc7 (patch)
tree83ee0e0883efaf19dcc771a1598d9f1e674183b0 /fr/FR_Tests.ttcn
parent12c4aa8bb7e754c935059740238b4e358b950e02 (diff)
Avoid generating zero-length packets
I used the construct like f_rnd_octstring(f_rnd_int(100)) in a number of places to generate random-length packets with randomized length. The problem I didn't realize is that f_rnd_int() of course can also return '0', which would generate zero-length packets. This may be permitted in some protocols, but it leads to problems e.g. when trying to send a UDP packet of zero length (which the kernel will not do). So let's introduce * f_rnd_int_nonzero() for returning non-zero randomized integers * f_rnd_octstring_rnd_len() for returning a random-length random payload octet string * replace all f_rnd_octstring(f_rnd_int()) call sites with the new function. Change-Id: I818a113ff8d2a2f7cab2ec7d9c8661607c6331d6 Closes: OS#5528
Diffstat (limited to 'fr/FR_Tests.ttcn')
-rw-r--r--fr/FR_Tests.ttcn2
1 files changed, 1 insertions, 1 deletions
diff --git a/fr/FR_Tests.ttcn b/fr/FR_Tests.ttcn
index b7a56c3b..65029c1b 100644
--- a/fr/FR_Tests.ttcn
+++ b/fr/FR_Tests.ttcn
@@ -276,7 +276,7 @@ private function f_ul2dl_ud(charstring id) runs on UE_CT
var integer ran_index := 0;
var template (value) PDU_LLC llc_tx;
var template (present) PDU_LLC llc_rx_exp;
- var octetstring llc_payload := f_rnd_octstring(f_rnd_int(max_llc_payload_len));
+ var octetstring llc_payload := f_rnd_octstring_rnd_len(max_llc_payload_len);
var PDU_LLC llc_rx;
timer T := 5.0;