aboutsummaryrefslogtreecommitdiffstats
path: root/bts
diff options
context:
space:
mode:
authorVadim Yanitskiy <axilirator@gmail.com>2019-07-26 16:29:27 +0700
committerlaforge <laforge@gnumonks.org>2019-07-26 09:50:13 +0000
commitde535e03caded25080fbdc5886353a27e8fc4cfd (patch)
tree61ff7d106bdec9450d955f929b641cfae403b5e9 /bts
parent91bfa1c43621966eee0ae4bfa05d08f29c17f2d7 (diff)
BTS_Tests.ttcn: fix: use reasonable minimum default for C/I
Since [1] we additionally filter Access Bursts by the link quality (defined by C/I) in L1SAP, and since [2] we do provide the actual C/I values for osmo-bts-trx, as was received from the transceiver. [1] https://gerrit.osmocom.org/r/I893ec9c6c2ebad71ea68b2dc5f9f5094dfc43b78 [2] https://gerrit.osmocom.org/r/I8d86dec7ebc039cbfd038c4342ff328b11281865 The default minimum C/I for Access Bursts in OsmoBTS is 50 cB, while the TTCN-3 test cases configure fake_trx.py to send 0 cB, so all Access Bursts are getting dropped, as expected. Let's use 60 cB (or 6 dB) by default. This change makes Access Bursts pass again, and thus fixes some broken test cases. Change-Id: Ic345f7995c2553e346590cd851f8857d26e7beb2
Diffstat (limited to 'bts')
-rw-r--r--bts/BTS_Tests.ttcn4
1 files changed, 2 insertions, 2 deletions
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index ebe74c08..d3fb9589 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -422,8 +422,8 @@ function f_init() runs on test_CT {
/* Start with a default moderate timing offset equalling TA=2, and RSSI=-60 */
ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_TIMING(2*256)));
ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_RSSI(-60)));
- /* FIXME: OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */
- ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(0)));
+ /* OsmoBTS may have different AB / NB threshold (see MIN_QUAL_NORM, MIN_QUAL_RACH) */
+ ret := f_TRXC_transceive(BTS_TRXC, g_bts_trxc_conn_id, valueof(ts_TRXC_FAKE_CI(60)));
}
/* Wait some extra time to make sure the BTS emits a stable carrier.