aboutsummaryrefslogtreecommitdiffstats
path: root/bsc
diff options
context:
space:
mode:
authorOliver Smith <osmith@sysmocom.de>2023-02-21 12:44:12 +0100
committerOliver Smith <osmith@sysmocom.de>2023-02-22 11:14:03 +0100
commita1cbec52f080d85368db5f75eb1294687d2dcc41 (patch)
treeedb70d75414257b98a62d93fa0212fb36fd8ee17 /bsc
parent4eed06f3f2568f0263f7555c21b42dfb8ca4456d (diff)
bsc: TC_ho_in_fail_mgw_mdcx_timeout: fixup
Fix that the test was torn down too early, before DLCX messages were received from OsmoBSC. This caused a race condition that sometimes failed the test with: VirtMGW-MGCP-0(1996)@e5a096d6b4ff: Dynamic test case error: Sending data on the connection of port MGCP_CLIENT to 1999:MGCP failed. (Broken pipe) Related: OS#5787 Fixes: 7a8594a8 ("bsc: TC_ho_in_fail_mgw_mdcx_timeout: new test") Change-Id: If47fa3e0204ce841c79a67dd78a1c53d04e4a586
Diffstat (limited to 'bsc')
-rw-r--r--bsc/BSC_Tests.ttcn9
1 files changed, 9 insertions, 0 deletions
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 9a2718a2..b9182e3c 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -6347,6 +6347,15 @@ private function f_ho_into_this_bsc(charstring id, template (omit) BSSMAP_oldToN
if (g_pars.expect_ho_fail_lchan_est) {
BSSAP.receive(tr_BSSMAP_HandoverFailure);
setverdict(pass);
+
+ /* When we let MGCP MDCX run into a timeout, it's still in the
+ * queue and additionally after BSSAP HandoverFailure, two DLCX
+ * get sent. */
+ if (g_pars.ignore_mgw_mdcx) {
+ MGCP.receive(tr_MDCX);
+ MGCP.receive(tr_DLCX);
+ MGCP.receive(tr_DLCX);
+ }
return;
}