aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHarald Welte <laforge@osmocom.org>2024-04-04 01:36:56 +0200
committerlaforge <laforge@osmocom.org>2024-04-13 16:26:05 +0000
commit1818834e6fb0a876ab763487d75044f8e92d26c7 (patch)
treee3cc7ca57c29f643457869495c8e617601d79cf1
parent0d4a843fd3b5fd2bba288117cf2ae2bceab7ff0d (diff)
hnbgw: Use "NAS/Normal" as default release cause
We shouldn't run all of our tests with a rather exotic release cause value (O&M intervention) but assume a normal/orderly NAS triggered release, unless a specific test case explicitly tests an abnormal release cause. Change-Id: I8ddd1dccc5637431e3a8c6e607e0e45faa82b5b5
-rw-r--r--hnbgw/HNBGW_Tests.ttcn4
-rw-r--r--library/ranap/RANAP_Templates.ttcn2
2 files changed, 4 insertions, 2 deletions
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index 518dee95..808db75a 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -1054,7 +1054,7 @@ private function f_cn_idx(boolean ps_domain, integer cn_nr := 0) return integer
private template (value) TestHdlrParams
t_pars(integer imsi_suffix, boolean ps_domain := false, integer hnb_idx := 0,
boolean expect_separate_sccp_cr := false, integer tx_sccp_cr_data_len := 0,
- integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_om_intervention) := {
+ integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) := {
hnb_idx := hnb_idx,
cn_idx := f_cn_idx(ps_domain, cn_nr),
imsi := f_gen_imsi(imsi_suffix),
@@ -1477,7 +1477,7 @@ testcase TC_rab_assign_fail() runs on test_CT {
g_num_hnbs := 1;
f_init();
- vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4));
+ vc_conn := f_start_handler_with_pars(refers(f_tc_rab_assign_fail), t_pars(4, rab_rel_cause := ts_RanapCause_radio_conn_lost));
vc_conn.done;
f_shutdown_helper();
diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn
index 018cb816..8e6c8f37 100644
--- a/library/ranap/RANAP_Templates.ttcn
+++ b/library/ranap/RANAP_Templates.ttcn
@@ -12,6 +12,8 @@ import from RANAP_PDU_Contents all;
import from RANAP_PDU_Descriptions all;
template (value) Cause ts_RanapCause_om_intervention := { misc := 113 };
+template (value) Cause ts_RanapCause_nas_normal := { nAS := 83 };
+template (value) Cause ts_RanapCause_radio_conn_lost := { radioNetwork := 46 };
/*****************************************************************************************************
* Reset