diff options
| author | Vadim Yanitskiy <vyanitskiy@sysmocom.de> | 2022-03-11 15:32:07 +0300 |
|---|---|---|
| committer | fixeria <vyanitskiy@sysmocom.de> | 2022-03-14 10:40:16 +0000 |
| commit | ce96d3547fc26e6646046339e5d58db340850010 (patch) | |
| tree | 26df7e635979f66a90aaf376d8c1ffe397e83b42 | |
| parent | f9136a1ec3daba6406e4b206f2c0059619a149b2 (diff) | |
BTS_Tests: exec TC_sacch_chan_act_ho_{sync,async} on g_AllChanTypes[]
Currently we execute both test cases on *all* available dedicated
channels from g_AllChannels[]. Given that SACCH is slow, and in
some cases we intentionally wait for a timeout of 3.0 seconds to
expire, the overall execution time is quite long. We have a risk
of the test execution being aborted due to the guard timeout.
I agree that using g_AllChannels[] makes sense for TC_ho_rach, which
tests handover RACH detection. There we want to be sure that detection
works on all slots of all DCCH types (especially when running a setup
with real MS/BTS hardware).
But for both TC_sacch_chan_act_ho_{sync,async} it's enough to run
on different channel types (see g_AllChanTypes[]), because what
we actually want to test is the Downlink SACCH operation.
Change-Id: Ic1937edd72ff842cb619e153d0f6a624ceb95281
Related: SYS#5838, OS#4008, OS#4009
| -rw-r--r-- | bts/BTS_Tests.ttcn | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index ab7c979c..b95648a7 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -1406,9 +1406,9 @@ testcase TC_sacch_chan_act_ho_async() runs on test_CT { var ConnHdlrPars pars; f_init(); - for (var integer i := 0; i < sizeof(g_AllChannels); i := i+1) { - pars := valueof(t_Pars(g_AllChannels[i], ts_RSL_ChanMode_SIGN)); - log(testcasename(), ": Starting for ", g_AllChannels[i]); + for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i+1) { + pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN)); + log(testcasename(), ": Starting for ", g_AllChanTypes[i]); vc_conn := f_start_handler(refers(f_TC_sacch_chan_act_ho_async), pars); vc_conn.done; } @@ -1532,9 +1532,9 @@ testcase TC_sacch_chan_act_ho_sync() runs on test_CT { var ConnHdlrPars pars; f_init(); - for (var integer i := 0; i < sizeof(g_AllChannels); i := i+1) { - pars := valueof(t_Pars(g_AllChannels[i], ts_RSL_ChanMode_SIGN)); - log(testcasename(), ": Starting for ", g_AllChannels[i]); + for (var integer i := 0; i < sizeof(g_AllChanTypes); i := i+1) { + pars := valueof(t_Pars(g_AllChanTypes[i], ts_RSL_ChanMode_SIGN)); + log(testcasename(), ": Starting for ", g_AllChanTypes[i]); vc_conn := f_start_handler(refers(f_TC_sacch_chan_act_ho_sync), pars); vc_conn.done; } |