aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>2022-02-09 18:28:18 +0600
committerVadim Yanitskiy <vyanitskiy@sysmocom.de>2022-02-09 18:28:23 +0600
commitd344b4af03717445526be3aac68c12de9cbcdee5 (patch)
tree0281ff5fa943a5718bf0e35cdbb89ca24b18b90a
parent52b2b26c52bcb238bfc73558deabbf38cf0f1397 (diff)
GGSN_Tests: fix DTE due to passing out-of-bound values to int2oct()
This patch fixes the following DTE happening sporadically: 04:09:29.373271 mtc GGSN_Tests.ttcn:1478 Dynamic test case error: The first argument of function int2oct(), which is 256, does not fit in 1 octet. Change-Id: I517b8e5d5872c36f7c759433a1cde338c90f16da
-rw-r--r--ggsn_tests/GGSN_Tests.ttcn4
1 files changed, 2 insertions, 2 deletions
diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 3b34c7f0..ae24eeba 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -1475,7 +1475,7 @@ module GGSN_Tests {
var PdpContext ctxB := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn)));
f_pdp_ctx_act(ctxA);
- g_restart_ctr := int2oct(oct2int(g_restart_ctr) + 1, 1);
+ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1);
log("sending 2nd CreatePDP (recovery increased)");
f_send_gtpc(ts_GTPC_CreatePDP(g_peer_c, g_c_seq_nr, ctxB.imsi, g_restart_ctr,
@@ -1564,7 +1564,7 @@ module GGSN_Tests {
/* Wait to receive second echo request and send incremented Restart
counter. This will fake a restarted SGSN, and pdp ctx allocated
should be released by GGSN */
- g_restart_ctr := int2oct(oct2int(g_restart_ctr) + 1, 1);
+ g_restart_ctr := int2oct((oct2int(g_restart_ctr) + 1) mod 256, 1);
GTPC.receive(tr_GTPC_PING(?)) -> value ud {
var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber);
GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr));