Age | Commit message (Collapse) | Author | Files | Lines |
|
Only the radioDevice->getRxGain() is called from inside
radioInterfaceMulti, so the API in radioInterface is not used at all.
Change-Id: Icc4e9a7ebfdafe7c72c535752a5e379d12592c9a
|
|
Change-Id: I11e853e11bec99fc88e81642f9b2cd87d5815398
|
|
Change-Id: I0d8fd51586ef01141d4e5896f0fc3029a22743f8
|
|
field rxGain is set to 0 during constructor and never set after that
point.
Change-Id: I7fae7a315e5ab98a15c27628a88a92226ef89469
|
|
It's not a pointer check or a boolean expression, in here we really
check chan index is 0, so it's more clear doing so this way like it's
done in all other places.
Change-Id: I83b14487d14ba8272f58796f640f58a88891e532
|
|
Previous naming is ready confusing, because "Radio" is actually the
common term between radioInterface and radioDevice, and it looks like
it's referring to radioInterface rather than radioDevice. On the other
hand, mDevice cleary states it refers to the radioDevice item.
Change-Id: I708bb1992a156fb63334f5590f2c6648ca27495e
|
|
BTS may have any timeslot disabled, or may have not yet sent initial
SETSLOT cmd to properly configure the timeslot.
Change-Id: Icf62e5d1200c7a440f255bb46023cdbf61532b7f
|
|
Change-Id: Ia0f2b5a51040663d7e8219e6ed51e0513b876548
|
|
Change-Id: I4f180cc852582b131ba28a8139215335f7ba567d
|
|
Change-Id: Iec33ab73a9bf90fd0bff9ba453c32ea11bf0670e
|
|
Since tn is declared as uint8_t, it's actually a char, and by default
c++'s ostream& operator<<(ostream&, unsigned char) tries to print chars
with its ASCII visible character instead of numeric value.
Change-Id: I534158e8e1719ad19a9cde7c747a8f8ad5a01a2b
|
|
Change-Id: I3099498e3a3f26b53d55a96a36cc056f7b25b27a
|
|
Related: OS#3343
Change-Id: Icd328e85b0a75ef67f371a7ed72638053b1854f9
|
|
Related: OS#3664
Change-Id: Id16248a1c03f9bc9f323c707857cdf3bf34c4e3e
|
|
We don't want to keep osmo-trx running in a started state once the BTS
controlling it becomes unavailable. If a socket towards the BTS fails,
it means the BTS is gone and the best thing to do is to stop the process
(alternatively we could go back to stopped state instead, and wait for
BTS to re-connect, fur so far this action is good enough).
Related: OS#4170
Change-Id: I2ccbe3c17b39fb792ea7810f840235c348054d66
|
|
pullRadioVector() should return true on idle frames because those
indications may be handled by upper layers (TRXDv1). Clarify return code
in function documentation.
Change-Id: If592ed1c04cf7e995f656b313f60edd4d40d1bfd
|
|
Use a packed structure to clearly indicate what is contained in the
received buffer.
Change-Id: I4d8c0e3c0c717699889f79e50c778d14b6058f2d
|
|
No need to continue further since anyway we'll end up exiting.
Change-Id: Id8b38b40df5744beb705d560defb06532cf0fd44
|
|
If osmo-trx is started and IP addr binding fails (ie because the IP
address is not assigned in the system), it will try to access a
heap-allocated Thread instance which was not initialized (because init()
function returned earlier).
Fixes: OS#4147
Change-Id: I19f9745cd026c0ff6581895a66bf91b40113b07d
|
|
This code is not needed anymore since we are setting SCHED_RR scheduler
with a real time priority in main thread during startup, so all threads
will inherit same rt priority, which should be enough to keep the
process working reliably even on high system loads (from non rt
processes).
osmo-trx was tested to be reliable during test with stress-ng as
explained in related ticket below.
Related: OS#2344
Change-Id: I3a88946dd71e9aeeaac9d19d396e2236c302b608
|
|
Since osmo-trx it's a big multithreaded process and shutdown sequence
can be complex, better use stderr to log signal received events to make
sure log is outputted straigh away and not buffered. In general stdout
is usually line-buffered, but buffering strategy can be more
conservative if output is for instance redirected to a file.
Change-Id: I70ba86919d1f7df41ef3db4916317d27697a025c
|
|
Patch release to have debian/patches/build-for-debian8.patch applying
correctly again.
Change-Id: I27caf077abc400e9661549886bb8f7827dd299bb
|
|
Change-Id: Ifd5abfb03015e9233814eb9d843ce2e218987283
|
|
Older commit started using osmo_timerd_* APIs which are only available
starting libosmocore 0.12.0, but configure.ac still states 0.11.0 is
accepted, which is incorrect.
Fixes: 4456b6f132437a95833e3a3d3353836331b9c8a0
Change-Id: I71743b8a10edb10af51ad8e9289c53e432199b97
|
|
Previous commit started using IPPROTO_UDP without including required
include. Newer versions of libosmocore's osmocom/core/socket.h include
that header so the define is present, but older versions of libosmocore
(such as 0.12.0) don't, so let's include it explicitly (the correct
thing to do).
Fixes: b9d2515704ac83cacd88d0a73ecba30323df0b2d
Change-Id: I67ddf550f3a7fc6a650e1e1d9bde0bbb28785104
|
|
Previous content in README file is actually a description of the TRXD
and TRXC protocols, and it has already been moved to the User Manual
some time ago. INSTALLATION contained README related information, but it
was really out of date.
So this commit basically drops those two files and provides a new
README.md with content taken from Osmocom's OsmoTRX project wiki page.
Change-Id: I3df00799ce80aa4af43225e69a408ba2cbc444db
|
|
This file is only used by USRP1, so let's move it there and avoid
processing it in Makefiles if build for USRP1 is not requested at
configure time.
Change-Id: Ibb40ba487581e76d2ae3e8a420d631670f876cf0
|
|
Change-Id: Icccc18688ee54e669cf3452b08747b3509042fa2
|
|
Change-Id: Ib5a56cfe0c27d027bc0c60abda89e646a80849de
|
|
Change-Id: I15b687fbf436d662b264cb00f72b367ccd64b962
|
|
Change-Id: I4d6ef1f54f3d6c5a73ce00dc4640bd698f96842b
|
|
After discussion in [1] and further look at the code, it became obvios
rx_underrun events are not happening in general for any SDR (don't
exist), so let's drop that counter. Instead, add Tx Dropped Packet counters,
which were not accounted prior to this commit.
[1] https://github.com/osmocom/osmo-trx/commit/bde55afd29fc9aae10eb11f6515821afa39b772d
Change-Id: Iff1535c219a4695a511d383d7c4b06ef6eff959d
|
|
When submitting patches to osmo-trx in gerrit, sometimes the jenkins job
fails due to libusrp failing to build. I never have this issue in on my
workstation.
Let's disable parallel make and see if we can avoid it for now.
Related: OS#3970
Change-Id: I24bc54f5872e8edb9fab5b88055a00cebe1a6911
|
|
The pointer can't never be null, so avoid checking it.
Change-Id: I12e14641713a6494bc89570f02cecfc6f8fd4b5e
|
|
The underrun parameter in radioDevice's readSamples() is not a "Rx
Underrun" event, but rather it's used to retrieve a "Tx Underrun" which
on some SDRs (like USRP1) seems to be (so far) available only at
readSamples() times.
Thus, underrun parameter for both readSamples() and writeSamples() is
actually flagging the same event, and should be ORed in pushBuffer() as
it's already done in pullBuffer(). Otherwise if implementation is
setting the underrun pointer to false, it could erase the flag being
marked by the counterpart function before isUnderrun() is called (which
is the one responsible to clear the flag).
Change-Id: Id549489fc1485e0d762818c8e682aaddd5041f1c
|
|
autoreconf is used instead, as done in all of the osmocom projects.
Change-Id: I87676cdf6818b4250f478962baf96ad5f28564d5
|
|
We already have debian/changelog for same purpose. This file is empty
and doesn't exist on other osmocom projects.
Change-Id: I5a90107476ca116bebc8569f4eb1db0fa25807a6
|
|
Change-Id: If9de32eed8170038c8c177c8996c78846dddb624
|
|
TransceiverChannel naming was misleading there. It's simply a data type
used to pass 2 parameters through the void* of the thread entry
function, so let's clearly specify is a storage for thread params.
Furthermore, we don't need a full C++ class for that, let's simply use a
struct.
Change-Id: I6e3898a8a66520cc5b2a7df9b9ae01b0b272387f
|
|
The setting is negotiatied by osmo-bts-trx on each channel, so let's
keep and use state per channel instead of overwriting the state from
different channels.
Take the chance to change related log lines to also print the channel
number.
Change-Id: If9cf95e89d38d0155ab48b8c0977ca5f381c2aad
|
|
Before this commit, osmo-trx was always setting its CTRL socket to
listen on 127.0.0.1.
Change-Id: I61a06c1b9c20a906e7030f824a93370d041be7b9
|
|
Related: OS#3515
Change-Id: I3719bd8dc015569ecd81928fc079e27593cdca09
|
|
Change-Id: Ifafb68353960fc5046661854ccfb8d783b0efb14
|
|
Change-Id: I36b8b8be48ae8676688786f39008d08b61011ede
|
|
Those paths were moved into a subdir a while ago, but this file was not
updated at the time.
Change-Id: I1857338b7a19e2a37f62386ceb4a1fad988272ba
|
|
Change-Id: I5cfbbafd411e580421f86df6817f91261aceda7e
|
|
Change-Id: I7264ef35dbe6d3522858eae5b47d150aa1ffe334
Closes: CID#169594
|
|
Change-Id: Ia72395f8805e9e2cd700ad1e559a8aa62124aaec
Closes: CID#149371
|
|
Change-Id: I8c047c8f98e928a62dca1d7b8c003502727c086e
Closes: CID#149374
|
|
Change-Id: I866505f29ed56d8f3ba3aaba70c0d82479987c64
Closes: CID#149361
|