Age | Commit message (Collapse) | Author | Files | Lines |
|
So far the validation is only done on TxFreq for all TRX. Let's also do
it for RxFreq.
Change-Id: I30eef2727ee96b1344aa1416edd66e2302b88964
|
|
Same check is already done by set_band().
Change-Id: I48d14f35e83fa17d1a8f4154479f0a5cee0f816d
|
|
Logarithm change of base rule is used. Document it so it's clear where
it comes from.
Change-Id: Ia588e8dafda4e1abe0721f12491661949339a1ba
|
|
Remove this workaround, as we are not building for debian 8 anymore.
Related: OS#5223
Depends: osmo-ci Ibe7ba124557969df62798ba49c4489e9606c2341
Change-Id: I5519075a7f95fa61b0b5f1825e4e9324b9eede76
|
|
Change-Id: I33f4253cecab8d92eec75af49e1671874b8cc111
|
|
There's another related logging line also at INFO level in the caller
path in Transceiver.cpp, but it only prints if detectBurst() failed.
Let's print this one as INFO too, which proved to be a good logging
level. This way user also notices gain is too high despite osmo-trx is
still able to decode bursts.
Change-Id: Ieca4f19ae1099a430e9b838f8b6780b1c61a87a9
|
|
Change-Id: Ia157b970db92eef252c3657b35607307b7ebf988
|
|
Change-Id: I9b426d01a282f572c0b915c5666642dce4c60475
|
|
Change-Id: Icba5fce57c858bd16196ae3012c100c7e4134335
|
|
Change-Id: I3d8738b492a175f2ef0c570579e335e7b7695694
|
|
downsampleBurst() and the Resampler below it clearly only support or are
confgiured for 1<->4 setup currently.
Change-Id: Iebaff7a34bd24e56627f148182859918accbfa82
|
|
Gain setting without a band was apparently led to a very low output
level, thanks to defog for pointing this out.
Change-Id: I8b59d38dd7b0781776c9e61226185879541fdc53
Related: OS#3342
|
|
...because it is usually negative
Change-Id: I8297dbb0fec25720e73d59fd8e38834029154405
|
|
Change-Id: I1fdfdae2810c3c82ff62fe725ffa364df4ebeff5
|
|
We wouldn't want to get caught running with unlocked external clock
sources, right?!
Change-Id: Ie38d85617f46eb5ab7d9527ddf6aaab4d3edf6bf
|
|
Change-Id: I3c69d64dfe79dcc815e1d412569ed4e9ed428c52
|
|
This is only useful if the rf path delays the signal by at least one
frame, and therefore a fairly experimental command that might be removed
or reworked in the future and should not be relied upon.
Change-Id: I29964acffad5bad4f5bcad7f631e435a72979c46
|
|
Change-Id: If0fef3f12f15780ed3a3e33db25cd29082ff142a
|
|
Change-Id: I26c942496ab12883a4a1e0d549cb462642570636
|
|
The type used to represent a thread ID is implementation
specific, and may be an opaqe structure, making it unsuitable to be
printed by standard means. Let's use osmo_gettid() instead.
Change-Id: Iaa4d0eaf52b901fff06cc67f8dd8b61ac6084911
Related: OS#5032
|
|
new libosmocore osmo-trx already depends on does support printing thread
ID as prefix to all messages (confgiurable through VTY), so there's no
use in printing it in osmo-trx unconditionally.
Moreover, The type used to represent a thread ID is implementation
specific, and may be an opaqe structure, making it unsuitable to be
printed by standard means, so in any case we should be better printing
system's TID instead.
Related: OS#5032
Change-Id: Ie98a21246230c946afc47f4f5b9c6618eefde494
|
|
Change-Id: I76975ed71382ff2afa8cfaff2950e23ff750201e
|
|
Change-Id: I559b8d8608b3e492ae1ba0d5a54e226ab424b23b
|
|
fixes "make dist-bzip2" on a clean checkout
Closes: OS#5052
Change-Id: Ieb4cefb16c8f43e708a96353c13342fe40ffdb54
|
|
Change-Id: I92b99ebab1d54e9cbdc8469d76105c55bcb03f36
|
|
Change-Id: I360e8ba91471757210c7f096c04928a6fbb91c61
Related: SYS#4454
|
|
Change-Id: I3cc0a92da39ab2594b3a7cefb314e2f2ecb628e2
|
|
Let's disable category here since we don't care about its formatting here.
In any case, every test relying on logging output validation should
always explicitly state the config to avoid issues in the future if
default values change.
Change-Id: Iaa77f8a7d3f752173507afd988bd76a8aa632082
Related: OS#5034
|
|
The API was moved to libosmocore, let's use it instead of defining our
own here with all the complexity in build system involved.
Depends: libosmocore.git Change-Id Id7534beeb22fcd50813dab76dd68818e2ff87ec2
Related: OS#5027
Change-Id: I19e32fbc47bd88a668e0c912e89b001b0f8831dd
|
|
A wrapper function with better support already exists in debug.c and
announced in debug.h. Let's use that one instead.
Related: OS#5027
Change-Id: I2ccf94f95a531d5873da2a4681cf89cbc5b31422
|
|
Change-Id: I860af60bc0fbd36dfb38316fad65ddd3a5827a8f
Related: Ib4ceec553f2e5f77bf3f6777724968456a180f5e
Related: OS#4006, OS#4373
|
|
Change-Id: Ie95876d1d2ebf31ff588999d85584f6981522fa8
|
|
In Transceiver::addRadioVector() we scale the I/Q samples by scaling
the output voltage of the DAC. A relative factor/divisor/ration in
the voltage domain cannot be used 1:1 in the power domain.
There exist two similar formulas:
a) X_dB = 10 * log10(X_lin / X_ref)
b) Y_db = 20 * log10(Y_lin / Y_ref)
both of them are correct, and according to [1]:
a) If you convert a quantity X that relates to power or energy,
=> the factor is 10.
b) If you convert a quantity Y that relates to amplitude,
=> the factor is 20.
Therefore we should be using 20 instead of 10. This change makes
osmo-trx apply per-lchan attenuation values correctly. Otherwise
it would double the values indicated in TRXD messages.
[1] https://dspillustrations.com/pages/posts/misc/decibel-conversion-factor-10-or-factor-20.html
Change-Id: I98bc00bd25df4913d45e55eb008d715aca76fc7c
Related: SYS#4918
|
|
By default, C/C++ compiler does assume integer division. The
lack of explicit cast to 'double' causes the transceiver to
ignore non-decimal attenuation values (x % 10 > 0):
txFullScale * 10 ^ ( -3 / 10)
== txFullScale * 10 ^ 0
== txFullScale * 1.0
txFullScale * 10 ^ ( -8 / 10)
== txFullScale * 10 ^ 0
== txFullScale * 1.0
txFullScale * 10 ^ (-10 / 10)
== txFullScale * 10 ^ -1
== txFullScale * 0.1
txFullScale * 10 ^ (-18 / 10)
== txFullScale * 10 ^ -1
== txFullScale * 0.1
Change-Id: I85b1063f57f630d90c6da32827bec4a05afc6514
Related: SYS#4918
|
|
The memory leak was reported by ASan:
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x7f23b488e459 in __interceptor_malloc /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cpp:145
#1 0x558e83e39e3c in ChannelizerBase::initFilters() /osmo-trx/Transceiver52M/ChannelizerBase.cpp:84
#2 0x558e83e3a8a0 in ChannelizerBase::init() /osmo-trx/Transceiver52M/ChannelizerBase.cpp:188
#3 0x558e83e2d263 in RadioInterfaceMulti::init(int) /osmo-trx/Transceiver52M/radioInterfaceMulti.cpp:197
#4 0x558e83de76d2 in makeRadioInterface(trx_ctx*, RadioDevice*, int) /osmo-trx/Transceiver52M/osmo-trx.cpp:115
#5 0x558e83dea663 in trx_start /osmo-trx/Transceiver52M/osmo-trx.cpp:600
#6 0x558e83dead6f in main /osmo-trx/Transceiver52M/osmo-trx.cpp:695
#7 0x7f23b2576151 in __libc_start_main (/usr/lib/libc.so.6+0x28151)
Change-Id: Ibc4c7edeb9bba517db08fce152d863e6cc0c7bbb
|
|
The leak was reported by ASan.
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0x7fd9c9c29f41 in operator new(unsigned long) /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cpp:99
#1 0x55bd63ae2364 in RadioInterfaceMulti::init(int) /git/osmo-trx/Transceiver52M/radioInterfaceMulti.cpp:209
#2 0x55bd63a9c6d2 in makeRadioInterface(trx_ctx*, RadioDevice*, int) /git/osmo-trx/Transceiver52M/osmo-trx.cpp:115
#3 0x55bd63a9f663 in trx_start /git/osmo-trx/Transceiver52M/osmo-trx.cpp:600
#4 0x55bd63a9fd6f in main /git/osmo-trx/Transceiver52M/osmo-trx.cpp:695
#5 0x7fd9c7910151 in __libc_start_main (/usr/lib/libc.so.6+0x28151)
Change-Id: Ia4f9d4e47caa86ada98054763573e652d281992c
|
|
Related: OS#4912
Change-Id: Ibacb11da37acfd324cee37068099627136717781
|
|
Allow to drop the uhd runtime dependency of osmo-trx-ipc.
uhd is only required for the driver-test utility.
Related: SYS#5266
Change-Id: Iff91e09684167247c9c7de0141451a5b9344aa0d
|
|
Change-Id: I4b3a76e41d4abbb08046a241ae9b7c079ce990ae
|
|
* use https for hyperlinks
* explicitly mention the primary use case with OsmoBTS
* fix spelling in title
Change-Id: I4f20ad8666dcc6bbc23d78b40b7c73ddd7e6eacc
|
|
Change-Id: I35282b38a1d560fb3440fe0aa9a27808d9d116cc
|
|
vty_cmd_string_from_valstr() expands the given 'struct value_string'
sequentionally, so the order of entries in both filler_{types,docs}
shall match (regardless of the value assigned).
Change-Id: Ieb3bbc4fb30f303c47555ca77d03a9e965bc72b5
|
|
Change-Id: Idd272959e335c46ca88e348dd792e15ddb317d61
|
|
Previous code relied on abort() switching sigaction to SIG_FDL +
retriggering SIGABRT in case the signal handler returns, which would
then generate the coredump + terminate the process.
However, if a SIGABRT is received from somewhere else (kill -SIGABRT),
then the process would print the talloc report and continue running,
which is not desired.
Change-Id: I3a3ff56cb2d740a33731ecfdf76aa32606872883
Fixes: OS#4865
|
|
Change-Id: Ic8c8c418e123fbdff625556a900b19650deefe0b
Depends: libosmocore.git Idb89ba7bc7c129a6304a76900d17f47daf54d17d
|
|
Unfortunately, we cannot re-use the existing Makefile rules from:
$(OSMO_GSM_MANUALS_DIR)/build/Makefile.vty-reference.inc
because they do not allow to generate the list of $(DOCBOOKS) from
a template, and require the project to store everything in separate
folders with specific names. Also, those rules expect that the
target PDFs contain only a single word in their names (for example,
'osmoapp-vty-reference', not 'osmo-app-vty-reference'), while in a
project with multiple similarly named targets this would reduce
readability (imagine 'osmotrxuhd-vty-reference').
Change-Id: I798ea3b7417b8ca3e9c7d50911158c5413526237
Depends: I6aac73d998c5937894233631e654a160d5623198
Related: SYS#4937, SYS#4910
|
|
Otherwise these logging lines end up in the automatically generated
XML VTY reference (stdout), so this breaks further XML processing.
Change-Id: I8e0fd728d406e2452c9c0ddad5bce5f6b17fab42
Related: SYS#4937, SYS#4910
|
|
Do not use 'extended' because it's not the same 11-bit Access Burst,
as it was assumed before. Add missing docs for 'enable'/'disable'.
Change-Id: I80b5a584e554eb7cc2416017b10fee032202b372
|
|
Change-Id: I7fb228c63f3246f443ece67106abba0432b1659e
|
|
Dummy bursts have nothing to do with A5/x encryption, and I see
no reason why (and how?!?) would using that filler type break
encryption in osmo-bts-trx. I asked the author of this code
back in August 2020 [1], and so far didn't get any response.
[1] https://lists.osmocom.org/pipermail/openbsc/2020-August/013208.html
Change-Id: Iae513d7acbb8ef682e1744ac8726cbd6ece8bd87
|