From 9f2eaf8f56b14a462f0cd92843f11a17b8bfbc71 Mon Sep 17 00:00:00 2001 From: Neels Hofmeyr Date: Wed, 13 Apr 2016 19:14:47 +0200 Subject: cosmetic: auth tuple memcpy: rather use target's sizeof() --- openbsc/src/gprs/gprs_gmm.c | 6 +++--- openbsc/src/libmsc/gsm_04_08.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'openbsc') diff --git a/openbsc/src/gprs/gprs_gmm.c b/openbsc/src/gprs/gprs_gmm.c index aa376d848..51ce22b5b 100644 --- a/openbsc/src/gprs/gprs_gmm.c +++ b/openbsc/src/gprs/gprs_gmm.c @@ -1111,9 +1111,9 @@ static int gsm48_rx_gmm_att_req(struct sgsn_mm_ctx *ctx, struct msgb *msg, ctx->auth_triplet.key_seq = 0; - memcpy(&ctx->auth_triplet.rand, &tmp_rand, sizeof(tmp_rand)); - memcpy(&ctx->auth_triplet.sres, &vec.sres, sizeof(vec.sres)); - memcpy(&ctx->auth_triplet.kc, &vec.kc, sizeof(vec.kc)); + memcpy(&ctx->auth_triplet.rand, &tmp_rand, sizeof(ctx->auth_triplet.rand)); + memcpy(&ctx->auth_triplet.sres, &vec.sres, sizeof(ctx->auth_triplet.sres)); + memcpy(&ctx->auth_triplet.kc, &vec.kc, sizeof(ctx->auth_triplet.kc)); } /* Update MM Context with other data */ diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c index be03fd7d5..4fb1e5d2f 100644 --- a/openbsc/src/libmsc/gsm_04_08.c +++ b/openbsc/src/libmsc/gsm_04_08.c @@ -165,9 +165,9 @@ int iu_hack__get_hardcoded_auth_tuple(struct gsm_auth_tuple *atuple) osmo_auth_gen_vec(&vec, &auth, tmp_rand); atuple->key_seq = 0; - memcpy(&atuple->rand, &tmp_rand, sizeof(tmp_rand)); - memcpy(&atuple->sres, &vec.sres, sizeof(vec.sres)); - memcpy(&atuple->kc, &vec.kc, sizeof(vec.kc)); + memcpy(&atuple->rand, &tmp_rand, sizeof(atuple->rand)); + memcpy(&atuple->sres, &vec.sres, sizeof(atuple->sres)); + memcpy(&atuple->kc, &vec.kc, sizeof(atuple->kc)); return AUTH_DO_AUTH; } -- cgit v1.2.3