From ea71b4880cc6542ad13db75a0b9b9c85d640bad1 Mon Sep 17 00:00:00 2001 From: Jacob Erlbeck Date: Mon, 22 Sep 2014 09:28:27 +0200 Subject: gbproxy/test: Fix IMSI length check (Coverity) This fixes the IMSI length assertion, which currently uses a greater-or-equal than zero comparison which always yields true. It is replaced by a greater than zero check. Fixes: Coverity CID 1239442 Sponsored-by: On-Waves ehf --- openbsc/tests/gbproxy/gbproxy_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'openbsc/tests/gbproxy') diff --git a/openbsc/tests/gbproxy/gbproxy_test.c b/openbsc/tests/gbproxy/gbproxy_test.c index df7b22ead..a99986bc4 100644 --- a/openbsc/tests/gbproxy/gbproxy_test.c +++ b/openbsc/tests/gbproxy/gbproxy_test.c @@ -3331,7 +3331,7 @@ static void test_gbproxy_keep_info() link_info = gbproxy_link_info_by_tlli(peer, foreign_tlli); OSMO_ASSERT(link_info); OSMO_ASSERT(link_info == link_info2); - OSMO_ASSERT(link_info->imsi_len >= 0); + OSMO_ASSERT(link_info->imsi_len > 0); OSMO_ASSERT(!link_info->is_deregistered); OSMO_ASSERT(link_info->imsi_acq_pending); -- cgit v1.2.3