From d17bc7b3a8bce2c507a2e72459b34c07b7fdcd52 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Mon, 17 Aug 2015 15:19:57 +0200 Subject: mgcp: Avoid crashing when rtpmap is not complete The NAT sends an incomplete SDP file for the purpose of informing the BSC about the remote IP/PORT early. The case of an incomplete SDP file was not considered. Check if there is a codec and if not skip it. TODO: We need to have a better end-point life cycle test. --- openbsc/src/libmgcp/mgcp_sdp.c | 3 +++ 1 file changed, 3 insertions(+) (limited to 'openbsc/src/libmgcp') diff --git a/openbsc/src/libmgcp/mgcp_sdp.c b/openbsc/src/libmgcp/mgcp_sdp.c index 33837b9af..aa4ef3054 100644 --- a/openbsc/src/libmgcp/mgcp_sdp.c +++ b/openbsc/src/libmgcp/mgcp_sdp.c @@ -159,6 +159,9 @@ int is_codec_compatible(struct mgcp_endpoint *endp, struct sdp_rtp_map *codec) char *bts_codec; char audio_codec[64]; + if (!codec->codec_name) + return 0; + /* * GSM, GSM/8000 and GSM/8000/1 should all be compatible.. let's go * by name first. -- cgit v1.2.3