aboutsummaryrefslogtreecommitdiffstats
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2023-01-11Fix extra whitespace in pdpctx_ctr_descriptionPau Espin Pedrol1-4/+4
Change-Id: I4d9145c681e725b709fde38f6e9b4516d37b4d8c
2023-01-11vty: Introduce encryption cipher-plugin-path commandPau Espin Pedrol2-2/+27
The load of plugins will eventually be moved to libosmo-gprs implementation, and path will be passed as a parameter. Once it's moved inside libosmo-gprs, it will be more strict on load failures, which can cause internally if the path doesn't exist (unless NULL is passed). Hence, add a VTY config to allow configuring the right path, and have it disabled by default. Change-Id: I4f965c7afafa193f4d7486750dd3e43cca22bb65
2023-01-11Move global mmctx list into struct sgsn_instancePau Espin Pedrol4-13/+12
Change-Id: Idf8458902321da03b9b0831dad3ad383a9c7afa1
2023-01-11Split gprs_sgsn.{c,h} -> {auth,mmctx,sgsn}.{c,h}Pau Espin Pedrol21-169/+235
Some level of split already existed, like sgsn_auth.c, but headers were entangled together. Let's clearly separate application centric code (sgsn.c/h), auth related code (auth.c/h) and mmctx related code (mmctx.c/h). Change-Id: I048a082851c1275c959649942904205b02acce2a
2023-01-11gtphub.h: Remove dependency on sgsn/gprs_sgsn.hPau Espin Pedrol4-3/+10
It is only really needed to import define GSM_APN_LENGTH, which is actually also available in libosmogsm. Hence simply use the one from libosmogsm. Change-Id: I4c6110feeeaa1adfb6b1f0147eeb56dfe34636ec
2023-01-11Rename bscconfig.h -> config.hPau Espin Pedrol9-9/+9
Change-Id: I007103be34c1aaab7a9375c44b226d4590fe5b24
2023-01-11Move gtphub header to include/osmocom/gtphub/Pau Espin Pedrol5-5/+5
Change-Id: I82e1f2a3bc8e22b28747a540879bd661f1704cde
2023-01-11Move global pdp_list inside struct sgsn_instancePau Espin Pedrol3-5/+4
This way pdp contexts are managed by the lifcycle of the main global struct sgsn_instance automatically. Change-Id: I725218fd54adcc68dceded5eb43675f25771bb96
2023-01-11Move sgsn_pdp_ctx to its own file pdpctx.{c,h}Pau Espin Pedrol12-119/+171
This further shrinks the mess in gprs_sgsn.h, and allows to easily see layer violations (like pdpctx.c requiring llc.h) Change-Id: Iad4da06efee7d8514ff48423bdaebc0f26413cc1
2023-01-11Drop extern declarations of global sgsn_instance in source filesPau Espin Pedrol3-6/+0
There's an extern declaration already in sgsn.h. Change-Id: I2375e13c8436a069e8fe60136c8e1759a9adc2d1
2023-01-11Move extern declarations of tall_sgsn_ctx to sgsn.hPau Espin Pedrol8-14/+0
Change-Id: Ifbd54b2e92db8d4a0e0cd1c569cfd83dd85165b8
2023-01-11gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instancePau Espin Pedrol6-19/+17
This way apns are managed by the lifcycle of the main global struct sgsn_instance automatically. Change-Id: Ie65d59632a368c6957c33dca64e856ace792b2c6
2023-01-05Move global apn_list inside struct sgsn_instancePau Espin Pedrol3-10/+10
This way apns are managed by the lifcycle of the main global struct sgsn_instance automatically. Change-Id: I8cc8e540cfb64d0f130e9c0aaedf7b0835f8fe16
2023-01-05Move gtp related functions to gtp.hPau Espin Pedrol7-0/+7
The functions are implemented in sgsn_libgtp.c and hence belong to header file gtp.h Change-Id: I7f5cf2895b05e03435769548b61051e6284ccb3c
2023-01-05sndcp: Standarize unitdata function namingPau Espin Pedrol3-7/+7
Use sndcp_<sap>_type>_<op> so that it's easier to distinguish and identify them. Change-Id: Ib8825570a8f61d0a28d631f86f5244e70d3194aa
2023-01-05Move func defintions of funcs implemented in gprs_sndcp.c to gprs_sndcp.hPau Espin Pedrol1-0/+1
Move them to the correct header where they belong, so that the all the related protocol stuff is placed together. Change-Id: I9052f48a0af125bb445194f4ae94ebbe49508fda
2023-01-05Properly split llc->sndcp->gtp unitdata pathi through extra func callPau Espin Pedrol2-8/+17
Beforehand the function handling the LL-UNITDATA primitive from LLC was already submitting the packet to GTP code which had an SNDCP related name, so everything was really confusing and layer separation was not clean. Change-Id: Ia544a9dd4c0c7647b0c1b64ca110351f40820618
2023-01-05Move struct apn_ctx and APN related definitions to its own filePau Espin Pedrol3-98/+127
This allows further shrinking of gprs_sgsn.{c,h} and also being able to use GSM_APN_LENGTH on different headers easily (needed by follow-up patch). Change-Id: Id225ed8b84e1376f4a30f17dd4b153b6b1a6efa8
2023-01-05Move global ggsn_list into struct sgsn_instancePau Espin Pedrol3-5/+5
Change-Id: I9d4c74476b777a866af2796dd376ed50da7b5d01
2023-01-05Keep sgsn subsystems under struct sgsn_instance lifecyclePau Espin Pedrol4-43/+61
Rework initialization and destruction of several sgsn subsystems to be allocated & released together with the struct sgsn_instance. This makes it easier to destroy and recreate the entire context and allows us to start moving global variables scattered around to be under struct sgsn_instance. Change-Id: Idf60519b8e475b94d38bbb69e737132a5afaefab
2023-01-05Remove unneeded extern declaration from libosmocotrlPau Espin Pedrol1-2/+0
Change-Id: I464df2d03538c71f6666046c67170746690e723d
2023-01-05Fix -Werror=old-style-definitionPau Espin Pedrol2-6/+7
Change-Id: I119d4ba58d9c68df12b433b0cee924468a1473d8
2023-01-05Introduce new header file sgsn/gtp.hPau Espin Pedrol1-0/+1
It will be used to store all stuff relatd to libgtp use and GTP protocol, similar to what we already do for other protocols. Change-Id: I4aae35cd0ea401856cd822cb507d668350d07a89
2023-01-05Move gprs_sndcp_vty_init() declaration to gprs_sndcp.hPau Espin Pedrol1-0/+1
Change-Id: Iea9692e7ef9bd017d89ef654d2f2ae5b30cc4550
2023-01-05gprs_subscriber: Move API declarations to correct headerPau Espin Pedrol1-0/+1
Change-Id: Iaa1032c38fa54ad57c472d9120cfbb34b2ae90e9
2023-01-05Move struct sgsn_ggsn_ctx to its own file gtp_ggsn.{c,h}Pau Espin Pedrol8-140/+185
Similar to what we already have for struct sgsn_mme_ctx in gtp_mme.{c,h}. This is just the nth step of properly splitting different protocol layers, data model, etc. Change-Id: Iad1895f09e43e299df7bb126bf52fdb98268392e
2023-01-04Replace gprs_str_to_apn() with libosmocore API osmo_apn_from_str()Pau Espin Pedrol1-34/+0
The exact same function exists in libosmocore with a different naming. Change-Id: Ibef55a648f2d58f4fdd24fa553efde530982af2d
2023-01-04Remove unused function gprs_parse_mi_tmsi()Pau Espin Pedrol1-13/+0
Change-Id: I6fb7688bf54c7ae3ca3e06bf3a1b729fa62d82f9
2023-01-04Standarize lle and llme state enum & value_stringPau Espin Pedrol2-12/+12
Change-Id: Iaf102ce5ca60854fe7eb1af17c73a80e7c76181b
2023-01-04vty: Fix wrong value_string used to print llme statePau Espin Pedrol1-1/+1
Change-Id: Id3eec91b47029964092087858e4ae3a824929ce3
2023-01-04cosmetic: gprs_llc_vty.c: Fix trailing whitespacePau Espin Pedrol1-1/+1
Change-Id: I543fd784f7e1a0f7c82bd7c79e073104becc88da
2023-01-02Move gprs_tmr_to_secs() to tests/gprs/gprs_test.cPau Espin Pedrol1-16/+0
That function is only used in the test. Let's hence move the function to the same test file in order to simplify osmo-sgsn code. Change-Id: I69d80810362d75eb93974af34f61639514f99f8a
2022-12-28Rename gprs_gb.[c,h] -> gprs_ns.[c,h]Pau Espin Pedrol6-5/+5
All remaining code in that file is NS protocol related, hence let's rename it so that we end up with one file per protocol in the Gb stack. Change-Id: I8312c8a70d60cab48764950c5b57ca02964e9db2
2022-12-28Move some functions gprs_gb.[c,h] -> gprs_gmm.[c,h]Pau Espin Pedrol3-50/+50
This leaves only NS protocol related code in gprs_gb.[c,h], which will be renamed to gprs_ns.[c,h] in a follow up patch. Change-Id: I3dcbe1d0f75cb91ec8b700e239e2ba16fff030a2
2022-12-28Create new specific file for BSSGP codePau Espin Pedrol6-63/+104
Right now there's no much code there since the related code is totally entangled with the LLC one. This will eventually change in the future when we switch to use libosmo-gprs. Hence, this commit is a preparation to have already some place to put new BSSGP specific code in the future. Change-Id: I816396ab5ccb86032bbc21b41a959934a7768780
2022-12-22Move gprs_gb_parse.[c,h] to tests/sgsn/Pau Espin Pedrol2-687/+0
That big file is really only used by tests/sgsn/sgsn_test nowadays, so let's keep it out of osmo-sgsn app code base. Change-Id: Ia5a639832f52b2f015a2800bd0d94a28d7bc689b
2022-12-17ctrl: take both address and port from vty configMax1-2/+1
Change-Id: Ie1330b152a2e5cdcdb80a1c958e7c1d784b78eab
2022-12-06sndcp: Put decompress handling code into helper functionPau Espin Pedrol1-79/+64
This further simplifies code and avoids duplicating it. Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649
2022-11-17sgsn_libgtp: cb_data_ind: remove mm_idle assertOliver Smith1-4/+13
Log an error message and drop the packet instead of asserting if mm state fsm is in ST_MM_IDLE while the gmm fsm is in ST_GMM_REGISTERED_NORMAL. Fixes: OS#5725 Change-Id: I9dab98917c622b36dae22399bb359d747a598208
2022-11-04vty: Make new libgtp tdefs configurable through VTYPau Espin Pedrol1-0/+26
Related: OS#5485 Depends: osmo-ggsn.git Change-Id I10bc8e2e197c0e8753b23b684b5ae41025672bf7 Change-Id: I46e9cd158a9f2f721c69f807beb7bb67a459f4a4
2022-10-14GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal stateMax1-0/+6
The FSM might be moved out of ST_GMM_COMMON_PROC_INIT state either by E_GMM_ATTACH_SUCCESS or by E_GMM_COMMON_PROC_SUCCESS events which are not mutually exclusive. Hence the later event will arrive when we're already in the ST_GMM_REGISTERED_NORMAL state. Let's have both events permitted to keep the logs clean from useless error. Related: OS#5349 Change-Id: Ia97b50aac6c665812ddca9010de7f97b17b78bd5
2022-10-11Constify LLC/SNDCP parametersMax2-18/+19
That makes it easier to track side-effects while reading the code. Related: OS#5349 Change-Id: I903f8a747a8d3b7f734dac7b0c12373ecbb90b11
2022-10-11GTP: migrate from deprecated functionMax1-2/+2
The gtp_set_cb_recovery3() is similar to gtp_set_cb_recovery2() with extra parameter representing GSN. Change-Id: I8b46cf8c52e36b0312eddf37f3e136662b95732e
2022-10-08SNDCP: log more details on failureMax1-2/+3
Related: OS#5349 Change-Id: Iad3ebbc28909a827db7b3a0ae2d3e1de7991210f
2022-09-08llc: gprs_llc_fcs(): make the input data pointer constVadim Yanitskiy2-2/+2
Change-Id: If95210fe69f915ab1010fe5916cb6bee3faeb7b9
2022-08-26gprs_llc: fix misleading spacing in gprs_llc_rcvmsg()Vadim Yanitskiy1-3/+3
Change-Id: I7ec97a7d9b37f0541887bc13e31f547613f8945e
2022-03-10Iu: add UEA encryptionNeels Hofmeyr4-3/+46
Add vty 'encryption uea 0 1 2', defaults to 'encryption uea 0' to yield previous behavior. If any UEA above 0 is enabled, include the UEA key in the Iu Security Mode Command. I noticed that only the code bit in st_iu_security_cmd_on_enter() affects the test. The same code in gsm48_gmm_authorize() seems to be dead code? But applying the patch there as well just to be safe. We cannot yet verify the chosen UEA to match a configured UEA level, because the iu_client.c does not send us message details with the RANAP_IU_EVENT_SECURITY_MODE_COMPLETE. Also we cannot yet send the set of configured UEA to the hNodeB, since, again, iu_client.c does not provide the proper API for it. The proper solution here is to completely dissolve iu_client.c and do all Iu handling in osmo-sgsn itself -- see OS#5487. Related: SYS#5516 Related: I1a7c3b156830058c43f15f55883ea301d2d01d5f (osmo-ttcn3-hacks) Change-Id: I27e8e0078c45426bf227bb44aac82a4875d18d0f
2022-03-07s/cipher_support_mask/gea_encryption_maskNeels Hofmeyr2-10/+10
will add uea_encryption_mask, and find that the name 'cipher_support_mask' is not concise enough. Related: SYS#5516 Change-Id: Ie8d4a0534c5b751f698bce425427bb1d28ddea31
2022-02-18Revert "sgsn: Handle different levels of QoS"Pau Espin Pedrol1-12/+5
This reverts commit 4bd931f96d75d3e71b73a06e67f84ffdcab9caf6. The commit was wrong, and previous code is correct. Relevant specs: * TS 29.060 7.7.34 Quality of Service (QoS) Profile * TS 24.008 10.5.6.5 Quality of service As can be seen in TS 24.008 10.5.6.5, OSMO_IE_GSM_REQ_QOS never comes with the the ARP byte prepended. This is actually always prepended when sending the GTP message, as explained in TS 29.060 7.7.34. As a result, the Qos Service sent in Create PDP Context Request sent to the GGSN contained wrongly formatted Qos Profile IE, which was observed checking wireshark with a real phone. This was found due to open5gs-smfd being more strict about the possible lengths of the IE, since the wrongly formatted IE send in GTP had length=14, which is incorrect due to folllowing TS 24.008 10.5.6.5 wording: "Octets 15-22 are optional. If octet 15 is included, then octet 16 shall also be included, and octets 17-22may be included." In this case, due to the wrong format it was seen as including octet 15 but not 16. Change-Id: I4fc5ab823a27d27482858a7459337a2f8ae593c3 Related: SYS#5793
2021-12-14treewide: remove FSF addressOliver Smith1-4/+0
Remove the paragraph about writing to the Free Software Foundation's mailing address. The FSF has changed addresses in the past, and may do so again. In 2021 this is not useful, let's rather have a bit less boilerplate at the start of source files. Change-Id: I9bc57a7152015e0f37e3d1573921d6d5d3c0449b
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-26 11:13:33 +0000