aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2023-05-26systemd: depend on networking-online.targetOliver Smith2-0/+4
Related: SYS#6400 Change-Id: Idadcbbf55e976ae035cfac4b85ccd870e0f27b82
2023-02-07Bump version: 1.9.0.56-07fe-dirty → 1.10.01.10.0Pau Espin Pedrol5-32/+99
Change-Id: I89eb79ffeb28b8dae5b4a5c3cc1142d07052692c
2023-01-11Fix extra whitespace in pdpctx_ctr_descriptionPau Espin Pedrol1-4/+4
Change-Id: I4d9145c681e725b709fde38f6e9b4516d37b4d8c
2023-01-11vty: Introduce encryption cipher-plugin-path commandPau Espin Pedrol4-2/+30
The load of plugins will eventually be moved to libosmo-gprs implementation, and path will be passed as a parameter. Once it's moved inside libosmo-gprs, it will be more strict on load failures, which can cause internally if the path doesn't exist (unless NULL is passed). Hence, add a VTY config to allow configuring the right path, and have it disabled by default. Change-Id: I4f965c7afafa193f4d7486750dd3e43cca22bb65
2023-01-11Move global mmctx list into struct sgsn_instancePau Espin Pedrol7-15/+16
Change-Id: Idf8458902321da03b9b0831dad3ad383a9c7afa1
2023-01-11Split gprs_sgsn.{c,h} -> {auth,mmctx,sgsn}.{c,h}Pau Espin Pedrol33-218/+311
Some level of split already existed, like sgsn_auth.c, but headers were entangled together. Let's clearly separate application centric code (sgsn.c/h), auth related code (auth.c/h) and mmctx related code (mmctx.c/h). Change-Id: I048a082851c1275c959649942904205b02acce2a
2023-01-11gtphub.h: Remove dependency on sgsn/gprs_sgsn.hPau Espin Pedrol6-8/+14
It is only really needed to import define GSM_APN_LENGTH, which is actually also available in libosmogsm. Hence simply use the one from libosmogsm. Change-Id: I4c6110feeeaa1adfb6b1f0147eeb56dfe34636ec
2023-01-11Rename bscconfig.h -> config.hPau Espin Pedrol12-13/+13
Change-Id: I007103be34c1aaab7a9375c44b226d4590fe5b24
2023-01-11Move LOGGSUBSCRP to gprs_subscriber.hPau Espin Pedrol2-5/+5
The define belongs to gprs_subscriber.h header. Change-Id: Icdb7e55ca8e90dd2ba79ccdb1a8ba650a3942ab3
2023-01-11Move sgsn_ctrl_cmds_install() declaration to sgsn.hPau Espin Pedrol2-5/+5
sgsn.h is the main header containing all misc app related contents. This is another step towards shrinking gprs_sgsn.h mess. Change-Id: I80e3a68e2e368d8c73135c850e4728bdf6cf5f09
2023-01-11Move gtphub header to include/osmocom/gtphub/Pau Espin Pedrol12-8/+12
Change-Id: I82e1f2a3bc8e22b28747a540879bd661f1704cde
2023-01-11Move global pdp_list inside struct sgsn_instancePau Espin Pedrol5-7/+5
This way pdp contexts are managed by the lifcycle of the main global struct sgsn_instance automatically. Change-Id: I725218fd54adcc68dceded5eb43675f25771bb96
2023-01-11Move sgsn_pdp_ctx to its own file pdpctx.{c,h}Pau Espin Pedrol16-193/+270
This further shrinks the mess in gprs_sgsn.h, and allows to easily see layer violations (like pdpctx.c requiring llc.h) Change-Id: Iad4da06efee7d8514ff48423bdaebc0f26413cc1
2023-01-11Drop extern declarations of global sgsn_instance in source filesPau Espin Pedrol3-6/+0
There's an extern declaration already in sgsn.h. Change-Id: I2375e13c8436a069e8fe60136c8e1759a9adc2d1
2023-01-11Move extern declarations of tall_sgsn_ctx to sgsn.hPau Espin Pedrol9-14/+1
Change-Id: Ifbd54b2e92db8d4a0e0cd1c569cfd83dd85165b8
2023-01-11gtp_{ggsn,mme}: Allocate contexts under struct sgsn_instancePau Espin Pedrol8-26/+25
This way apns are managed by the lifcycle of the main global struct sgsn_instance automatically. Change-Id: Ie65d59632a368c6957c33dca64e856ace792b2c6
2023-01-05Move global apn_list inside struct sgsn_instancePau Espin Pedrol6-12/+12
This way apns are managed by the lifcycle of the main global struct sgsn_instance automatically. Change-Id: I8cc8e540cfb64d0f130e9c0aaedf7b0835f8fe16
2023-01-05Move gtp related functions to gtp.hPau Espin Pedrol9-12/+29
The functions are implemented in sgsn_libgtp.c and hence belong to header file gtp.h Change-Id: I7f5cf2895b05e03435769548b61051e6284ccb3c
2023-01-05sndcp: Standarize unitdata function namingPau Espin Pedrol4-11/+12
Use sndcp_<sap>_type>_<op> so that it's easier to distinguish and identify them. Change-Id: Ib8825570a8f61d0a28d631f86f5244e70d3194aa
2023-01-05Move func defintions of funcs implemented in gprs_sndcp.c to gprs_sndcp.hPau Espin Pedrol3-12/+10
Move them to the correct header where they belong, so that the all the related protocol stuff is placed together. Change-Id: I9052f48a0af125bb445194f4ae94ebbe49508fda
2023-01-05Properly split llc->sndcp->gtp unitdata pathi through extra func callPau Espin Pedrol5-11/+24
Beforehand the function handling the LL-UNITDATA primitive from LLC was already submitting the packet to GTP code which had an SNDCP related name, so everything was really confusing and layer separation was not clean. Change-Id: Ia544a9dd4c0c7647b0c1b64ca110351f40820618
2023-01-05sgsn.h: Drop declaration of non existing functionPau Espin Pedrol1-3/+0
Change-Id: Idabea56d1ff89e51b517b15771a5a1ed3b050ec9
2023-01-05Move struct sgsn_subscriber_pdp_data to gprs_subscriber.hPau Espin Pedrol3-17/+16
The functions driving its lifcyecles are already in gprs_subscriber.c, and are used mainly by functions in the same file, hence move it to the related header to further shrink gprs_sgsn.h. Change-Id: Iff7be91af130a3317d57d3649c17e3d5d2540e7a
2023-01-05Move struct apn_ctx and APN related definitions to its own filePau Espin Pedrol8-113/+154
This allows further shrinking of gprs_sgsn.{c,h} and also being able to use GSM_APN_LENGTH on different headers easily (needed by follow-up patch). Change-Id: Id225ed8b84e1376f4a30f17dd4b153b6b1a6efa8
2023-01-05Move global ggsn_list into struct sgsn_instancePau Espin Pedrol5-6/+6
Change-Id: I9d4c74476b777a866af2796dd376ed50da7b5d01
2023-01-05Keep sgsn subsystems under struct sgsn_instance lifecyclePau Espin Pedrol8-63/+83
Rework initialization and destruction of several sgsn subsystems to be allocated & released together with the struct sgsn_instance. This makes it easier to destroy and recreate the entire context and allows us to start moving global variables scattered around to be under struct sgsn_instance. Change-Id: Idf60519b8e475b94d38bbb69e737132a5afaefab
2023-01-05Remove unneeded extern declaration from libosmocotrlPau Espin Pedrol1-2/+0
Change-Id: I464df2d03538c71f6666046c67170746690e723d
2023-01-05Move related structs to gprs_subscriber.hPau Espin Pedrol2-24/+26
This allows shrinking a bit more gprs_sgsn.h and and in turn have everything much more tidy. Change-Id: Ie39b48a0d612aa632327cc5a21c833b05f5bf297
2023-01-05Fix -Werror=old-style-definitionPau Espin Pedrol6-15/+16
Change-Id: I119d4ba58d9c68df12b433b0cee924468a1473d8
2023-01-05Introduce new header file sgsn/gtp.hPau Espin Pedrol4-3/+7
It will be used to store all stuff relatd to libgtp use and GTP protocol, similar to what we already do for other protocols. Change-Id: I4aae35cd0ea401856cd822cb507d668350d07a89
2023-01-05Move gprs_sndcp_vty_init() declaration to gprs_sndcp.hPau Espin Pedrol3-1/+3
Change-Id: Iea9692e7ef9bd017d89ef654d2f2ae5b30cc4550
2023-01-05gprs_subscriber: Move API declarations to correct headerPau Espin Pedrol3-30/+29
Change-Id: Iaa1032c38fa54ad57c472d9120cfbb34b2ae90e9
2023-01-05Move struct sgsn_ggsn_ctx to its own file gtp_ggsn.{c,h}Pau Espin Pedrol13-169/+229
Similar to what we already have for struct sgsn_mme_ctx in gtp_mme.{c,h}. This is just the nth step of properly splitting different protocol layers, data model, etc. Change-Id: Iad1895f09e43e299df7bb126bf52fdb98268392e
2023-01-04Replace gprs_str_to_apn() with libosmocore API osmo_apn_from_str()Pau Espin Pedrol3-53/+17
The exact same function exists in libosmocore with a different naming. Change-Id: Ibef55a648f2d58f4fdd24fa553efde530982af2d
2023-01-04Remove unused function gprs_parse_mi_tmsi()Pau Espin Pedrol2-14/+0
Change-Id: I6fb7688bf54c7ae3ca3e06bf3a1b729fa62d82f9
2023-01-04Standarize lle and llme state enum & value_stringPau Espin Pedrol3-12/+13
Change-Id: Iaf102ce5ca60854fe7eb1af17c73a80e7c76181b
2023-01-04vty: Fix wrong value_string used to print llme statePau Espin Pedrol1-1/+1
Change-Id: Id3eec91b47029964092087858e4ae3a824929ce3
2023-01-04cosmetic: gprs_llc_vty.c: Fix trailing whitespacePau Espin Pedrol1-1/+1
Change-Id: I543fd784f7e1a0f7c82bd7c79e073104becc88da
2023-01-02Move gprs_tmr_to_secs() to tests/gprs/gprs_test.cPau Espin Pedrol3-17/+16
That function is only used in the test. Let's hence move the function to the same test file in order to simplify osmo-sgsn code. Change-Id: I69d80810362d75eb93974af34f61639514f99f8a
2022-12-28Rename gprs_gb.[c,h] -> gprs_ns.[c,h]Pau Espin Pedrol9-7/+7
All remaining code in that file is NS protocol related, hence let's rename it so that we end up with one file per protocol in the Gb stack. Change-Id: I8312c8a70d60cab48764950c5b57ca02964e9db2
2022-12-28Move some functions gprs_gb.[c,h] -> gprs_gmm.[c,h]Pau Espin Pedrol5-55/+55
This leaves only NS protocol related code in gprs_gb.[c,h], which will be renamed to gprs_ns.[c,h] in a follow up patch. Change-Id: I3dcbe1d0f75cb91ec8b700e239e2ba16fff030a2
2022-12-28Create new specific file for BSSGP codePau Espin Pedrol10-69/+118
Right now there's no much code there since the related code is totally entangled with the LLC one. This will eventually change in the future when we switch to use libosmo-gprs. Hence, this commit is a preparation to have already some place to put new BSSGP specific code in the future. Change-Id: I816396ab5ccb86032bbc21b41a959934a7768780
2022-12-22Move gprs_gb_parse.[c,h] to tests/sgsn/Pau Espin Pedrol7-7/+10
That big file is really only used by tests/sgsn/sgsn_test nowadays, so let's keep it out of osmo-sgsn app code base. Change-Id: Ia5a639832f52b2f015a2800bd0d94a28d7bc689b
2022-12-17ctrl: take both address and port from vty configMax1-2/+1
Change-Id: Ie1330b152a2e5cdcdb80a1c958e7c1d784b78eab
2022-12-08osmo-gtphub.cfg: fix conflict with osmo-ggsn.cfgOliver Smith1-1/+1
Change bind-to-ggsns from 127.0.0.2 to 127.0.0.20, so osmo-gtphub's default config does not confligt with the osmo-ggsn default config. This change is for the effort of making the configs of all Osmocom programs not conflict with each other. A similar change was made in Id892e1f4ab2daabbe9824b819b5fed985373b97a with bind-to-sgsns. Related: OS#5817 Change-Id: I57ee457b62139d831707b6ebd6baaea8d33c2d9c
2022-12-06sndcp: Put decompress handling code into helper functionPau Espin Pedrol1-79/+64
This further simplifies code and avoids duplicating it. Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649
2022-11-17sgsn_libgtp: cb_data_ind: remove mm_idle assertOliver Smith1-4/+13
Log an error message and drop the packet instead of asserting if mm state fsm is in ST_MM_IDLE while the gmm fsm is in ST_GMM_REGISTERED_NORMAL. Fixes: OS#5725 Change-Id: I9dab98917c622b36dae22399bb359d747a598208
2022-11-15contrib/jenkins.sh: use enable-werror with IU tooOliver Smith1-5/+2
Now that the warnings in osmo-iuh have been fixed, we should be able to build the IU version of OsmoSGSN with --enable-werror too. Related: OS#4462 Change-Id: I8cc4e209e21acfe513bef72927499f1ccdead783
2022-11-04vty: Make new libgtp tdefs configurable through VTYPau Espin Pedrol4-0/+29
Related: OS#5485 Depends: osmo-ggsn.git Change-Id I10bc8e2e197c0e8753b23b684b5ae41025672bf7 Change-Id: I46e9cd158a9f2f721c69f807beb7bb67a459f4a4
2022-10-14GMM: permit E_GMM_COMMON_PROC_SUCCESS in normal stateMax1-0/+6
The FSM might be moved out of ST_GMM_COMMON_PROC_INIT state either by E_GMM_ATTACH_SUCCESS or by E_GMM_COMMON_PROC_SUCCESS events which are not mutually exclusive. Hence the later event will arrive when we're already in the ST_GMM_REGISTERED_NORMAL state. Let's have both events permitted to keep the logs clean from useless error. Related: OS#5349 Change-Id: Ia97b50aac6c665812ddca9010de7f97b17b78bd5