aboutsummaryrefslogtreecommitdiffstats
path: root/src/sgsn/sgsn_vty.c
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2022-02-18 17:20:44 +0100
committerPau Espin Pedrol <pespin@sysmocom.de>2022-02-18 17:26:14 +0100
commit938ebfb129eaa6daec5ac2c1b8c59d2c756d1873 (patch)
tree81df32de2a6e88f538384814c0cc70a10de41199 /src/sgsn/sgsn_vty.c
parentd06c717e307daa8dd584b697ae6cc13bfdbe1cfe (diff)
Revert "sgsn: Handle different levels of QoS"
This reverts commit 4bd931f96d75d3e71b73a06e67f84ffdcab9caf6. The commit was wrong, and previous code is correct. Relevant specs: * TS 29.060 7.7.34 Quality of Service (QoS) Profile * TS 24.008 10.5.6.5 Quality of service As can be seen in TS 24.008 10.5.6.5, OSMO_IE_GSM_REQ_QOS never comes with the the ARP byte prepended. This is actually always prepended when sending the GTP message, as explained in TS 29.060 7.7.34. As a result, the Qos Service sent in Create PDP Context Request sent to the GGSN contained wrongly formatted Qos Profile IE, which was observed checking wireshark with a real phone. This was found due to open5gs-smfd being more strict about the possible lengths of the IE, since the wrongly formatted IE send in GTP had length=14, which is incorrect due to folllowing TS 24.008 10.5.6.5 wording: "Octets 15-22 are optional. If octet 15 is included, then octet 16 shall also be included, and octets 17-22may be included." In this case, due to the wrong format it was seen as including octet 15 but not 16. Change-Id: I4fc5ab823a27d27482858a7459337a2f8ae593c3 Related: SYS#5793
Diffstat (limited to 'src/sgsn/sgsn_vty.c')
0 files changed, 0 insertions, 0 deletions