From ee5be3a0095b4bae430032d35e3ad0716eff34ab Mon Sep 17 00:00:00 2001 From: Max Date: Wed, 20 Dec 2017 17:31:13 +0100 Subject: TBF: implement independent T31xx timers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously TBF got single timer so the pending timer was automatically cancelled when new one was scheduled. Let's make it more robust by implementing independent T31 xx timers from 3GPP TS 44.060 ยง13.2 with corresponding start/stop functions and counters. The semantics of the timers is preserved as before: pending timers are restarted unconditionally. It might be neecessary to change this later on after spec review. N. B. T0: used for assign/reject timeouts, have to be properly attributed and documented first. Change-Id: I0305873ca47534f53441247217881da59625e1f7 Related: OS#2407 --- tests/tbf/TbfTest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index d4b51fe2..18bbc76e 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -51,9 +51,9 @@ static void check_tbf(gprs_rlcmac_tbf *tbf) { OSMO_ASSERT(tbf); if (tbf->state_is(GPRS_RLCMAC_WAIT_RELEASE)) - OSMO_ASSERT(tbf->T == 3191 || tbf->T == 3193); + OSMO_ASSERT(tbf->timers_pending(T3191) || tbf->timers_pending(T3193)); if (tbf->state_is(GPRS_RLCMAC_RELEASING)) - OSMO_ASSERT(tbf->T != 0); + OSMO_ASSERT(tbf->timers_pending(T_MAX)); } static void test_tbf_base() -- cgit v1.2.3