From b3a87ced5ab427b3ab95d79557ddad1cac254c6c Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Thu, 12 Dec 2013 14:42:35 +0100 Subject: test: Remove the side-effect from the assertion Coverity complains about this code as it doesn't know that the OSMO_ASSERT is always on. But it is good practice to now have the side-effect in here. Fixes: Coverity CID 1080724 --- tests/emu/test_replay_gprs_attach.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'tests/emu') diff --git a/tests/emu/test_replay_gprs_attach.cpp b/tests/emu/test_replay_gprs_attach.cpp index 9bcab575..8d29a72f 100644 --- a/tests/emu/test_replay_gprs_attach.cpp +++ b/tests/emu/test_replay_gprs_attach.cpp @@ -78,7 +78,8 @@ void test_replay_gprs_data(struct gprs_bssgp_pcu *pcu, struct msgb *msg, struct OSMO_ASSERT(ph.cmd == GPRS_LLC_UI); OSMO_ASSERT(ph.sapi == 1); - OSMO_ASSERT(ph.seq_tx == next_wanted_nu++); + OSMO_ASSERT(ph.seq_tx == next_wanted_nu); + next_wanted_nu += 1; /* this test just wants to see messages... no further data is sent */ if (next_wanted_nu == 6) { -- cgit v1.2.3