From 846fd248dc49c06441da6d7c3cd85df479810f1a Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Thu, 22 Apr 2021 20:40:10 +0200 Subject: Stop abusing T3169 Now that we finally handle N3101 and N3103 correctly, we can fix abuse of T3169 we were doing to make sure TBFs were freed. According to 3GPP TS 44.060, T3169 should be armed: * N3101_MAX reached * N3103_MAX reached Furthermore, when T3169 is enabled, the tbf should be in state RELEASING so that its USF is not used. See full description: https://osmocom.org/issues/5033#note-2 Related: OS#5033 Change-Id: I2cec531e2633281b88f69ba065c0105580c81076 --- src/tbf_ul.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/tbf_ul.cpp') diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index ff291ef7..7a4e3a36 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -156,7 +156,6 @@ gprs_rlcmac_ul_tbf *tbf_alloc_ul(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t } tbf->m_contention_resolution_done = 1; TBF_SET_ASS_ON(tbf, GPRS_RLCMAC_FLAG_PACCH, false); - T_START(tbf, T3169, 3169, "allocation (UL-TBF)", true); tbf->update_ms(tlli, GPRS_RLCMAC_UL_TBF); OSMO_ASSERT(tbf->ms()); @@ -361,9 +360,6 @@ int gprs_rlcmac_ul_tbf::rcv_data_block_acknowledged( uint32_t new_tlli = GSM_RESERVED_TMSI; unsigned int block_idx; - /* restart T3169 */ - T_START(this, T3169, 3169, "acked (data)", true); - /* Increment RX-counter */ this->m_rx_counter++; update_coding_scheme_counter_ul(rlc->cs); -- cgit v1.2.3