From f5c97476de68ac7ce2fba48be1e7502c1c794606 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Fri, 26 Dec 2014 18:32:00 +0100 Subject: tbf: Fix dereference before null check m_new_tbf might be NULL. Assign was_releasing _after_ we have done the NULL check. Related: Coverity CID#1238847 --- src/tbf.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tbf.cpp b/src/tbf.cpp index 2afe2576..680a096a 100644 --- a/src/tbf.cpp +++ b/src/tbf.cpp @@ -565,7 +565,6 @@ struct msgb *gprs_rlcmac_tbf::create_dl_ass(uint32_t fn) } new_dl_tbf = static_cast(m_new_tbf); - new_dl_tbf->was_releasing = was_releasing; if (!new_dl_tbf) { LOGP(DRLCMACDL, LOGL_ERROR, "We have a schedule for downlink " "assignment at uplink %s, but there is no downlink " @@ -574,6 +573,7 @@ struct msgb *gprs_rlcmac_tbf::create_dl_ass(uint32_t fn) return NULL; } + new_dl_tbf->was_releasing = was_releasing; msg = msgb_alloc(23, "rlcmac_dl_ass"); if (!msg) return NULL; -- cgit v1.2.3