Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2013-10-30 | bts: Move rcv_imm_ass_cnf into the bts code | Holger Hans Peter Freyther | 5 | -44/+42 | |
2013-10-30 | tbf: kill the indirection and invoke the right method | Holger Hans Peter Freyther | 1 | -9/+4 | |
2013-10-30 | tbf/bts: Move the tfi_find_free into the bts | Holger Hans Peter Freyther | 6 | -61/+60 | |
2013-10-30 | tbf/pdch/bts: Move the tbf look-up by tfi into the BTS | Holger Hans Peter Freyther | 4 | -29/+26 | |
2013-10-30 | pdch/tbf: Add another todo item for badly placed code... | Holger Hans Peter Freyther | 1 | -0/+1 | |
2013-10-30 | sba/pdch: Use thepdch to look up a sba for a frame number | Holger Hans Peter Freyther | 3 | -2/+9 | |
2013-10-30 | pdch: Remove the trx_no/ts_no parameter and use/caclulate it on demand | Holger Hans Peter Freyther | 2 | -25/+24 | |
Simplify the depedencies and use the inline functions when we need to figure out the numbers. | |||||
2013-10-30 | pdch: Remove the bts argument from rcv_control_block | Holger Hans Peter Freyther | 2 | -24/+22 | |
2013-10-30 | pdch: Remove the the bts parameter from rcv_data_block_acknowledged | Holger Hans Peter Freyther | 2 | -8/+21 | |
2013-10-30 | tbf: Fix typo in the debug message | Holger Hans Peter Freyther | 1 | -2/+2 | |
2013-10-30 | tbf: Add todo item tht could help improving debugging | Holger Hans Peter Freyther | 1 | -0/+1 | |
2013-10-30 | tbf: Move the timer routine into the class | Holger Hans Peter Freyther | 4 | -13/+16 | |
The timer is used for various timeouts and there is still external client code that is calling it. In a perfect world the client code would indicate that an event has happened and the internal timer will be stopped. The best compromise is the "stop_t3191" method. It allows to add semantic verification that the timer has been running. | |||||
2013-10-30 | tbf: Move the handle tineout into the tbf class | Holger Hans Peter Freyther | 2 | -23/+25 | |
2013-10-30 | tbf: Move the updating of the data into the tbf class | Holger Hans Peter Freyther | 3 | -11/+11 | |
2013-10-30 | pdch: Move the giant switch/case of gprs_rlcmac_rcv_control_block | Holger Hans Peter Freyther | 6 | -272/+274 | |
Move the dispatch into the PDCH. This needs to be split up further into understandable blocks. | |||||
2013-10-30 | pdch/tbf: Move gprs_rlcmac_rcv_data_block_acknowledged into the pdch | Holger Hans Peter Freyther | 10 | -472/+571 | |
Move the method into the PDCH. Extract the finding of TLLI into a new class called Decoding. Move the assemble and forward LLC frames into the TBF as it is poking in the internals of the TBF. | |||||
2013-10-30 | pdch: Move the dispatch of gprs_rlcmac_rcv_block into the pdch | Holger Hans Peter Freyther | 3 | -39/+29 | |
2013-10-30 | pdch: Instead of passing bts, trx, ts use the pdch | Holger Hans Peter Freyther | 3 | -3/+14 | |
All dispatching will go through the PDCH. This will clean a lot of the look-ups inside the gprs_rlcmac_data.c and continue with adding structure to the pcu code. | |||||
2013-10-30 | misc: Remove the bts parameter from calls that take a tbf | Holger Hans Peter Freyther | 4 | -35/+35 | |
Mark some of the tbf manipulation that is burried in the data sending routine.. that it should be moved around. | |||||
2013-10-30 | sched: Add another warning about trx->arfcn and arfcn.. | Holger Hans Peter Freyther | 1 | -0/+2 | |
2013-10-30 | alloc: Remove the ts parameter from the internal interface | Holger Hans Peter Freyther | 1 | -13/+11 | |
2013-10-30 | pdch: Simplify the reset code, rename variables to XYZ_no | Holger Hans Peter Freyther | 5 | -14/+15 | |
Simplify the reset code now that the PDCH can know where it is located. Rename the variables in the sba to trx_no and ts_no as it stores the number and not the actual thing. | |||||
2013-10-30 | bts: Add backpointers to the PDCH and TRX structures | Holger Hans Peter Freyther | 2 | -0/+21 | |
This will allow to kill various parameters from all the functions as we can walk back. | |||||
2013-10-30 | tbf: First round of removing llc handling from the rlcmac_data | Holger Hans Peter Freyther | 3 | -53/+60 | |
The code in gprs_rlcmac_data should ask the TBF for help in packing the frames but it really shouldn't poke in the internals of the tbf structure. This is very bad capsuling and has plenty of copy and paste. At the same thime this will be the most dangerous refactoring of the code base. | |||||
2013-10-30 | data: Move gprs_rlcmac_cs to the place it is used and make static | Holger Hans Peter Freyther | 3 | -11/+10 | |
2013-10-30 | bts/tbf: Move the lists into the BTS and do the look-up from the BTS | Holger Hans Peter Freyther | 13 | -134/+141 | |
The list belongs to the BTS. This makes cleaning this up more easy and establishes a hierachy of resources that start from the BTS. The debug_diagram code is now broken. | |||||
2013-10-30 | tbf: Keep a pointer from the tbf to the BTS | Holger Hans Peter Freyther | 3 | -5/+9 | |
This is preparing the next commits and will ease working with the debug_diagram when the global lists are killed. It will simplify the APIin the long run. | |||||
2013-10-30 | sba: Create a SBAController that will manage the sbas for a BTS | Holger Hans Peter Freyther | 11 | -51/+117 | |
The PollController is a friend of the SBAController and is allowed to access the internal list. The list is hidden from everyone else. This is done because the calculation of timeout should belong into the PollController and not into the SBAController. | |||||
2013-10-30 | sba: Move the sba code to a dedicated file | Holger Hans Peter Freyther | 6 | -89/+125 | |
Move the code around and then turn it into an object... | |||||
2013-10-30 | ta: Create TimingAdvance class and make it belong to the BTS | Holger Hans Peter Freyther | 8 | -30/+76 | |
This allows us to easily flush the state in case a PCU/BTS connection is lost. | |||||
2013-10-30 | ta: Move timing advance related code into the ta.cpp file | Holger Hans Peter Freyther | 3 | -103/+135 | |
2013-10-30 | encoding: Move the functions into the encoding class | Holger Hans Peter Freyther | 7 | -48/+88 | |
Add some TODO to this class. E.g. they could all work on the bitvec and the parameter handling could better. | |||||
2013-10-30 | encoding: Move encoding routines into a separate file | Holger Hans Peter Freyther | 4 | -432/+460 | |
2013-10-30 | pdch: Only say we have paged when this has actually been done | Holger Hans Peter Freyther | 1 | -1/+1 | |
2013-10-30 | bts/pdch: Move the adding of paging to the BTS/PDCH objects | Holger Hans Peter Freyther | 5 | -88/+93 | |
Only the gprs_rlcmac_pdch will manipulate the paging list now. There can be various more refactorings of the code but they can be done later. E.g. on memory allocation failure we can continue instead of leaving the code, we should also set any_tbf only after things have been paged. | |||||
2013-10-30 | pdch: Move paging dequeue into the PDCH object | Holger Hans Peter Freyther | 5 | -103/+104 | |
Rely on packet_paging_request returning NULL in case the queue is empty. We should move the write_packet_paging_request into a separate file/object as well. | |||||
2013-10-30 | pdch: Move enable/disable into the PDCH code | Holger Hans Peter Freyther | 7 | -42/+76 | |
When a PDCH is disabled all resources should be freed. This is currently not possible as the PDCH does not know where it belongs to. On top of that the list (and other resources) should be properly initialized on construction so that disable() is idempotent and does not check if it was disabled. During the re-factoring I noticed that during a sysmobts re-start some resources are not freed. I left a warning in the code to resolve this issue later. | |||||
2013-10-30 | bts: Introduce a PollController that has the responsibility to poll | Holger Hans Peter Freyther | 6 | -33/+124 | |
For each frame indication received by the BTS the poll controller is asked to expire timedout entries. | |||||
2013-10-30 | bts: Move the frame_number into the BTS sructure | Holger Hans Peter Freyther | 5 | -16/+30 | |
The current_frame is an attribute of the BTS. Move it from the pcu_l1_if.cpp into the BTS. As the next step we can trigger actions depending on the change of the frame. | |||||
2013-10-30 | bts: Introduce a singleton for the BTS and use it in the code | Holger Hans Peter Freyther | 8 | -33/+112 | |
Compared to the previous code there will be a branch to get the global pointer so the code will be slightly slower than the previous version but it allows us to start creating objects but still use the code from C. It is best approach I have found so far. One downside of C++ is that by default talloc will not be used (unless we override the new operator to use talloc. Right now we need to memset the C data structure by hand. The benefit of enforcing a better structure should is more important though. | |||||
2013-10-30 | bts: Move struct gprs_rlcmac_bts and other structs into a bts.h | Holger Hans Peter Freyther | 13 | -50/+96 | |
Begin to make the BTS a real C++ object with real responsibilities. The biggest issue will be the pcu_vty.c that might not like C++ at all. | |||||
2013-10-30 | bts: Remove the global state from the tbf | Holger Hans Peter Freyther | 3 | -5/+5 | |
2013-10-30 | bts: Remove global state from gprs_rlcmac_rcv_rts_block | Holger Hans Peter Freyther | 3 | -4/+5 | |
2013-10-30 | bts: Remove global state from gprs_rlcmac_add_paging | Holger Hans Peter Freyther | 3 | -4/+4 | |
2013-10-30 | bts: Remove global state from write_immediate_assignment | Holger Hans Peter Freyther | 3 | -6/+9 | |
2013-10-30 | bts: Remove global state from write_packet_uplink_assignment | Holger Hans Peter Freyther | 3 | -4/+7 | |
2013-10-30 | bts: Remove global state from gprs_rlcmac_send_packet_uplink_assignment | Holger Hans Peter Freyther | 3 | -2/+3 | |
This was the last method of gprs_rlcmac_data.cpp to access the gprs_rlcmac_bts variable. | |||||
2013-10-30 | bts: Remove global state frm gprs_rlcmac_rcv_control_block | Holger Hans Peter Freyther | 3 | -4/+5 | |
2013-10-30 | bts: Remove global state from gprs_rlcmac_send_data_block_acknowledged | Holger Hans Peter Freyther | 3 | -4/+6 | |
2013-10-30 | bts: Remove global state from gprs_rlcmac_send_packet_downlink_assignment | Holger Hans Peter Freyther | 3 | -4/+3 | |