aboutsummaryrefslogtreecommitdiffstats
path: root/src/tbf.cpp
AgeCommit message (Collapse)AuthorFilesLines
2013-11-26rlc: Make the RLC types only operate on the BSNHolger Hans Peter Freyther1-25/+20
The code has an internal optimization to only use window_size space. This means that the caller needed to know that only half of the size was used. Change the API to work on the BSN and do the mapping internally. The compiler should have plenty of opportunity to propagate the constant(s) but this has not been verified.
2013-11-26tbf: Separate the handling for rh->si and call in case of re-transmissionHolger Hans Peter Freyther1-8/+14
In case of a retransmission ack the window again..
2013-11-26tbf/sched: We pick the _last_ entry, rotate the listsHolger Hans Peter Freyther1-0/+9
We always pick the _last_ entry from the lists. Let's rotate so we make it a bit more fair.
2013-11-26tbf/rlc: Move raising of V(Q) into the ul window codeHolger Hans Peter Freyther1-11/+7
2013-11-26rlc/tbf: Move the code to raise V(R) into the ul_window handlingHolger Hans Peter Freyther1-14/+3
2013-11-26tbf/rlc: Move the putting of a block into the rlc codeHolger Hans Peter Freyther1-2/+1
2013-11-26tbf: Move the extraction of the TLLI into a separate methodHolger Hans Peter Freyther1-38/+47
2013-11-26tbf/rlc: Remove the side-effect from the loop.Holger Hans Peter Freyther1-7/+8
2013-11-26tbf: Reduce complexity and deal with only one way of assignmentHolger Hans Peter Freyther1-16/+4
The normal mode of the PCU doesn't really work right now. There is no place to have certain kind of features that are not built and not unit-tested.
2013-11-26tbf/rlc: Move the check if something is in the window out.Holger Hans Peter Freyther1-6/+3
2013-11-26tbf/rlc: Move the v_n handling into a dedicated objectHolger Hans Peter Freyther1-5/+4
2013-11-26tbf/rlc: Big change and move the window handling out to the rlcHolger Hans Peter Freyther1-65/+53
The send and receive window is now managed by an external object. There are some issues that can only be solved with C++11 but it is progres and removes some of the spaghetti code. For GPRS the sns and ws is hardcoded. Move that into the window code.
2013-11-26tbf: Update the legend and mention invalid as wellHolger Hans Peter Freyther1-1/+1
We should not see it but the legend should be complete.
2013-11-26tbf/rlc: Move the counting of unacked frames into the RLC V_B classHolger Hans Peter Freyther1-8/+4
Whenwe receive a final ack we assume that all the unacked frames have been acked now. Move the counting to V_B and now the caller can remove the BSN and the "lost" variable which has always been zero.
2013-11-26tbf: Split the handling of DL ACK/NACK into two separate partsHolger Hans Peter Freyther1-59/+67
Split the handling of the final ack and the handling of frames that is moving frames.
2013-11-26tbf/rlc: Change the code and generate the entire state in the V_BHolger Hans Peter Freyther1-8/+4
2013-11-26tbf/rlc: Move the moving of V(A) into the V_B codeHolger Hans Peter Freyther1-8/+2
Move the code that moves the V_B to the first not acked frame. Return how many indexes the V_B was moved and update the V_A in the caller.
2013-11-26tbf/rlc: Move the parsing of RBB to Decoding, move window marking outHolger Hans Peter Freyther1-26/+8
Move the parsing of the bitbmap out of the TBF code into Decoding. Move the updating of the V_B into the V_B class. Add some comments about handling the mod_sns, mod_sns_half parameters by using template code.
2013-11-26tbf: Fix the indention of this routineHolger Hans Peter Freyther1-1/+1
2013-11-26debug_diagram: Remove the special debug_diagram compilation modeHolger Hans Peter Freyther1-64/+0
This approach is somehow flawed. We need/want to debug problems on systems with real traffic and re-compiling it with debug_diagram is not an option. All internal logging needs to be expressive enough so we can understand what is going on (e.g. create a script to post-process the output).
2013-11-26tbf: Simplify the create_dl_acked_block into two partsHolger Hans Peter Freyther1-13/+21
Separate the resend from creating a new block. It shows that the first_fin_ack is always set to FALSE for re-sending. This might not be what we want.
2013-11-26tbf/rlc: Move the marking of frames for resend into the v_bHolger Hans Peter Freyther1-12/+4
2013-11-26tbf: Move the check if the window is stalled to a separate methodHolger Hans Peter Freyther1-2/+7
2013-11-26rlc/tbf: Move the loop into the gprs_rlc_v_b classHolger Hans Peter Freyther1-13/+12
2013-11-24tbf: Count how often we re-start a BSN in the send routineHolger Hans Peter Freyther1-2/+3
There appears to be a scheduling issue. Even without any NACKs we are re-transmitting a lot of frames. It might be because of this.
2013-11-23tbf: Always increase the tx_counter when we transmit a frameHolger Hans Peter Freyther1-6/+4
In case the ACK could not be scheduled we were not increasing the tx_counter. Change the code flow to always increase the tx_counter after we have created a frame.
2013-11-23tbf: Make the ws and sns number "private" (they should also be const)Holger Hans Peter Freyther1-13/+13
2013-11-23rlc: Move the ack state array into a separate class that can be testedHolger Hans Peter Freyther1-17/+14
2013-11-23rlc: Count nacked frames in the statistics tooHolger Hans Peter Freyther1-0/+1
2013-11-19rlc: Start to move things out of the tbf into the rlcHolger Hans Peter Freyther1-10/+13
Add remarks of possible broken behavior inside the tbf routines. Move the preparation (and init) into the new rlc.cpp file.
2013-11-19tbf: The memory regions overlap so memmove should be usedDaniel Willmann1-2/+2
2013-11-19rlc: Count the window stalls on the RLC levelHolger Hans Peter Freyther1-1/+3
2013-11-13rlc: Pass the gprs_rlc_data to the assemble function for assemblyHolger Hans Peter Freyther1-3/+5
2013-11-13rlc: Put a block and the length into a separate objectHolger Hans Peter Freyther1-9/+9
This will ease passing things around.
2013-11-13rlc: Begin to move the rlc block handling into a separate objectHolger Hans Peter Freyther1-9/+9
The secret of gprs_rlc will be the manipulation of the blocks for the current window. We might add the window handling in this class as well.
2013-11-13rlc: Count the sent and resent RLC blocksHolger Hans Peter Freyther1-0/+4
2013-11-13tbf: Re-use the code that is re-using the tbfHolger Hans Peter Freyther1-24/+25
Address the fixme and re-use the code. Fix the counting in the final ack case and provide a log message in the other case. Prefix it with the tbf name
2013-11-13llc: Move the decision if a frame has expired into the LLCHolger Hans Peter Freyther1-4/+1
This way the generation of the expiry information and the check is at the same place. This should make reading the code more easy.
2013-11-13llc: Move some more secrets from the TBF into the LLCHolger Hans Peter Freyther1-20/+20
Introduce a method to append data to a TBF and then reset the read pointer when the frame has been sent.
2013-11-13bts: Count the number of llc frames that were "scheduled" to be sentHolger Hans Peter Freyther1-1/+5
This does not mean that they have been successfully transferred to the SGSN/MS but at least that they have reached a certain point in the message flow.
2013-11-13llc: Use timeradd and timercmp and fix for < 1s PDU llc timeoutsHolger Hans Peter Freyther1-4/+5
2013-11-13llc: Move the timeout calculation into the TBFHolger Hans Peter Freyther1-17/+1
2013-11-13tbf: Count how often we re-use a TBF that was already being deactivatedHolger Hans Peter Freyther1-0/+1
2013-11-13llc: Remove one of the two variants to put data into the frameHolger Hans Peter Freyther1-2/+2
2013-11-11llc: Add another warning for me to take a lookHolger Hans Peter Freyther1-0/+1
2013-11-11tbf: Make sure that tfi is signed so we can make a < 0 checkHolger Hans Peter Freyther1-1/+1
For the failure check we need this variable to be < 0. Fixes: Coverity CID 1107941
2013-11-07llc: Move all direct accesses to the frame into the llc structureHolger Hans Peter Freyther1-10/+6
Add some todo items where we could add assertions now that I see the constraints and invariants of this code.
2013-11-07tbf: Split create_dl_acked_block into two methodsHolger Hans Peter Freyther1-9/+17
The method was more than 300 hundred lines of code. Split the selection of the index and the creation of the dl_msg.
2013-11-07tbf: Move the tbf_handle and tbf_append_data into the classHolger Hans Peter Freyther1-20/+17
2013-11-07llc: Move the llc code out of the tbf.cpp into a new dedicated oneHolger Hans Peter Freyther1-49/+0
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-20 00:33:10 +0000