Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2013-11-19 | tbf: The memory regions overlap so memmove should be used | Daniel Willmann | 1 | -2/+2 | |
2013-11-19 | rlc: Count the window stalls on the RLC level | Holger Hans Peter Freyther | 1 | -1/+3 | |
2013-11-13 | rlc: Pass the gprs_rlc_data to the assemble function for assembly | Holger Hans Peter Freyther | 1 | -3/+5 | |
2013-11-13 | rlc: Put a block and the length into a separate object | Holger Hans Peter Freyther | 1 | -9/+9 | |
This will ease passing things around. | |||||
2013-11-13 | rlc: Begin to move the rlc block handling into a separate object | Holger Hans Peter Freyther | 1 | -9/+9 | |
The secret of gprs_rlc will be the manipulation of the blocks for the current window. We might add the window handling in this class as well. | |||||
2013-11-13 | rlc: Count the sent and resent RLC blocks | Holger Hans Peter Freyther | 1 | -0/+4 | |
2013-11-13 | tbf: Re-use the code that is re-using the tbf | Holger Hans Peter Freyther | 1 | -24/+25 | |
Address the fixme and re-use the code. Fix the counting in the final ack case and provide a log message in the other case. Prefix it with the tbf name | |||||
2013-11-13 | llc: Move the decision if a frame has expired into the LLC | Holger Hans Peter Freyther | 1 | -4/+1 | |
This way the generation of the expiry information and the check is at the same place. This should make reading the code more easy. | |||||
2013-11-13 | llc: Move some more secrets from the TBF into the LLC | Holger Hans Peter Freyther | 1 | -20/+20 | |
Introduce a method to append data to a TBF and then reset the read pointer when the frame has been sent. | |||||
2013-11-13 | bts: Count the number of llc frames that were "scheduled" to be sent | Holger Hans Peter Freyther | 1 | -1/+5 | |
This does not mean that they have been successfully transferred to the SGSN/MS but at least that they have reached a certain point in the message flow. | |||||
2013-11-13 | llc: Use timeradd and timercmp and fix for < 1s PDU llc timeouts | Holger Hans Peter Freyther | 1 | -4/+5 | |
2013-11-13 | llc: Move the timeout calculation into the TBF | Holger Hans Peter Freyther | 1 | -17/+1 | |
2013-11-13 | tbf: Count how often we re-use a TBF that was already being deactivated | Holger Hans Peter Freyther | 1 | -0/+1 | |
2013-11-13 | llc: Remove one of the two variants to put data into the frame | Holger Hans Peter Freyther | 1 | -2/+2 | |
2013-11-11 | llc: Add another warning for me to take a look | Holger Hans Peter Freyther | 1 | -0/+1 | |
2013-11-11 | tbf: Make sure that tfi is signed so we can make a < 0 check | Holger Hans Peter Freyther | 1 | -1/+1 | |
For the failure check we need this variable to be < 0. Fixes: Coverity CID 1107941 | |||||
2013-11-07 | llc: Move all direct accesses to the frame into the llc structure | Holger Hans Peter Freyther | 1 | -10/+6 | |
Add some todo items where we could add assertions now that I see the constraints and invariants of this code. | |||||
2013-11-07 | tbf: Split create_dl_acked_block into two methods | Holger Hans Peter Freyther | 1 | -9/+17 | |
The method was more than 300 hundred lines of code. Split the selection of the index and the creation of the dl_msg. | |||||
2013-11-07 | tbf: Move the tbf_handle and tbf_append_data into the class | Holger Hans Peter Freyther | 1 | -20/+17 | |
2013-11-07 | llc: Move the llc code out of the tbf.cpp into a new dedicated one | Holger Hans Peter Freyther | 1 | -49/+0 | |
2013-11-07 | llc: First routines moved from the TBF into the LLC | Holger Hans Peter Freyther | 1 | -28/+62 | |
2013-11-06 | llc: Begin creating a LLC class and move counts into it. | Holger Hans Peter Freyther | 1 | -40/+39 | |
Begin to move state of the LLC into a separate object. This will allow to make side-effects more clear and kill some code duplication. | |||||
2013-11-06 | tbf: Move the tx part into the tbf as it accesses internal data | Holger Hans Peter Freyther | 1 | -4/+29 | |
2013-11-06 | tbf: Move the llc handling into the tbf (from the bts) | Holger Hans Peter Freyther | 1 | -0/+194 | |
This will be moved to a LLC class in the future but after this we can make the sns/ws private now and have little to update outside the tbf. | |||||
2013-10-30 | tbf: Update the timing advance for the new tlli based on the old one | Holger Hans Peter Freyther | 1 | -0/+3 | |
2013-10-30 | tbf: Learn and propagate the TLLI changes due a new P-TMSI | Holger Hans Peter Freyther | 1 | -3/+26 | |
During a routing area update a new P-TMSI was assigned. During the PACKET CONTROL ACK on the DL we notice the change of TLLI but didn't propagate this. This means that a Routing Area Update Complete was only sent after a new RACH request. Addresses: <0007> gprs_rlcmac_meas.cpp:103 UL RSSI of TLLI=0x88661bc6: -67 dBm <0002> bts.cpp:945 Got ACK, but UL TBF is gone TLLI=0xe512eba3 <0007> gprs_rlcmac_meas.cpp:158 DL packet loss of IMSI=274080000004765 / TLLI=0xe512eba3: 0% <0002> tbf.cpp:668 TBF TFI=0 TLLI=0x88661bc6 T3169 timeout during transsmission <0002> tbf.cpp:690 - Assignment was on PACCH <0002> tbf.cpp:694 - No uplink data received yet | |||||
2013-10-30 | tbf: Have one imsi field and assign it through a function | Holger Hans Peter Freyther | 1 | -9/+9 | |
Have one IMSI field per TBF and assign through a function call. The IMSI should be used to look-up the TBF on the SGSN->PCU direction. | |||||
2013-10-30 | tbf: Make tfi private and update the code | Holger Hans Peter Freyther | 1 | -31/+32 | |
All logging code that used tbf->tfi is now using tbf_name to print the the TBF. External code is now using tfi() which is inlined and should result in the same code being generated as before (+debug code that can be stripped). | |||||
2013-10-30 | tbf: Make the tlli "private" and update the updating code | Holger Hans Peter Freyther | 1 | -13/+29 | |
Now all updates to the tlli/tlli_valid are in one place. If we implement the policy to update the matching/linked TBF we can now to do it in a single place. Add a todo item for that as I am waiting for feedback from the mailinglist. | |||||
2013-10-30 | tbf: Create tbf_name and use it in log statements | Holger Hans Peter Freyther | 1 | -57/+64 | |
This is like gsm_lchan_name and should be used in log statements. This way we can easily change the information that is printed and we know how to search things. The other part is that direct use of tfi/tlli is removed which will allow us to make them private and at the same time start to resolve the "tlli" updated in many places. Not old log statements are changed yet. This will done whenever a bad log statement is seen on the console... | |||||
2013-10-30 | tbf: Remove the trx_no field from the tbf, go through the trx object | Holger Hans Peter Freyther | 1 | -6/+5 | |
2013-10-30 | tbf: Go through the trx to get the ARFCN | Holger Hans Peter Freyther | 1 | -1/+0 | |
2013-10-30 | bts: Further logging improvements for TFI/TLLI output | Holger Hans Peter Freyther | 1 | -2/+2 | |
2013-10-30 | tbf: Log the TFI and TLLI so we can try to figure out more from logs | Holger Hans Peter Freyther | 1 | -10/+12 | |
<0002> tbf.cpp:444 Poll timeout for DL TBF=0 <0002> tbf.cpp:513 - Timeout for polling PACKET DOWNLINK ACK. <0002> tbf.cpp:688 - Assignment was on PACCH <0002> tbf.cpp:694 - Downlink ACK was received <0008> gprs_bssgp_pcu.cpp:154 LLC [SGSN -> PCU] = TLLI: 0xd6942c78 IMSI: 274080000004765 len: 506 <0002> bts.cpp:974 PACKET DOWNLINK ACK with unknown FN=2213128 TFI=0 (TRX 0 TS 6) | |||||
2013-10-30 | misc: Change the logging for the tbf and what to log | Holger Hans Peter Freyther | 1 | -25/+25 | |
TLLIs got printed as TBF. Fix that but also rename things to TFI. The TFI is not required to be unique per BTS but it is the indicator we use right now. | |||||
2013-10-30 | misc: Fix typo.. resource in english only has one 's' | Holger Hans Peter Freyther | 1 | -7/+7 | |
2013-10-30 | llc: Count timedout and silently dropped frames | Holger Hans Peter Freyther | 1 | -1/+4 | |
A DL tbf can be discarded and then the already queued LLCs will be silently dropped. Count this event. | |||||
2013-10-30 | bts: Provide the first set of counters | Holger Hans Peter Freyther | 1 | -2/+11 | |
2013-10-30 | tbf: Move gprs_rlcmac_send_data_block_acknowledged into tbf | Holger Hans Peter Freyther | 1 | -0/+331 | |
We can now remove the gprs_rlcmac_data as the code has been moved into the tbf, pdch and bts. | |||||
2013-10-30 | tbf: Move gprs_rlcmac_send_packet_uplink_assignment into the tbf | Holger Hans Peter Freyther | 1 | -0/+140 | |
2013-10-30 | tbf: Move gprs_rlcmac_send_packet_uplink_assignment to the tbf | Holger Hans Peter Freyther | 1 | -0/+73 | |
Again the function was called send but didn't do any sending | |||||
2013-10-30 | tbf: Fix typo in thecomment | Holger Hans Peter Freyther | 1 | -1/+1 | |
2013-10-30 | tbf: Move gprs_rlcmac_send_uplink_ack into the tbf | Holger Hans Peter Freyther | 1 | -0/+53 | |
The method was called send but didn't send anything. Move it to the tbf | |||||
2013-10-30 | tbf: Move gprs_rlcmac_send_packet_downlink_assignment into the tbf | Holger Hans Peter Freyther | 1 | -0/+94 | |
This method was called _send_packet_ but actually didn't do any sending at all. It just formated the right assignment. I replaced tbf-> with nothing. | |||||
2013-10-30 | bts: Move gprs_rlcmac_trigger_downlink_assignment into BTS | Holger Hans Peter Freyther | 1 | -2/+2 | |
2013-10-30 | debug_dl_ass_idle: Remove the feature as it is obviously broken | Holger Hans Peter Freyther | 1 | -5/+0 | |
strncpy takes three arguments but only two are given. This feature would also only work if there is one tbf at a time. | |||||
2013-10-30 | tbf: Move gprs_rlcmac_poll_timeout into the tbf | Holger Hans Peter Freyther | 1 | -0/+104 | |
Move the gprs_rlcmac_poll_timeout method into the tbf class and gprs_rlcmac_downlink_assignment into the BTS. | |||||
2013-10-30 | tbf/bts: Move the tfi_find_free into the bts | Holger Hans Peter Freyther | 1 | -2/+2 | |
2013-10-30 | tbf/pdch/bts: Move the tbf look-up by tfi into the BTS | Holger Hans Peter Freyther | 1 | -22/+0 | |
2013-10-30 | tbf: Fix typo in the debug message | Holger Hans Peter Freyther | 1 | -2/+2 | |