Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2014-06-04 | bts: Remove outdated comment | Daniel Willmann | 1 | -1/+0 | |
There is no parameter in the function and the bts has a memeber trx which has a member pdch. Sponsored-by: On-Waves ehf | |||||
2014-06-04 | gprs_rlcmac_pdch: Get rid of ul/dl_tbf | Daniel Willmann | 1 | -8/+18 | |
The current code keeps a reference to all tbfs in the bts and another reference in the pdch. This allows for the possibility of both lists to go out of sync. This patch removes the pdch-specific list of ul and dl tbfs and uses the lists in the bts to lookup tbfs everywhere. Performance for going through the global list is not an issue yet. We can optimize this later and in a better way. Sponsored-by: On-Waves ehf | |||||
2014-06-04 | gprs_rlcmac_pdch: Don't access private members | Daniel Willmann | 1 | -0/+14 | |
This patch introduces methods to get ul and dl tbf by tfi and uses them in gprs_rlcmac_sched. Sponsored by: On-Waves ehf | |||||
2014-05-30 | tbf/bts, encoding: Keep track of WAIT_RELEASE state for DL assignment | Daniel Willmann | 1 | -0/+2 | |
The current code does not properly distinguish between DL assignments to reuse a tbf (after it was put in state WAIT_RELEASE) and DL assignments for an active tbf to change the allocation of the PDCH timeslots. This patch introduces a new variable was_releasing which remembers if trigger_dl_ass() was called with a tbf in state WAIT_RELEASE. In that case we have to set the CONTROL_ACK field in the download assignment. This should allow us to send DL assignments to change PDCH TS allocation of a tbf before we enter FLOW state. | |||||
2014-05-30 | tbf/bts: Rename tbf->snd_dl_ack to tbf->rcvd_dl_ack | Daniel Willmann | 1 | -1/+1 | |
This function is called to act upon a received DL ACK packet so this name makes more sense. | |||||
2014-01-16 | tbf: Make finding use-after-free more easy and set to NULL or return | Holger Hans Peter Freyther | 1 | -0/+1 | |
Make finding use-after-free more easy by setting things to NULL or simply return after tbf_free(this) has been called. | |||||
2014-01-15 | bts: Rename ts and trx to ts_no and trx_no as we operate on number | Holger Hans Peter Freyther | 1 | -6/+6 | |
2014-01-15 | tbf: Kill the tsc member as it duplicates data | Holger Hans Peter Freyther | 1 | -2/+2 | |
We can just use first_ts and the trx/pdch to extract this information. Avoid duplication of data. | |||||
2013-11-26 | debug_diagram: Remove the special debug_diagram compilation mode | Holger Hans Peter Freyther | 1 | -6/+0 | |
This approach is somehow flawed. We need/want to debug problems on systems with real traffic and re-compiling it with debug_diagram is not an option. All internal logging needs to be expressive enough so we can understand what is going on (e.g. create a script to post-process the output). | |||||
2013-11-24 | tbf: Count how often we re-start a BSN in the send routine | Holger Hans Peter Freyther | 1 | -0/+1 | |
There appears to be a scheduling issue. Even without any NACKs we are re-transmitting a lot of frames. It might be because of this. | |||||
2013-11-23 | rlc: Count nacked frames in the statistics too | Holger Hans Peter Freyther | 1 | -0/+1 | |
2013-11-19 | rlc: Count the window stalls on the RLC level | Holger Hans Peter Freyther | 1 | -0/+1 | |
2013-11-13 | rlc: Count the sent and resent RLC blocks | Holger Hans Peter Freyther | 1 | -0/+2 | |
2013-11-13 | bts: Count the number of llc frames that were "scheduled" to be sent | Holger Hans Peter Freyther | 1 | -0/+1 | |
This does not mean that they have been successfully transferred to the SGSN/MS but at least that they have reached a certain point in the message flow. | |||||
2013-11-13 | tbf: Count how often we re-use a TBF that was already being deactivated | Holger Hans Peter Freyther | 1 | -0/+1 | |
2013-11-06 | tbf: Move the llc handling into the tbf (from the bts) | Holger Hans Peter Freyther | 1 | -186/+1 | |
This will be moved to a LLC class in the future but after this we can make the sns/ws private now and have little to update outside the tbf. | |||||
2013-10-30 | tbf: Have one imsi field and assign it through a function | Holger Hans Peter Freyther | 1 | -1/+1 | |
Have one IMSI field per TBF and assign through a function call. The IMSI should be used to look-up the TBF on the SGSN->PCU direction. | |||||
2013-10-30 | tbf: Make tfi private and update the code | Holger Hans Peter Freyther | 1 | -17/+18 | |
All logging code that used tbf->tfi is now using tbf_name to print the the TBF. External code is now using tfi() which is inlined and should result in the same code being generated as before (+debug code that can be stripped). | |||||
2013-10-30 | tbf: Make the tlli "private" and update the updating code | Holger Hans Peter Freyther | 1 | -25/+21 | |
Now all updates to the tlli/tlli_valid are in one place. If we implement the policy to update the matching/linked TBF we can now to do it in a single place. Add a todo item for that as I am waiting for feedback from the mailinglist. | |||||
2013-10-30 | tbf: Create tbf_name and use it in log statements | Holger Hans Peter Freyther | 1 | -21/+17 | |
This is like gsm_lchan_name and should be used in log statements. This way we can easily change the information that is printed and we know how to search things. The other part is that direct use of tfi/tlli is removed which will allow us to make them private and at the same time start to resolve the "tlli" updated in many places. Not old log statements are changed yet. This will done whenever a bad log statement is seen on the console... | |||||
2013-10-30 | tbf: TODO:Mark TLLI changes as todo item in the code | Holger Hans Peter Freyther | 1 | -0/+2 | |
The TLLI can change when a new P-TMSI is assigned to the phone, e.g. during a (periodic) routing area update. When the TLLI changes we need to update all TBFs and maybe even register the timing advance for the new TLLI.. | |||||
2013-10-30 | bts: Simplify rcv_resource_request, remove logically dead code | Holger Hans Peter Freyther | 1 | -57/+57 | |
tbf = find if (tbf) { tbf_free(tbf); tbf = NULL; } if (!tbf) { code... } Remove the if (!tbf) and indention as the tbf is always to be NULL. | |||||
2013-10-30 | bts: Kill dead stores of the tlli/tfi, fix the log message again | Holger Hans Peter Freyther | 1 | -9/+5 | |
The code meant to print the tfi and not the tlli. Update it. | |||||
2013-10-30 | tbf: Remove the trx_no field from the tbf, go through the trx object | Holger Hans Peter Freyther | 1 | -7/+7 | |
2013-10-30 | tbf: Go through the trx to get the ARFCN | Holger Hans Peter Freyther | 1 | -2/+2 | |
2013-10-30 | bts: Further logging improvements for TFI/TLLI output | Holger Hans Peter Freyther | 1 | -1/+2 | |
2013-10-30 | bts: Pass the Packet_Control_Acknowledgement_t into the recv method | Holger Hans Peter Freyther | 1 | -3/+3 | |
2013-10-30 | bts: Log the TLLI inside the report we get | Holger Hans Peter Freyther | 1 | -1/+1 | |
2013-10-30 | tbf: Log the TFI and TLLI so we can try to figure out more from logs | Holger Hans Peter Freyther | 1 | -1/+1 | |
<0002> tbf.cpp:444 Poll timeout for DL TBF=0 <0002> tbf.cpp:513 - Timeout for polling PACKET DOWNLINK ACK. <0002> tbf.cpp:688 - Assignment was on PACCH <0002> tbf.cpp:694 - Downlink ACK was received <0008> gprs_bssgp_pcu.cpp:154 LLC [SGSN -> PCU] = TLLI: 0xd6942c78 IMSI: 274080000004765 len: 506 <0002> bts.cpp:974 PACKET DOWNLINK ACK with unknown FN=2213128 TFI=0 (TRX 0 TS 6) | |||||
2013-10-30 | misc: Change the logging for the tbf and what to log | Holger Hans Peter Freyther | 1 | -22/+22 | |
TLLIs got printed as TBF. Fix that but also rename things to TFI. The TFI is not required to be unique per BTS but it is the indicator we use right now. | |||||
2013-10-30 | bts: Use Packet_Downlink_Ack_Nack_t as parameter | Holger Hans Peter Freyther | 1 | -7/+7 | |
2013-10-30 | bts: Simplify the code and use Packet_Resource_Request_t* | Holger Hans Peter Freyther | 1 | -9/+9 | |
2013-10-30 | bts: Work with the Packet_Measurement_Report_t | Holger Hans Peter Freyther | 1 | -4/+4 | |
2013-10-30 | bts: Move the MT_PACKET_MEASUREMENT_REPORT handling to a new method | Holger Hans Peter Freyther | 1 | -14/+18 | |
2013-10-30 | bts: Move handling of MT_PACKET_RESOURCE_REQUEST to a method | Holger Hans Peter Freyther | 1 | -80/+88 | |
Move the code to a new method | |||||
2013-10-30 | bts: Move handling of MT_PACKET_DOWNLINK_ACK_NACK to separate function | Holger Hans Peter Freyther | 1 | -43/+51 | |
Kill the tlli assignment as it is never used. | |||||
2013-10-30 | pdch: Move handling of control_ack to a separate method | Holger Hans Peter Freyther | 1 | -86/+94 | |
Kill the unused tfi parameter | |||||
2013-10-30 | bts: Count the rach frames we receive | Holger Hans Peter Freyther | 1 | -0/+6 | |
2013-10-30 | misc: Fix typo.. resource in english only has one 's' | Holger Hans Peter Freyther | 1 | -6/+6 | |
2013-10-30 | bts: Print the kind of message type not known. | Holger Hans Peter Freyther | 1 | -1/+3 | |
2013-10-30 | llc: Count timedout and silently dropped frames | Holger Hans Peter Freyther | 1 | -0/+2 | |
A DL tbf can be discarded and then the already queued LLCs will be silently dropped. Count this event. | |||||
2013-10-30 | sba: Move freeing a sba into a central place | Holger Hans Peter Freyther | 1 | -8/+2 | |
2013-10-30 | sba: Count SBA allocation, frees and timeouts | Holger Hans Peter Freyther | 1 | -0/+7 | |
Add a warning about the receive message poking in the internal of the sba. This will be cleaned up in a follow up commit | |||||
2013-10-30 | bts: Provide the first set of counters | Holger Hans Peter Freyther | 1 | -0/+3 | |
2013-10-30 | bts: Start creating statistics inside the BTS code | Holger Hans Peter Freyther | 1 | -0/+33 | |
2013-10-30 | tbf: Move gprs_rlcmac_send_packet_uplink_assignment into the tbf | Holger Hans Peter Freyther | 1 | -1/+1 | |
2013-10-30 | bts: Move gprs_rlcmac_rcv_rach into the BTS class | Holger Hans Peter Freyther | 1 | -0/+81 | |
2013-10-30 | bts: Move gprs_rlcmac_trigger_downlink_assignment into BTS | Holger Hans Peter Freyther | 1 | -0/+38 | |
2013-10-30 | tbf: Move gprs_rlcmac_poll_timeout into the tbf | Holger Hans Peter Freyther | 1 | -0/+19 | |
Move the gprs_rlcmac_poll_timeout method into the tbf class and gprs_rlcmac_downlink_assignment into the BTS. | |||||
2013-10-30 | bts: Move rcv_imm_ass_cnf into the bts code | Holger Hans Peter Freyther | 1 | -0/+39 | |