diff options
| author | Aravind Sirsikar <arvind.sirsikar@radisys.com> | 2016-09-15 17:24:49 +0530 |
|---|---|---|
| committer | Aravind Sirsikar <arvind.sirsikar@radisys.com> | 2016-09-15 17:24:49 +0530 |
| commit | 22a901905c9749b03fceccda4d550f3da799d524 (patch) | |
| tree | 16ab25248b1dd773a7cf14c8f3aaaeaed7eb5a3b /tests/tbf | |
| parent | 3463bd4adc1598462560ed84da837d04d0e8e20c (diff) | |
EGPRS: Fix issue with row 4 of Table 10.4.14a.1 of 44.060 version 7.27.0 Release 7
row 4 of Table 10.4.14a.1 of Spec 44.060 version 7.27.0 Release 7. Says
"The previous RLC data block contains a Upper Layer PDU, or a part of it,
that fills precisely the previous data block and for which there is no
length indicator in that RLC data block.
The current RLC data block contains a Upper Layer PDU that either fills
the current RLC data block precisely or continues in the next RLC data block."
So when we receive block with 1st LI: value=0 and Value of E bit in the
same octet as 1, we expect 2 chunks with 1st chunk as length as 0 and complete
and 2nd chunk as length non zero. But with this bug we see only 1 chunk causing
incorrect assembling
This issue has been fixed in this patch.
Related: OS#1811
Change-Id: I2cd0fca3ed28a553ede3f4b8a7d3267284dd2c9b
Diffstat (limited to 'tests/tbf')
| -rw-r--r-- | tests/tbf/TbfTest.cpp | 3 | ||||
| -rw-r--r-- | tests/tbf/TbfTest.err | 5 |
2 files changed, 5 insertions, 3 deletions
diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index 36aadc5f..4e37aa80 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -1980,8 +1980,7 @@ static gprs_rlcmac_ul_tbf *tbf_li_decoding(BTS *the_bts, data_msg[5] = 0x0; pdch->rcv_block(data_msg, 49, *fn, &meas); - /* TODO: should expect m_index as 43 */ - OSMO_ASSERT(ul_tbf->m_llc.m_index == 87); + OSMO_ASSERT(ul_tbf->m_llc.m_index == 43); return ul_tbf; } diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index 06b63ebb..90f04bee 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -6489,7 +6489,10 @@ TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS): data_length=44, data=01 00 0 - Raising V(R) to 2 - Taking block 1 out, raising V(Q) to 2 - Assembling frames: (len=44) --- Frame 1 starts at offset 1, length=43, is_complete=0 +TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) complete UL frame len=44 +LLC [PCU -> SGSN] TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS) len=44 +No bctx +-- Frame 2 starts at offset 1, length=43, is_complete=0 - No gaps in received block, last block: BSN=1 CV=7 Got 'TBF(TFI=0 TLLI=0xf1223344 DIR=UL STATE=FLOW EGPRS)', TA=7 Got MS: TLLI = 0xf1223344, TA = 7 |