aboutsummaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2023-06-12 18:01:53 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2023-06-12 18:05:42 +0200
commit84011ef86a21f1a935141aea6918db08d69e8768 (patch)
treee87be6cede1feedfad95b241939e602c3194d5f6 /src
parente656c210a116311cabb53bf2f6068feea2c07fbb (diff)
Improve logging in bts_snd_dl_ass()
Change macro to LOGPTBFDL since it's assigning a DL TBF. Clarify and join log lines. Change-Id: Ic5e01289f97bc113ba0a376a535e0cce5bccc5d1
Diffstat (limited to 'src')
-rw-r--r--src/bts.cpp10
1 files changed, 4 insertions, 6 deletions
diff --git a/src/bts.cpp b/src/bts.cpp
index 44e98c06..77d8738a 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -1099,12 +1099,12 @@ int bts_rcv_ptcch_rach(struct gprs_rlcmac_bts *bts, const struct rach_ind_params
void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, const struct gprs_rlcmac_dl_tbf *tbf)
{
int plen;
- const struct gprs_rlcmac_pdch *pdch;
-
- LOGPTBF(tbf, LOGL_INFO, "TX: START Immediate Assignment Downlink (PCH)\n");
/* Only one TS can be assigned through PCH, hence the first one is the only one: */
- pdch = tbf_get_first_ts_const(tbf);
+ const struct gprs_rlcmac_pdch *pdch = tbf_get_first_ts_const(tbf);
+ OSMO_ASSERT(pdch);
+
+ LOGPTBFDL(tbf, LOGL_INFO, "Tx CCCH (PCH) Immediate Assignment [PktDlAss=%s] TA=%d\n", pdch_name(pdch), tbf->ta());
bitvec *immediate_assignment = bitvec_alloc(22, tall_pcu_ctx); /* without plen */
bitvec_unhex(immediate_assignment, DUMMY_VEC); /* standard '2B'O padding */
@@ -1113,8 +1113,6 @@ void bts_snd_dl_ass(struct gprs_rlcmac_bts *bts, const struct gprs_rlcmac_dl_tbf
* that the resource reference cannot be confused with any CHANNEL REQUEST
* message sent by a mobile station. Use last_rts_fn + 21216 (16 TDMA
* super-frame periods, or ~21.3 seconds) to achieve a decent distance. */
- LOGP(DRLCMAC, LOGL_DEBUG, " - TRX=%d (%d) TS=%d TA=%d\n",
- tbf->trx->trx_no, tbf->trx->arfcn, pdch->ts_no, tbf->ta());
plen = Encoding::write_immediate_assignment(pdch,
tbf, immediate_assignment, true, 125,
fn2rfn(GSM_TDMA_FN_SUM(pdch->last_rts_fn, 21216)),