diff options
| author | Pau Espin Pedrol <pespin@sysmocom.de> | 2021-11-11 13:19:54 +0100 |
|---|---|---|
| committer | pespin <pespin@sysmocom.de> | 2021-11-12 12:03:00 +0000 |
| commit | bd1b90f1412a5d4b686d1a93b5ac50bdb1228b84 (patch) | |
| tree | 3c3a50756787c5c807bbfa633132bf02d236fa32 /src | |
| parent | 84f2b51a372a19af54f4ba6100635ab8edd6ea81 (diff) | |
tbf_dl_ass_fsm: Fix missing transition to NONE if DL TBF is nonexistent
If by the time the PktDlAss is to be scheduled by the scheduler the DL
TBF is gone, the FSM will abort the assignment and go back to state
NONE.
However, the transition was missing, ending up in the scheduler trying
to schedule the message unsuccessfuly lots of times per second, clogging
the logs and disrupting normal operation.
Related: OS#5293
Change-Id: I6f421e5ddc9894fee72de1102df35a76cf2f2647
Diffstat (limited to 'src')
| -rw-r--r-- | src/tbf_dl_ass_fsm.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/tbf_dl_ass_fsm.c b/src/tbf_dl_ass_fsm.c index efc872aa..555380df 100644 --- a/src/tbf_dl_ass_fsm.c +++ b/src/tbf_dl_ass_fsm.c @@ -208,7 +208,9 @@ static struct osmo_fsm_state tbf_dl_ass_fsm_states[] = { }, [TBF_DL_ASS_SEND_ASS] = { .in_event_mask = X(TBF_DL_ASS_EV_CREATE_RLCMAC_MSG), - .out_state_mask = X(TBF_DL_ASS_WAIT_ACK), + .out_state_mask = + X(TBF_DL_ASS_WAIT_ACK) | + X(TBF_DL_ASS_NONE), .name = "SEND_ASS", .action = st_send_ass, }, |