diff options
author | Pau Espin Pedrol <pespin@sysmocom.de> | 2020-05-08 17:44:33 +0200 |
---|---|---|
committer | pespin <pespin@sysmocom.de> | 2020-05-12 17:09:20 +0000 |
commit | 17402a59027b60bd49f3feee1b6e56fd804da29a (patch) | |
tree | d0559aa18bf6cde50b85823f80adeeda3be706f2 /src/tbf.h | |
parent | f094b46d1c058c5f77035cb0f8983c57894d3d63 (diff) |
Expect ms object to exist before calling tbf_alloc_ul_tbf()
It's really non-sense from architectural point of view to pass an
optional pointer to the MS holding the TBF and creating it otherwise.
TBFs shouldn't be creating MS they belong too.
This simple change requiring so many code line changes really exhibits
how badly entangled the object relationship is.
Another commit will follow doing the same for dl tbf.
Change-Id: I010aa5877902816ae246e09ad5ad87946f96855c
Diffstat (limited to 'src/tbf.h')
-rw-r--r-- | src/tbf.h | 8 |
1 files changed, 3 insertions, 5 deletions
@@ -346,12 +346,10 @@ private: }; -struct gprs_rlcmac_ul_tbf *tbf_alloc_ul(struct gprs_rlcmac_bts *bts, - int8_t use_trx, uint8_t ms_class, uint8_t egprs_ms_class, - uint32_t tlli, uint8_t ta, GprsMs *ms); +struct gprs_rlcmac_ul_tbf *tbf_alloc_ul(struct gprs_rlcmac_bts *bts, GprsMs *ms, + int8_t use_trx, uint32_t tlli, uint8_t ta); -struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx, uint8_t ms_class, - uint8_t egprs_ms_class, bool single_slot); +struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx, bool single_slot); struct gprs_rlcmac_dl_tbf *tbf_alloc_dl_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx, uint8_t ms_class, uint8_t egprs_ms_class, bool single_slot); |