aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2023-06-01 19:21:55 +0200
committerpespin <pespin@sysmocom.de>2023-06-06 10:59:24 +0000
commit08b6a00afdce56c6ea956322b0e25b218221da9d (patch)
tree54d7f6e627c6e621dc79d4b8cfa3cadd5fa3faac
parent2549c1e696cc4991a7b5f15f2f81b909b9da6c1b (diff)
Log MS information in error message using usual MS API
Also, drop duplicated TRX+TS info which is already displayed as part of LOGPDCH. Change-Id: I66211f4fa8a139ddd109623d90a926a53f180cfd
-rw-r--r--src/pdch.cpp13
1 files changed, 3 insertions, 10 deletions
diff --git a/src/pdch.cpp b/src/pdch.cpp
index b265d713..9ceb9440 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -344,19 +344,12 @@ void gprs_rlcmac_pdch::rcv_control_ack(Packet_Control_Acknowledgement_t *packet,
poll = pdch_ulc_get_node(ulc, fn);
if (!poll || poll->type != PDCH_ULC_NODE_TBF_POLL) {
- LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with "
- "unknown FN=%u TLLI=0x%08x (TRX %d TS %d)\n",
- fn, tlli, trx_no(), ts_no);
+ LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with unknown FN=%u TLLI=0x%08x\n",
+ fn, tlli);
ms = bts_get_ms_by_tlli(bts(), tlli, GSM_RESERVED_TMSI);
if (ms)
LOGPDCH(this, DRLCMAC, LOGL_NOTICE, "PACKET CONTROL ACK with "
- "unknown TBF corresponds to MS with IMSI %s, TA %d, "
- "uTBF (TFI=%d, state=%s), dTBF (TFI=%d, state=%s)\n",
- ms_imsi(ms), ms_ta(ms),
- ms_ul_tbf(ms) ? ms_ul_tbf(ms)->tfi() : 0,
- ms_ul_tbf(ms) ? ms_ul_tbf(ms)->state_name() : "None",
- ms_dl_tbf(ms) ? ms_dl_tbf(ms)->tfi() : 0,
- ms_dl_tbf(ms) ? ms_dl_tbf(ms)->state_name() : "None");
+ "unknown TBF corresponds to %s\n", ms_name(ms));
return;
}
OSMO_ASSERT(poll->tbf_poll.poll_tbf);