aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPau Espin Pedrol <pespin@sysmocom.de>2023-06-09 17:39:29 +0200
committerPau Espin Pedrol <pespin@sysmocom.de>2023-06-09 18:38:28 +0200
commit89fbf87abf9d99ec7a6d8df5a42cef79d3fa964a (patch)
treedc599d259a4c1269c9a3167ac290e1b0faa5eb79
parentd8c38777a1464e9ada60fd06e2a7e089fca55b11 (diff)
Avoid using N3103 in DL TBFs
N3103 counts retransmits of PACKET UPLINK ACK/NACK with FinalACK=1. As a consequence, this counter only applies to UL TBFs. Current code is only using it in UL TBF, but add an assert to clarify and make sure it is not used unproperly in the future. Change-Id: I026d6145249ef19694f673ec7b4928af9d401dd6
-rw-r--r--src/tbf.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/src/tbf.cpp b/src/tbf.cpp
index bc5411ac..47256f87 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -313,6 +313,9 @@ void gprs_rlcmac_tbf::n_reset(enum tbf_counters n)
case N3101:
OSMO_ASSERT(direction == GPRS_RLCMAC_UL_TBF);
break;
+ case N3103:
+ OSMO_ASSERT(direction == GPRS_RLCMAC_UL_TBF);
+ break;
default:
break;
}
@@ -335,6 +338,7 @@ bool gprs_rlcmac_tbf::n_inc(enum tbf_counters n)
chk = bts->n3101;
break;
case N3103:
+ OSMO_ASSERT(direction == GPRS_RLCMAC_UL_TBF);
chk = bts->n3103;
break;
case N3105: