diff options
author | Pau Espin Pedrol <pespin@sysmocom.de> | 2021-11-02 18:46:40 +0100 |
---|---|---|
committer | laforge <laforge@osmocom.org> | 2021-11-08 18:33:04 +0000 |
commit | cc77eed9d9d3c35986cb358fba08081d64dfbe57 (patch) | |
tree | 3a9006f003b8dbe7d04f6e9bd4409b4e13ddaf11 | |
parent | 10b29153b735b1199f3bc4a0b91ea90e31ab5895 (diff) |
tbf_ul: Improve documentation of tbf_alloc_ul_pacch()
Change-Id: I59493788b4a54610a70f3eb4c31fd05f6e39e63d
-rw-r--r-- | src/tbf_ul.cpp | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index f0d16b51..9390fbbe 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -151,7 +151,12 @@ struct gprs_rlcmac_ul_tbf *tbf_alloc_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs return tbf; } -/* Alloc a UL TBF to be assigned over PACCH */ +/* Alloc a UL TBF to be assigned over PACCH. Called when an MS requests to + * create a new UL TBF during the end of life of a previous UL TBF (or an SBA). + * In summary, this TBF is allocated as a consequence of receiving a "Pkt + * Resource Req" or "Pkt Ctrl Ack" from the MS. + * See TS 44.060 9.3.2.4.2 "Non-extended uplink TBF mode". + */ gprs_rlcmac_ul_tbf *tbf_alloc_ul_pacch(struct gprs_rlcmac_bts *bts, GprsMs *ms, int8_t use_trx) { struct gprs_rlcmac_ul_tbf *tbf; @@ -162,6 +167,7 @@ gprs_rlcmac_ul_tbf *tbf_alloc_ul_pacch(struct gprs_rlcmac_bts *bts, GprsMs *ms, /* Caller will most probably send a Imm Ass Reject after return */ return NULL; } + /* Contention resolution is considered to be done since TLLI is known in MS: */ tbf->m_contention_resolution_done = 1; osmo_fsm_inst_dispatch(tbf->state_fsm.fi, TBF_EV_ASSIGN_ADD_PACCH, NULL); |