From 04bbfb83d4247c351dc15aede49ac1f8c9d5dcb7 Mon Sep 17 00:00:00 2001 From: Vadim Yanitskiy Date: Sat, 15 Jun 2019 15:15:55 +0700 Subject: libmsc/gsm_09_11.c: fix: return trans from establish_nc_ss_trans() It is expected that establish_nc_ss_trans() returns an allocated transaction in successful case, or NULL in case of error. The function assumes two scenarios: - the subscriber already has an active RAN connection, - RAN connection needs to be established (Paging). In the first case, a pointer to the transaction is returned as expected, but in case of Paging, NULL has always been returned, even if there were no errors. Let's fix this. Change-Id: I9dcee64dd0b435ef29630c223132b81724701f93 --- src/libmsc/gsm_09_11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/libmsc/gsm_09_11.c') diff --git a/src/libmsc/gsm_09_11.c b/src/libmsc/gsm_09_11.c index 3de933c31..39b9711e4 100644 --- a/src/libmsc/gsm_09_11.c +++ b/src/libmsc/gsm_09_11.c @@ -409,7 +409,7 @@ static struct gsm_trans *establish_nc_ss_trans(struct gsm_network *net, msgb_tlv_put(trans->ss.msg, GSM0480_IE_FACILITY, gsup_msg->ss_info_len, gsup_msg->ss_info); - return NULL; + return trans; } /* NC SS specific transaction release. -- cgit v1.2.3