From e586f41692f1e7d2386c52ae9caa81b6d9a2de08 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Thu, 17 Nov 2016 18:39:36 +0100 Subject: pcu_sock: get rid of magic numbers and use ARRAY_SIZE() for array iteration Change-Id: I602b581fab67b3a1c3c03c73a3a99e9afd564e29 --- openbsc/src/libbsc/pcu_sock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'openbsc') diff --git a/openbsc/src/libbsc/pcu_sock.c b/openbsc/src/libbsc/pcu_sock.c index 0f3dc1b81..e713b086e 100644 --- a/openbsc/src/libbsc/pcu_sock.c +++ b/openbsc/src/libbsc/pcu_sock.c @@ -211,7 +211,7 @@ static int pcu_tx_info_ind(struct gsm_bts *bts) info_ind->initial_mcs = rlcc->initial_mcs; /* NSVC */ - for (i = 0; i < 2; i++) { + for (i = 0; i < ARRAY_SIZE(info_ind->nsvci); i++) { nsvc = &bts->gprs.nsvc[i]; info_ind->nsvci[i] = nsvc->nsvci; info_ind->local_port[i] = nsvc->local_port; @@ -219,13 +219,13 @@ static int pcu_tx_info_ind(struct gsm_bts *bts) info_ind->remote_ip[i] = nsvc->remote_ip; } - for (i = 0; i < 8; i++) { + for (i = 0; i < ARRAY_SIZE(info_ind->trx); i++) { trx = gsm_bts_trx_num(bts, i); if (!trx) break; info_ind->trx[i].pdch_mask = 0; info_ind->trx[i].arfcn = trx->arfcn; - for (j = 0; j < 8; j++) { + for (j = 0; j < ARRAY_SIZE(trx->ts); j++) { ts = &trx->ts[j]; if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED && ts_should_be_pdch(ts)) { -- cgit v1.2.3