From 019851a5238e95dd1a089d19d966973b5a61f568 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Sun, 8 Feb 2015 09:21:04 +0100 Subject: smpp: Do not check conn for being null We are deferencing conn earlier in this function without doing a null check. At the time deliver_to_esme is called the conn will always exist and even the lchan is likely to be present. Remove the null check for conn right now. Fixes: Coverity CID 1210594 --- openbsc/src/libmsc/smpp_openbsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'openbsc/src/libmsc/smpp_openbsc.c') diff --git a/openbsc/src/libmsc/smpp_openbsc.c b/openbsc/src/libmsc/smpp_openbsc.c index 686131762..ff5ab400e 100644 --- a/openbsc/src/libmsc/smpp_openbsc.c +++ b/openbsc/src/libmsc/smpp_openbsc.c @@ -530,7 +530,7 @@ static int deliver_to_esme(struct osmo_esme *esme, struct gsm_sms *sms, memcpy(deliver.short_message, sms->user_data, deliver.sm_length); } - if (esme->acl && esme->acl->osmocom_ext && conn && conn->lchan) + if (esme->acl && esme->acl->osmocom_ext && conn->lchan) append_osmo_tlvs(&deliver.tlv, conn->lchan); return smpp_tx_deliver(esme, &deliver); -- cgit v1.2.3