From 086ffa51b4f56eb875e4918a2ee1802581c6cd67 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Tue, 29 Dec 2009 11:26:38 +0100 Subject: [abis] Add ACK signal and send it on SET NVATTR ACK * Add the signal definition to signal.h * Dispatch the signal from abis_nm.c * Handle it in ipaccess-config.c and say we are done with work --- openbsc/include/openbsc/signal.h | 1 + 1 file changed, 1 insertion(+) (limited to 'openbsc/include/openbsc/signal.h') diff --git a/openbsc/include/openbsc/signal.h b/openbsc/include/openbsc/signal.h index 8c815f89e..f13b12be8 100644 --- a/openbsc/include/openbsc/signal.h +++ b/openbsc/include/openbsc/signal.h @@ -69,6 +69,7 @@ enum signal_nm { S_NM_FAIL_REP, /* GSM 12.21 failure event report */ S_NM_NACK, /* GSM 12.21 various NM_MT_*_NACK happened */ S_NM_IPACC_NACK, /* GSM 12.21 nanoBTS extensions NM_MT_IPACC_*_*_NACK happened */ + S_NM_IPACC_ACK, /* GSM 12.21 nanoBTS extensions NM_MT_IPACC_*_*_ACK happened */ S_NM_TEST_REP, /* GSM 12.21 Test Report */ }; -- cgit v1.2.3 From 2e83782b1c185bd63544bdd74de2e5e4d965f981 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Wed, 30 Dec 2009 08:38:43 +0100 Subject: [ipaccess] Restart only after setting the OML IP, software load * Do not issue the restart right aways if we have OML IP or software load in the queue (hint, we need a real queue of operations to carry out... with one big state machine) * Change the signal_data of ipacc ACK/NACK to contain the msg type and the bts pointer. * Issue a restart for software load and OML and use the BTS pointer we got out of the new signal data. --- openbsc/include/openbsc/signal.h | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'openbsc/include/openbsc/signal.h') diff --git a/openbsc/include/openbsc/signal.h b/openbsc/include/openbsc/signal.h index f13b12be8..8b6b4a628 100644 --- a/openbsc/include/openbsc/signal.h +++ b/openbsc/include/openbsc/signal.h @@ -124,6 +124,11 @@ struct scall_signal_data { void *data; }; +struct ipacc_ack_signal_data { + struct gsm_bts *bts; + u_int8_t msg_type; +}; + /* Management */ int register_signal_handler(unsigned int subsys, signal_cbfn *cbfn, void *data); void unregister_signal_handler(unsigned int subsys, signal_cbfn *cbfn, void *data); -- cgit v1.2.3 From 1356c08cc8f22b4b75a845ebd96651577c984744 Mon Sep 17 00:00:00 2001 From: Holger Hans Peter Freyther Date: Wed, 30 Dec 2009 09:00:01 +0100 Subject: [abis] Dispatch a IPAC restart ACK/NACK signal * Add the NACK version to the list * Dispatch the signal when we receive the message * Handle it in ipaccess-config by exiting the application --- openbsc/include/openbsc/signal.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'openbsc/include/openbsc/signal.h') diff --git a/openbsc/include/openbsc/signal.h b/openbsc/include/openbsc/signal.h index 8b6b4a628..23551f743 100644 --- a/openbsc/include/openbsc/signal.h +++ b/openbsc/include/openbsc/signal.h @@ -70,6 +70,8 @@ enum signal_nm { S_NM_NACK, /* GSM 12.21 various NM_MT_*_NACK happened */ S_NM_IPACC_NACK, /* GSM 12.21 nanoBTS extensions NM_MT_IPACC_*_*_NACK happened */ S_NM_IPACC_ACK, /* GSM 12.21 nanoBTS extensions NM_MT_IPACC_*_*_ACK happened */ + S_NM_IPACC_RESTART_ACK, /* nanoBTS has send a restart ack */ + S_NM_IPACC_RESTART_NACK,/* nanoBTS has send a restart ack */ S_NM_TEST_REP, /* GSM 12.21 Test Report */ }; -- cgit v1.2.3 From ef24dff2a22c907f08a24b19773dde5ce20ba5d6 Mon Sep 17 00:00:00 2001 From: Sylvain Munaut Date: Sat, 19 Dec 2009 12:38:10 +0100 Subject: [signal] Differentiate paging success from expiration in SS_PAGING This is useful information to know and actually fixes a segfault in rllp.c where lchan is accessed even tough it could be NULL in case of failure. Signed-off-by: Sylvain Munaut --- openbsc/include/openbsc/signal.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'openbsc/include/openbsc/signal.h') diff --git a/openbsc/include/openbsc/signal.h b/openbsc/include/openbsc/signal.h index 23551f743..07b4e393d 100644 --- a/openbsc/include/openbsc/signal.h +++ b/openbsc/include/openbsc/signal.h @@ -45,7 +45,8 @@ enum signal_subsystems { /* SS_PAGING signals */ enum signal_paging { - S_PAGING_COMPLETED, + S_PAGING_SUCCEEDED, + S_PAGING_EXPIRED, }; /* SS_SMS signals */ -- cgit v1.2.3 From dfe6c7d910edbba238751d0cfddbb627bb08ef54 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sat, 20 Feb 2010 16:24:02 +0100 Subject: split 'libosmocore' from openbsc codebase This library is intended to collect all generic/common funcitionality of all Osmocom.org projects, including OpenBSC but also OsmocomBB The library currently includes the following modules: bitvec, comp128, gsm_utils, msgb, select, signal, statistics, talloc, timer, tlv_parse, linuxlist msgb allocation error debugging had to be temporarily disabled as it depends on 'debug.c' functionality which at the moment remains in OpenBSC --- openbsc/include/openbsc/signal.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) (limited to 'openbsc/include/openbsc/signal.h') diff --git a/openbsc/include/openbsc/signal.h b/openbsc/include/openbsc/signal.h index 07b4e393d..0c22869f6 100644 --- a/openbsc/include/openbsc/signal.h +++ b/openbsc/include/openbsc/signal.h @@ -28,6 +28,7 @@ #include #include +#include /* * Signalling subsystems @@ -110,9 +111,6 @@ enum signal_global { S_GLOBAL_SHUTDOWN, }; -typedef int signal_cbfn(unsigned int subsys, unsigned int signal, - void *handler_data, void *signal_data); - struct paging_signal_data { struct gsm_subscriber *subscr; struct gsm_bts *bts; @@ -132,12 +130,4 @@ struct ipacc_ack_signal_data { u_int8_t msg_type; }; -/* Management */ -int register_signal_handler(unsigned int subsys, signal_cbfn *cbfn, void *data); -void unregister_signal_handler(unsigned int subsys, signal_cbfn *cbfn, void *data); - -/* Dispatch */ -void dispatch_signal(unsigned int subsys, unsigned int signal, void *signal_data); - - #endif -- cgit v1.2.3