From d63776051ebd5962f5e4e651ec282195956eb22e Mon Sep 17 00:00:00 2001 From: Andreas Eversberg Date: Wed, 19 Jul 2023 09:46:18 +0200 Subject: ASCI: Fix wrong check for Null pointer in vgcs_cell_fsm_null() Fixes: CID#322145, CID#322141 Change-Id: Iec0820f612450cde772076131b07fe7819d35790 --- src/libmsc/msc_vgcs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c index 7f72583fc..c6f5e1653 100644 --- a/src/libmsc/msc_vgcs.c +++ b/src/libmsc/msc_vgcs.c @@ -2351,12 +2351,12 @@ static void vgcs_cell_fsm_null(struct osmo_fsm_inst *fi, uint32_t event, void *d /* Set initial mode. */ rtp_stream_set_mode(cell->rtps, MGCP_CONN_RECV_ONLY); /* Commit RTP stream. */ - if (!cell->bss && !cell->bss->trans) { - LOG_CELL(cell, LOGL_DEBUG, "No transaction, cannot continue.\n"); + if (!cell->bss || !cell->bss->trans) { + LOG_CELL(cell, LOGL_DEBUG, "No BSS/transaction, cannot continue.\n"); cell_clear(cell, GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC); break; } - if (!cell->mgw && !cell->mgw->mgw_ep) { + if (!cell->mgw || !cell->mgw->mgw_ep) { LOG_CELL(cell, LOGL_DEBUG, "No MGW endpoint, cannot continue.\n"); cell_clear(cell, GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC); break; -- cgit v1.2.3