From 1fe73a19cda4e0bdbfc932ae69c7b59f84103f59 Mon Sep 17 00:00:00 2001 From: Harald Welte Date: Sun, 29 Jan 2012 13:24:12 +0100 Subject: ARFCNs are in the range of 0..1023, not 0..1024 I'm sure I read somewhere that it actually was 0..1024, as I kept wondering how stupid it was to use 10bit+1. However, that source was incorrect, as GSM TS 05.05 quite clearly states 0..1023 --- openbsc/src/libbsc/bsc_init.c | 4 ++-- openbsc/src/libbsc/bsc_vty.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/openbsc/src/libbsc/bsc_init.c b/openbsc/src/libbsc/bsc_init.c index 529ffc040..441c0a9f0 100644 --- a/openbsc/src/libbsc/bsc_init.c +++ b/openbsc/src/libbsc/bsc_init.c @@ -210,7 +210,7 @@ static int generate_ma_for_ts(struct gsm_bts_trx_ts *ts) /* count the number of ARFCNs in the cell channel allocation */ num_cell_arfcns = 0; - for (i = 1; i < 1024; i++) { + for (i = 0; i < 1024; i++) { if (bitvec_get_bit_pos(cell_chan, i)) num_cell_arfcns++; } @@ -221,7 +221,7 @@ static int generate_ma_for_ts(struct gsm_bts_trx_ts *ts) ts->hopping.ma_len++; n_chan = 0; - for (i = 1; i < 1024; i++) { + for (i = 0; i < 1024; i++) { if (!bitvec_get_bit_pos(cell_chan, i)) continue; /* set the corresponding bit in the MA */ diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c index 0c02552b0..8c39b3a43 100644 --- a/openbsc/src/libbsc/bsc_vty.c +++ b/openbsc/src/libbsc/bsc_vty.c @@ -2240,7 +2240,7 @@ DEFUN(cfg_bts_neigh_mode, cfg_bts_neigh_mode_cmd, } DEFUN(cfg_bts_neigh, cfg_bts_neigh_cmd, - "neighbor-list (add|del) arfcn <0-1024>", + "neighbor-list (add|del) arfcn <0-1023>", "Neighbor List\n" "Add to manual neighbor list\n" "Delete from manual neighbor list\n" "ARFCN of neighbor\n" "ARFCN of neighbor\n") @@ -2264,7 +2264,7 @@ DEFUN(cfg_bts_neigh, cfg_bts_neigh_cmd, } DEFUN(cfg_bts_si5_neigh, cfg_bts_si5_neigh_cmd, - "si5 neighbor-list (add|del) arfcn <0-1024>", + "si5 neighbor-list (add|del) arfcn <0-1023>", "SI5 Neighbor List\n" "Add to manual SI5 neighbor list\n" "Delete from SI5 manual neighbor list\n" "ARFCN of neighbor\n" "ARFCN of neighbor\n") @@ -2322,7 +2322,7 @@ DEFUN(cfg_trx, DEFUN(cfg_trx_arfcn, cfg_trx_arfcn_cmd, - "arfcn <0-1024>", + "arfcn <0-1023>", "Set the ARFCN for this TRX\n") { int arfcn = atoi(argv[0]); -- cgit v1.2.3