aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)AuthorFilesLines
2021-06-24improve logging on encryption, for Ciphering and HOneels/a54Neels Hofmeyr2-2/+14
log the algorithm and all keys instead of just Kc. Change-Id: If7871dedda2b1fb115e6f00da1379ff2e3d68a10
2021-06-24support A5/4 in inter-BSC handoverNeels Hofmeyr2-1/+13
Forward the Kc128 key to the new BSS in BSSMAP Handover Request. Depends: Ieb6e43eef9e57281d54d4b7c63664668df5aef3e (libosmocore) Change-Id: Id5ce995a741c8e469a50a0c46e53c06a2378bb7e
2021-06-24support A5/4 in Cipher Mode CommandNeels Hofmeyr3-3/+35
Related: SYS#5324 Change-Id: I780a739b9bfbefd4f58be051794fe1a491823e67
2021-06-24vty: allow A5/4 encryption in configEric Wild2-2/+3
Add A5/4 to the internal mask of allowed algorithms. (Not actually working yet, A5/4 implementation follows in other patches.) Related: SYS#5324 Change-Id: I5b46aaa8579f8d069ca39caf996a8795ffe63dd7
2021-06-23ran_msg_a.c: use gsm0808_create_cipher2()Neels Hofmeyr2-13/+17
Use new API in Cipher Mode Command to prepare for A5/4 support. Depends: Ib3906085e0c6e5a496a9f755f0f786238a86ca34 (libosmocore) Related: SYS#5324 Change-Id: Ib238d367b8d5d07b6ab4cb2e48fbf4ce22ca4476
2021-06-22osmo-msc main: use osmo_select_shutdown()Neels Hofmeyr1-5/+15
Change-Id: I75f4637c051ed44628e65dab1bdbbf28dcc9626f
2021-06-06msc_tx_common_id(): fix potential NULL pointer dereferenceVadim Yanitskiy1-0/+2
Reported by GCC 11.1.0. msc_a_vsub() may return NULL. Change-Id: Iebdd6399e819a03258398e6b7b453bda37e45a20
2021-06-04Use new osmo stat items/ctr APIsPau Espin Pedrol7-64/+61
Generated using several semantinc patches with spatch. Change-Id: I3ee853539949a763a309856bf2e7196415b23741
2021-04-29Fill Last Used E-UTRAN PLMN Id when in CSFBPau Espin Pedrol9-5/+86
Since recently, osmo-bsc behaves strictly as per specs, meaning it will only send the "Cell selection indicator after release of all TCH and SDCCH IE" in RR Channel Release iff: * "Last Used E-UTRAN PLMN Id" was received in the CommonID sent MSC->BSC * "Last Used E-UTRAN PLMN Id" was received insider "old BSS to new BSS Information" in the HandoverRequest sent MSC->BSC. On the other hand, CSFB_Indicator from ClearCommand MSC->BSC is nw ignored and not taken into account. Hence, let's update osmo-msc to also behave correctly by sending the Last Used E-UTRAN PLMN ID at CommonID tx time to avoid regressions in CSFB support when running against newer osmo-bsc. Let's keep sending the CSFB Indicator in ClearCommand as we used too, in order to keep compatibility with older BSCs (as per spec). Related: SYS#5337 Change-Id: Ic5f175b179973d0a50d94f00e15f5a3e332605fc
2021-04-04SMS-over-GSUP: notify sender if no transaction foundVadim Yanitskiy1-1/+2
Change-Id: I4f564610fadbfdbbc33de267786534a5405319f6
2021-03-09contrib/osmo-msc.spec.in: depend on dbd-sqlite3Oliver Smith1-0/+5
Add the missing runtime dependency to the sqlite3 driver of libdbd. The library does not provide a pkgconfig file, so using "pkgconfig(...)" as done in the BuildRequires is not possible. Write both the OpenSUSE and CentOS name with an if..else. Fixes: <0009> db.c:648 Failed to create database connection to sqlite3 db 'sms.db'; Is the sqlite3 database driver for libdbi installed on this system? Change-Id: Ia972944c300aecbb6ec460b2362aabff459baefd
2021-02-23configure.ac: Depend on newer libosmo-ranapPau Espin Pedrol1-1/+1
I forgot to ammend the release previous release commit with this. Change-Id: I8dbbd63fdbd35f5f90f20dcd7e710078f2d9e12a
2021-02-23Bump version: 1.6.1.98-cad22-dirty → 1.7.01.7.0Pau Espin Pedrol5-35/+152
Change-Id: I1bf25c0c01efd6f93df8ac2b26868dd1579b3531
2021-02-19tests: Replace deprecated API log_set_print_filenamePau Espin Pedrol5-5/+5
Change-Id: I4c1116aafb155b5fb216b01054332dcb91c18401
2021-02-19tests: Explicitly drop category from logPau Espin Pedrol3-0/+4
Let's disable category here since we don't care about its formatting here. In any case, every test relying on logging output validation should always explicitly state the config to avoid issues in the future if default values change. Change-Id: I089c0001fc75e81558c3e860827e4d434cf1eab3 Related: OS#5034
2021-02-18gsm_network: drop unused neighbor_list memberNeels Hofmeyr1-4/+2
Change-Id: I57463ab94773de1377526f9a1c72fe3d37a31827
2021-02-09fix _gsm48_cc_trans_free(): send MNCC REL.ind on Clear RequestVadim Yanitskiy3-12/+10
Calling gsm48_cc_tx_release() before mncc_release_ind() has a side effect: the former may change CC state to GSM_CSTATE_RELEASE_REQ. This makes the later send MNCC_REL_CNF instead of MNCC_REL_IND, so if one of the call leg disconnects due to RF failure, the other one will not be terminated correctly. Makes both TC_{mo,mt}_call_clear_request TTCN-3 test cases pass. Change-Id: I3ad4a99757878de3796027325627c87d9a4e93f1 Related: Id16969fe0de04445d1320a96d35cf1d48cc8cf09 Related: SYS#5340
2021-02-07msc_vlr_tests: make independent of libosmocore tallocNeels Hofmeyr13-346/+18
The msc_vlr_tests verify whether any of the tests run contain msgb or talloc memory leaks. So far they did so by fixating a specific number of talloc blocks, which may break by library implementations changing. Instead, verify that the test leaks no allocations by comparing talloc blocks before and after each test. When a leak is detected, print the full talloc report to stderr, which makes the expected output mismatch the actual output and fails the test. Related: OS#4311 Change-Id: I8537fa76d460c951302932a1bad4299f7fe398c9
2021-02-05ran_a_decode_cipher_mode_reject(): use gsm0808_get_cause()Vadim Yanitskiy1-1/+1
Change-Id: I56dd920b931e769ba4d268b09700fe3c9fca4fc6
2021-02-05submit_to_sms(): fix the use of deprecated gsm_septets2octets()Vadim Yanitskiy2-2/+2
Change-Id: I9985972f0b1d2b71bfd133c5004201a3a0ffcbd0
2021-02-04.gitignore: Ignore new autofoo tmp filesPau Espin Pedrol1-0/+1
Change-Id: Ifb9dfe84575451fdfc9d059bab428da82b448107
2021-01-28configure.ac: set -std=gnu11Oliver Smith1-0/+2
Change-Id: Ie93915f06a8907a80b4f081a00c1cde395015595
2021-01-13contrib/jenkins: don't build osmo-gsm-manualsOliver Smith1-1/+0
Related: OS#4912 Change-Id: I0f4d3b444c22c772498299f7d209fc28080af8c3
2021-01-06README update. Explain more what it is than just the historyHarald Welte1-8/+19
Change-Id: I7368a8a0927fa301dfbbe550b8090e783ab7be2e
2020-11-25main: generate coredump and exit upon SIGABRT receivedPau Espin Pedrol1-6/+15
Previous code relied on abort() switching sigaction to SIG_FDL + retriggering SIGABRT in case the signal handler returns, which would then generate the coredump + terminate the process. However, if a SIGABRT is received from somewhere else (kill -SIGABRT), then the process would print the talloc report and continue running, which is not desired. Change-Id: Iff66eea9ee70850a4d038ece1d8473457023e1ee Fixes: OS#4865
2020-11-11Use osmo_fd_*_{disable,enable}Harald Welte2-6/+7
Change-Id: I5208124e08d3b403492fe83acee235e61e423450 Depends: libosmocore.git Idb89ba7bc7c129a6304a76900d17f47daf54d17d
2020-11-07debian/control: Recommend installation of osmo-mgwHarald Welte1-0/+1
osmo-msc is pretty useless without osmo-mgw these days. Let's not make it a strong dependency, as the mgw could of course be running on different machines. Change-Id: I76c1bf30c733cf2fd596a8971ccb8bac4220be66
2020-10-24main: add --vty-ref-mode, use vty_dump_xml_ref_mode()Vadim Yanitskiy1-11/+34
Change-Id: I66c3521895dd0b9a35e9b75f7766ec8014116246 Depends: Ie2022a7f9e167e5ceacf15350c037dd43768ff40 Related: SYS#4910
2020-10-19Use osmo_fd_setup() whenever applicableHarald Welte2-12/+3
Change-Id: Ib570e2ada619b72001d76d2cae159d78f09d6fb6
2020-10-12contrib/jenkins: Enable parallel make in make distcheckPau Espin Pedrol1-2/+2
Change-Id: I8f112ed6de4b1b7c28fbb790fede0e1a387a4e22 Related: OS#4421
2020-09-26Convert paging response timer into an osmocom own X4 timerAlexander Couzens6-13/+21
All timeout values should use tdef. Change-Id: Ic050eb49ba0c5811b43d8d8b44145a1115fd8546
2020-09-25gsm_04_08: check return code of osmo_mobile_identity_decode_from_l3()Philipp Maier1-1/+6
The function gsm48_rx_cm_reest_req() is the only one where the return code of osmo_mobile_identity_decode_from_l3() is not checked, lets check it here too. Change-Id: I37981205870b094b3a40a20197461208daa62698 Fixes: CID#211037
2020-09-25fix comment in ran_peer.hNeels Hofmeyr1-1/+1
Change-Id: Iff985dfe28265d32cae6a931636d5018a439d39e
2020-09-25drop duplicate ran_peer_find() vs ran_peer_find_by_addr()Neels Hofmeyr2-15/+3
This is the same function existing twice with different names. Keep only one. Change-Id: If54b54fa61ece0f95564d403e1439fc5f5ededdf
2020-09-22Don't Store an SMS in the database when the ESME is not BoundKeith Whyte1-0/+10
We may never be able to deliver this SMS if it depends on the ESME, as we will not resubmit the SMS to the ESME. Better to reject it at this time and have the MS try again later. Change-Id: I2c50904349dd4ed229b60b8468d776b817c0bd44 Related: OS#4740
2020-09-18mncc_call: fix memory overrunPhilipp Maier1-8/+9
The struct gsm_mncc which is created and populated in mncc_call_tx_setup_ind casted to a union mncc_msg* pointer. This leads to a memory overrun in mncc_call_tx because the union mncc_msg is larger then the gsm_mncc struct. To fix this, lets just declare a union mncc_msg and populate the signal member inside it. This can be handed over to mncc_call_tx. The data in it will look the same, except that the memory will have the proper lenght (longer). Change-Id: Ifff28b3375d6bd5e4f837f25c46736952f7bfa9b Fixes: CID 214330
2020-09-18fix MGCP timeout timerNeels Hofmeyr1-1/+1
Timer X1 is not defined in libosmo-mgcp-client, so this tdef had no effect. Change this to X2427. (libosmo-mgcp-client recently moved T2427001 to X2427.) (X2 is still used in call_leg.c itself) Related: OS#4539 Related: If097f52701fd81f29bcca1d252f4fb4fca8a04f7 (osmo-mgw) Change-Id: I9804fdb2c24f49910f2386e3788bd1107b8ebc40
2020-09-14mncc: Support IPv6 addresses (new version mncc 7)pespin/ipv6Pau Espin Pedrol5-22/+29
Change-Id: I6002b648bcb2055dcbbdae3f688f6e2cb7282b7f
2020-09-09Support handling IPv6 Transport Address in Handover Request (Ack)Pau Espin Pedrol1-34/+14
Change-Id: Ie4d07826362d651cd42dc2b4e0af82368a74c774
2020-09-09tests: Fix VTY results after switch to newer libosmo-mgcp-clientPau Espin Pedrol2-2/+3
In this case we are fine with simply updating test result because anyway ABI breakage in some libosmo-mgcp-client structs was needed, so new versions of osmo-msc will require new versions of libosmo-mgcp-client. Change-Id: I1fbdb95f71d3b9a2dc88e1ba79892ae16485aa99
2020-09-08Support handling IPv6 Transport Address in Assignment CompletePau Espin Pedrol1-10/+1
Change-Id: Ib650bb063404a3068b4cf3c376c6080dc29bebfe
2020-09-08Support sending IPv6 Transport Address in Assignment CommandPau Espin Pedrol1-17/+40
Change-Id: Ida43f10a41afbd275233f0ef102287522a2e7099
2020-08-28vty: allow configuring db path from cfg fileKeith Whyte18-126/+146
So far, the cmdline argument was the only way to set a database file. Add a similar config to VTY as 'msc' / 'sms-database'. The cmdline arg is stronger than the 'database' cfg item. DB is not reloaded from VTY command. Change-Id: I18d954c30fcceb0b36a620b927fd3a93dcc79f49
2020-08-24Change default SCTP conn NULL->127.0.0.1 to localhost->localhostPau Espin Pedrol1-2/+3
"127.0.0.1" is changed to "localhost" to let local NSS decide whether to use IPv4 or IPv6. In newish systems, IPv6 ::1 will be selected since IPv6 takes precedence over IPv4. Similarly, the default source addr needs to be changed from NULL to "localhost" since for some yet unknwon reason, getaddrinfo(AF_UNSPEC, NULL) returns first IPv4 "0.0.0.0" and later "::", which is inconsistent with getaddrinfo("localhost") result, resulting in src=IPv4(0.0.0.0) and dst=IPv6(::1), which is incompatible and will fail. In any case, since the default remote address is a local one and it's the client side, there's no real logical change since the kernel would anyway should have taken a local address anyway. Change-Id: I05a5c792ab1d053c6f38ba36d4b9fa6db293fbd0
2020-08-24mncc_builtin: log type of unhandled message in int_mncc_recv()Vadim Yanitskiy1-1/+2
Change-Id: Ie65b2da4c3a13ac36132a2f8c9c85cc420c7a5a6
2020-08-24mncc_builtin: cosmetic: fix coding style in int_mncc_recv()Vadim Yanitskiy1-1/+1
Change-Id: Iffef3c094a5d030663d312a379e846a8eb917942
2020-08-24fix crash for unknown MI during Paging ResponseNeels Hofmeyr1-1/+6
Related: OS#4724 Related: I40496bbccbbd9c496cfa57df49e26f124a2b1554 (osmo-ttcn3-hacks) Change-Id: Ia2c8fa745cfab17ed7114d433f625ddc02ae7b11
2020-08-20Support setting rt-prio and cpu-affinity mask through VTYPau Espin Pedrol5-7/+10
Change-Id: I40cf8a86961c1e350b5cd74d6e2cf64a22b7a2b1 Depends: libosmocore.git Change-Id If76a4bd2cc7b3c7adf5d84790a944d78be70e10a Depends: osmo-gsm-masnuals.git Change-Id Icd75769ef630c3fa985fc5e2154d5521689cdd3c Related: SYS#4986
2020-08-20configure.ac: Drop trailing whitespacePau Espin Pedrol1-1/+1
Change-Id: I48dee161f6951777dc86b61da13793d6309b86bb
2020-08-17Send "BSSMAP CommonID" to tell BSC about the IMSIHarald Welte14-14/+195
We're already sending the RANAP CommonID message to the RNC, let's do the same using BSSMAP CommonId towards the BSC. This way the BSC knows about the IMSI of the served subscriber, which is very useful for logging/debugging. Change-Id: I2552736477663adb250c55728093500e8ae83ebb Closes: OS#2969 Depends: libosmocore.git I353adc1aa72377f7d4b3336d2ff47791fb73d62c