diff options
author | Neels Hofmeyr <neels@hofmeyr.de> | 2018-04-09 23:34:47 +0200 |
---|---|---|
committer | Neels Hofmeyr <neels@hofmeyr.de> | 2018-04-10 02:15:02 +0200 |
commit | f840e6fe988acafb0c321824effacf9ba64d0142 (patch) | |
tree | 056ea369ba9e137c7d28b2d9486a4049d342a577 /src | |
parent | f95d5be0ae406522cd1e03a89208ff8abb0c3580 (diff) |
trans_free: drop bad assertion
I assumed that trans_free() would always be called before freeing the FSM. But
the actual conn free dance that tries to make sure a release is triggered from
all directions actually may run into a situation where conn->fi is NULL.
The situation is described in OS#3125.
For now simply drop the assert.
The subscr conn and FSM dealloc will soon be glued firmly together; but I want
to add a test against OS#3062 before that, and that would also hit above assertion.
Related: OS#3125 OS#3062
Change-Id: I5c30e0f9545fb76615776ff6cc16b56aeb5b043a
Diffstat (limited to 'src')
-rw-r--r-- | src/libmsc/transaction.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index 5b033dc80..66b929afa 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -158,9 +158,6 @@ void trans_free(struct gsm_trans *trans) trans->conn = NULL; talloc_free(trans); - /* trans_free() should always happen while the fi is still around. */ - OSMO_ASSERT(conn->fi); - /* Possibly this was the last transaction used by this conn. */ subscr_conn_release_when_unused(conn); } |