diff options
| author | Neels Hofmeyr <neels@hofmeyr.de> | 2019-05-09 15:12:34 +0200 |
|---|---|---|
| committer | Harald Welte <laforge@gnumonks.org> | 2019-05-10 07:04:50 +0000 |
| commit | 7f85acea9bb9f80e208820958f4cae63625f3689 (patch) | |
| tree | 92b3a86566ad323a3ae8da41ba36131f92fbf18d /src/libmsc/transaction.c | |
| parent | da3ce717b84cfd7ecd12e4d5f8905409a4216cb4 (diff) | |
LOG_TRANS: store subsys in trans, unify USSD logging back to DMM
Instead of calling trans_log_subsys() for each LOG_TRANS() log line, rather
store in trans->log_subsys once on trans_alloc() and use that.
Do not fall back to the RAN's own subsystem (DBSSAP / DIUCS), it makes little
sense and may cause logging to switch subsystems depending on the RAN state.
In trans_log_subsys(), add missing switch cases:
- Log silent call transactions also on CC.
- Log USSD on DMM.
About USSD: we currently have no dedicated USSD logging category. As a result,
after LOG_TRANS() was introduced [1], USSD logged on DBSSAP/DIUCS or DMSC,
depending on whether a RAN was associated with the trans or not. Before that
change, USSD always logged on DMM, so, until we have a separate logging
category for USSD, consistenly use DMM again.
[1] in I2e60964d7a3c06d051debd1c707051a0eb3101ba / ff7074a0c7b62025473d8f1a950905ac2cb2f31c
Related: coverity CID 198453
Change-Id: I6dfe5b98fb9e884c2dde61d603832dafceb12123
Diffstat (limited to 'src/libmsc/transaction.c')
| -rw-r--r-- | src/libmsc/transaction.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index b909cd89b..d6f8c3b17 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -146,6 +146,7 @@ struct gsm_trans *trans_alloc(struct gsm_network *net, .callref = callref, .net = net, }; + trans->log_subsys = trans_log_subsys(trans); vlr_subscr_get(vsub, trans_vsub_use(type)); llist_add_tail(&trans->entry, &net->trans_list); |